Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC9AD3955CA for ; Tue, 13 Oct 2026 16:20:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791908455; cv=none; b=tg1smnb1k0youaiP+iPs26sm8U7wDj4zTKnBDk/sDQ6S1wHDttsoGQWL6aYzQkataT4wXjy/4l7dJlZFQedynC3G7yR8Q3H8YCe+QlcU5vwDKCK2/dmi6vLTtr1WrlVSPZErUZ+CX5UZ+7/vck5agOJrbSEfTonMFPkprBmsf0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791908455; c=relaxed/simple; bh=v04mpo0JNMgTecnlxVTBeL6HJ02ClQMha4tdQcn5bwQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tMY//Q0+CuMw89ipKNDMR2u7yQP8AHTXnLPOcabgxgZPw794TEYsnL7Wn1/x88eXaofpprbIsxlgQiX/sL5zyFhcUFSPDToXin4gX3S3Vx82ozd9Kkudro4WawwYNKgW/L7jlsOjilPUSi1cMUle1klh4ijyoBvLf4WJok5atzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EBKIyHqT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EBKIyHqT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0FFF1F000FF; Tue, 13 Oct 2026 16:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791908454; bh=AoHxCGElMKv/rjaZ8writLnvQoIRADfWi+DpGpsMkb4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EBKIyHqTO0KblUqAXvjyh7Ir7cYWnTTzdyE9UTyti2wlKJt1Wocy1TmHaICNDEgMN cWiP4wWXV2+SE9MO6LomYM+6Hlz1/vSVtPwC7Sslh4YQlJBCb0zgrDQuVBx+2eSXfE fCO2lKzH2VVReo1jmzpn4gi+8rI6+TvvotJ09kujaWQv1hGpf+kMNulZHghijoQvH5 lsnSGtpiHenxgztqi2Oz4Phlo8bG8x2lpiK1/vTjj2hR+HyswoFA21VSuzTKNX19Q5 5xCSTSTnAbOMsqVVU55MHVc8FwZzsb8tEW+kIBHlJCE7U0YzIOSJsU6dEluUGXkZSy QEj7B0l796Uqw== From: Sasha Levin To: stable@vger.kernel.org Cc: Ahmed Abdelhaleem Ahmed , Laurence Oberman , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 6.6.y] scsi: ch: Do not keep references to data transfer element devices Date: Tue, 13 Oct 2026 12:20:52 -0400 Message-ID: <20261013162028.378392-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026101238-ladylike-chevy-a690@gregkh> References: <2026101238-ladylike-chevy-a690@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Ahmed Abdelhaleem Ahmed [ Upstream commit 27c0f718d3b3c99e6d315308e95d987d0382a8a8 ] ch_readconfig() looks up the scsi_device of every data transfer element whose SCSI id the changer reports in READ ELEMENT STATUS, and stores it in ch->dt[]. scsi_device_lookup() takes a reference, and nothing ever drops it: ch_destroy() frees the array with kfree(). ch->dt[] is read nowhere else - it only supplies the vendor, model and revision printed in the same loop. Once such a drive is removed, its scsi_device can never be released. It stays on the host's device list at its address, so a new device there is refused by anything that walks the list - target_core_pscsi reports "scsi_device_get() failed for H:C:T:L" - and the low-level driver's module can no longer be unloaded. Only a reboot recovers. It shows with any changer that reports its drives' ids; with the mhvtl virtual library (IBM 3573-TL personality), each create and remove of a library with four drives leaves four references behind, counted by the module's use count in lsmod. With ch not bound the count is unchanged, and with this patch applied it is unchanged too. Drop the reference as soon as the name has been printed, and remove the now unused dt[] array. That also removes the array leaked when ch_probe() fails after ch_readconfig(). The same leak was reported with an RFC patch in 2022, which was not merged. Fixes: daa6eda65a53 ("[SCSI] add scsi changer driver") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/linux-scsi/20220719075442.6215-1-yanghao_ht@163.com/ Signed-off-by: Ahmed Abdelhaleem Ahmed Reviewed-by: Laurence Oberman Fixes: daa6eda65a53 ("[SCSI] add scsi changer driver") Link: https://patch.msgid.link/20260929-ch-dt-leak-v2-1-ddda8d635dca@gmail.com Signed-off-by: Martin K. Petersen (Oracle) [ sashal: adapted kzalloc_objs() removal to the existing kcalloc() allocation ] Signed-off-by: Sasha Levin --- drivers/scsi/ch.c | 30 +++++++++--------------------- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/drivers/scsi/ch.c b/drivers/scsi/ch.c index cb0a399be1cce..b4c877bb41637 100644 --- a/drivers/scsi/ch.c +++ b/drivers/scsi/ch.c @@ -110,7 +110,6 @@ typedef struct { int minor; char name[8]; struct scsi_device *device; - struct scsi_device **dt; /* ptrs to data transfer elements */ u_int firsts[CH_TYPES]; u_int counts[CH_TYPES]; u_int unit_attention; @@ -358,16 +357,10 @@ ch_readconfig(scsi_changer *ch) vendor_labels[i]); } - /* look up the devices of the data transfer elements */ - ch->dt = kcalloc(ch->counts[CHET_DT], sizeof(*ch->dt), - GFP_KERNEL); - - if (!ch->dt) { - kfree(buffer); - return -ENOMEM; - } - + /* report the devices of the data transfer elements */ for (elem = 0; elem < ch->counts[CHET_DT]; elem++) { + struct scsi_device *sdev; + id = -1; lun = 0; if (elem < CH_DT_MAX && -1 != dt_id[elem]) { @@ -383,10 +376,8 @@ ch_readconfig(scsi_changer *ch) VPRINTK(KERN_INFO, "dt 0x%x: ",elem+ch->firsts[CHET_DT]); if (data[6] & 0x80) { VPRINTK(KERN_CONT, "not this SCSI bus\n"); - ch->dt[elem] = NULL; } else if (0 == (data[6] & 0x30)) { VPRINTK(KERN_CONT, "ID/LUN unknown\n"); - ch->dt[elem] = NULL; } else { id = ch->device->id; lun = 0; @@ -396,18 +387,16 @@ ch_readconfig(scsi_changer *ch) } if (-1 != id) { VPRINTK(KERN_CONT, "ID %i, LUN %i, ",id,lun); - ch->dt[elem] = - scsi_device_lookup(ch->device->host, - ch->device->channel, - id,lun); - if (!ch->dt[elem]) { + sdev = scsi_device_lookup(ch->device->host, + ch->device->channel, + id, lun); + if (!sdev) { /* should not happen */ VPRINTK(KERN_CONT, "Huh? device not found!\n"); } else { VPRINTK(KERN_CONT, "name: %8.8s %16.16s %4.4s\n", - ch->dt[elem]->vendor, - ch->dt[elem]->model, - ch->dt[elem]->rev); + sdev->vendor, sdev->model, sdev->rev); + scsi_device_put(sdev); } } } @@ -571,7 +560,6 @@ static void ch_destroy(struct kref *ref) scsi_changer *ch = container_of(ref, scsi_changer, ref); ch->device = NULL; - kfree(ch->dt); kfree(ch); } -- 2.53.0