Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E46BCCA46D for ; Fri, 16 Oct 2026 07:27:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E541E112629; Fri, 16 Oct 2026 07:27:18 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3725B112602 for ; Fri, 16 Oct 2026 07:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1792135633; x=1823671633; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eZwww6RixpMJKg7J7PCoslcbQd2wEKTr1aQVWb3P1Ys=; b=CiGOTFmAPN+WzQwB0picDgY92pOdx6+kynVTDMcQiXBn9OXOFrA8Rk01 pZi9+wO5g10tMtMx+y5JJaZInmzpm15womkes6tMdzpehZ8jhJ+HVccV1 ajNwq7pKKSUIC4C4q/f+hLv2MgyE/D7CMpDAoV7+fdTSOwYertvrAWH9O ypXCwDwN2ZJaKNvXk7sFFb/HS1jZ6srXbC1dm4+8T7jcOWWAQqGQ5t2uw 4fYCxX7Ujv8XiH4BW8RKb1cSG5eCeCn5Y3rlRaYkVnOWT5K4f24Tp/hwa i3MpXt9AK5LityeBS5N5QGTPgQmgLixZQrk58LLdKsZF/OBr3euhJzMcy w==; X-CSE-ConnectionGUID: Kb9Rf442Rz6PPb/s6rsT6w== X-CSE-MsgGUID: 2mbFNxcdR8KWKe+L/3nQEA== X-IronPort-AV: E=McAfee;i="6800,10657,11936"; a="806140" X-IronPort-AV: E=Sophos;i="6.27,161,1787036400"; d="scan'208";a="806140" Received: from fmviesa013.fm.intel.com ([10.60.135.153]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2026 00:27:13 -0700 X-CSE-ConnectionGUID: uvu97gFwQEqcEbyz7TW1Sw== X-CSE-MsgGUID: Q0UoiORZTl+knLXDpiebaQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,161,1787036400"; d="scan'208";a="3673943" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by fmviesa013.fm.intel.com with ESMTP; 16 Oct 2026 00:27:10 -0700 From: Raag Jadav To: intel-xe@lists.freedesktop.org Cc: riana.tauro@intel.com, michal.wajdeczko@intel.com, lukasz.laguna@intel.com, matthew.d.roper@intel.com, matthew.brost@intel.com, mallesh.koujalagi@intel.com, rodrigo.vivi@intel.com, Raag Jadav Subject: [PATCH v10 4/9] drm/xe: Move xe_device_wedged_fini() registration to xe_device_probe_early() Date: Fri, 16 Oct 2026 12:55:58 +0530 Message-ID: <20261016072623.457392-5-raag.jadav@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016072623.457392-1-raag.jadav@intel.com> References: <20261016072623.457392-1-raag.jadav@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The device can be declared wedged while processing boot-time hardware errors, which can result in PM reference leak if driver probe fails before xe_device_wedged_fini() is registered. Early register the required cleanup action and fix this. Fixes: a7df563b45b0 ("drm/xe/xe_hw_error: Handle CSC Firmware reported Hardware errors") Signed-off-by: Raag Jadav Reviewed-by: Rodrigo Vivi --- v2: Split fixes into separate patches (Rodrigo, Michal) --- drivers/gpu/drm/xe/xe_device.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c index cf0235e57827..b185c7d33185 100644 --- a/drivers/gpu/drm/xe/xe_device.c +++ b/drivers/gpu/drm/xe/xe_device.c @@ -697,6 +697,8 @@ static int xe_device_vram_alloc(struct xe_device *xe) return 0; } +static void xe_device_wedged_fini(struct drm_device *drm, void *arg); + /** * xe_device_probe_early: Device early probe * @xe: xe device instance @@ -765,6 +767,10 @@ int xe_device_probe_early(struct xe_device *xe) if (err) return err; + err = drmm_add_action_or_reset(&xe->drm, xe_device_wedged_fini, xe); + if (err) + return err; + return 0; } ALLOW_ERROR_INJECTION(xe_device_probe_early, ERRNO); /* See xe_pci_probe() */ @@ -1099,10 +1105,6 @@ int xe_device_probe(struct xe_device *xe) detect_preproduction_hw(xe); - err = drmm_add_action_or_reset(&xe->drm, xe_device_wedged_fini, xe); - if (err) - goto err_unregister_display; - /* * Process and log any errors detected by hardware. Possible results can * include declaring the device as wedged, which must be done only after -- 2.43.0