Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0F09606A339 for ; Fri, 30 Oct 2026 14:46:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=bcgs6Xxm Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8DC9F11286E; Fri, 30 Oct 2026 14:46:06 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D8F310E387 for ; Fri, 30 Oct 2026 14:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793371558; x=1824907558; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qn3jQyWFHuJJcl+FaIf3XIub8GTcHBu9dmA47RMdGwg=; b=bcgs6Xxmq3RfkPUpl8gYFj227I2cO2GagNcqqUkIka6Vq8yj/2Kvx42n ofSDmyW6QpL3hA9M1tHo7I0fQYQ1i1lWNHNjqcmFsLwLQy3lUrGUKlzzQ F9Wn9k72blpGfLnZL/zwJmgVAKJIXg/mxZp2MhOCxbsMHNPdW+1kpV+uh l4g1d1ZwMuJS3vE1DwXy/KdM0WS29c0tuV8KD6qSjDVHLDkOa4mD0H3gM Yyg4c56worALvpP78EC7QK8WP/T6vZjYb6CaVCX9f/0fbMw73asQFhsIp FW9+ddIsUnhqJoVqotcYyD4+4rkd2UUAGvI9RxgJMMpfUm+3R45J7zH3v g==; X-CSE-ConnectionGUID: ROQIPtuITDWtUSmCsBzEXw== X-CSE-MsgGUID: ShOFgpWpR/+hZNsPyXJ/zQ== X-IronPort-AV: E=McAfee;i="6800,10657,11951"; a="2012655" X-IronPort-AV: E=Sophos;i="6.27,186,1787036400"; d="scan'208";a="2012655" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2026 07:45:58 -0700 X-CSE-ConnectionGUID: hAi8KQJIStuRY17aBP+i7A== X-CSE-MsgGUID: ADrqXZx4RFarcMn5VmWdsA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,186,1787036400"; d="scan'208";a="5588600" Received: from bnilawar-desk2.iind.intel.com ([10.190.239.41]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2026 07:45:54 -0700 From: Badal Nilawar To: intel-xe@lists.freedesktop.org Cc: anshuman.gupta@intel.com, rodrigo.vivi@intel.com, daniele.ceraolospurio@intel.com, michael.j.ruhl@intel.com, alexander.usyskin@intel.com, anoop.c.vijay@intel.com, shamim.begum@intel.com, kelvin.gardiner@intel.com Subject: [PATCH v6 1/6] drm/xe/xe_late_bind_fw: Fix firmware leak on missing manifest entry Date: Fri, 30 Oct 2026 20:15:49 +0530 Message-ID: <20261030144547.2532309-9-badal.nilawar@intel.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261030144547.2532309-8-badal.nilawar@intel.com> References: <20261030144547.2532309-8-badal.nilawar@intel.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Intel-xe" X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Release firmware when the "LTES" manifest entry is not found in the firmware header. Fixes: efa29317a553 ("drm/xe/xe_late_bind_fw: Extract and print version info") Reviewed-by: Daniele Ceraolo Spurio Signed-off-by: Badal Nilawar --- drivers/gpu/drm/xe/xe_late_bind_fw.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c index 768442ca7da6..1bddfaf0fb9f 100644 --- a/drivers/gpu/drm/xe/xe_late_bind_fw.c +++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c @@ -335,19 +335,19 @@ static int __xe_late_bind_fw_init(struct xe_late_bind *late_bind, u32 fw_id) if (fw->size > XE_LB_MAX_PAYLOAD_SIZE) { drm_err(&xe->drm, "Firmware %s size %zu is larger than max pay load size %u\n", lb_fw->blob_path, fw->size, XE_LB_MAX_PAYLOAD_SIZE); - release_firmware(fw); - return -ENODATA; + ret = -ENODATA; + goto release_fw; } ret = parse_lb_layout(lb_fw, fw->data, fw->size, "LTES"); if (ret) - return ret; + goto release_fw; lb_fw->payload_size = fw->size; lb_fw->payload = drmm_kzalloc(&xe->drm, lb_fw->payload_size, GFP_KERNEL); if (!lb_fw->payload) { - release_firmware(fw); - return -ENOMEM; + ret = -ENOMEM; + goto release_fw; } drm_info(&xe->drm, "Using %s firmware from %s version %u.%u.%u.%u\n", @@ -356,10 +356,11 @@ static int __xe_late_bind_fw_init(struct xe_late_bind *late_bind, u32 fw_id) lb_fw->version.hotfix, lb_fw->version.build); memcpy((void *)lb_fw->payload, fw->data, lb_fw->payload_size); - release_firmware(fw); INIT_WORK(&lb_fw->work, xe_late_bind_work); - return 0; +release_fw: + release_firmware(fw); + return ret; } static int xe_late_bind_fw_init(struct xe_late_bind *late_bind) -- 2.56.0