Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.172 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794898293; b=uQlmcIUlTJ6TUCT9pJgCWlOoPwWoraAtIYgMixGVZ0jhRHQddBgH05tWTYiDlAsYMdRE g76LKUxmIgbq7nfiPe8S7jmwyjXS49JqkfyBFTAFPMxt2488At9qshvgInxvukYaxjs2C YzEk4P3aD8WkhzRD6Sj8XxlMzmMyBff6DQ34sOwVMkVTOgSABAm4hnOErTYloHc+Wmtu5 M3Vv3ie2ibwBDzVC16tHvOgEDI4ambdwcbf64RP0StqfXwAQdVS+7Z/8QTmJIWwW9p63a o7vagr5VrjQXuYO1+x1bFVaukxFnp/6ZCV1+pemqB92++dxIaLF6ZF8RA+dyKyHAPEw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794898293; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=RaW7IpysCPqlOXpmlCgnS8gUk7OicQRVwJcmgC0kHyY=; b=UehtTwJqLCTJ27rrg7pCXQmTvF2huhpnT3tCYEUBs95SefC6RXP0+yJf0EdGm28YMxSv by6WZXzuRITZ+9g3unXjT6pyqJjwNgDKohkWDWW9NqnwkY5YibMZQBUQ4vn7UyMvEbS3s tTmVeExgGdrftFXWjJoJ/AYuW5Bk7kFLQGgGphQViJzGvKqDv9E7ucz9vImlLBE6v6XUU p3d1uzQxK4x2GH3J/Id+OOaqou3rtR8aOTWXgz9u+AN9IDjPEEIXyxfLQWnzXvNkSgUyc 0i0DBy7095RQUm7Ps0pAhVCaf3WOaQmOV9CB+IsiftOlPMLWrPHDkaODZWh01Jk0AYw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=PmHq0J5C; arc=none smtp.remote-ip=74.125.82.172 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6153E606A330 for ; Tue, 17 Nov 2026 06:51:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6153E606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=PmHq0J5C Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-380c28f9e35so629209eec.1 for ; Mon, 16 Nov 2026 22:51:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794898292; x=1795503092; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RaW7IpysCPqlOXpmlCgnS8gUk7OicQRVwJcmgC0kHyY=; b=PmHq0J5CKu9qVwgY7FlIKVnJosfOdWuT32WTGqe+uOA9CDDwfFpGKaKKaqdoLgOqex eO3HVo4IuWgq7dR/Hx4k3qlIz9e5pbtZVMJAesJXLdXHwue/mZQjvzd38IFUBbPLkFic j5iamkra0jXYzKzTQpUx0MFEQzxC1+4ivJj+9XLF3sABosx2yXXTWUDeYQcG1vpVxYfg injNdVq2h6fkNFyDCF98QsGp6cA+eFKJiwGmqM2yX4VRXHL1bmOyCx1AWGbc4emuP23I zz8Zu52WM0QSl+9v6FKUjUysrOEUVoHCpCaj6oJeEEbi7L1ql63KEnr3dvHW0r1OfbrT ECXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794898292; x=1795503092; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=RaW7IpysCPqlOXpmlCgnS8gUk7OicQRVwJcmgC0kHyY=; b=A9r11YoTyNIAR2NiOxsokqEmpkEdeGCaoO8OscLmkcU3RuzmD8Kh0x1Iv6wPpa4ANM feC/wJv0CnGwrKiAIZPKnJeUbNmVVPM/p7d8kduz2lMFB1PgUotHmeYW1R9jiKVuI/qG dBdNiCzTc6TfZlesCvh8PMTmQaLwDKy0CJLb22ubxCZ9Uzxqk6XQWEMJEvXjamZpXZLW 8W0I7HSc0k8DgFNb6+Oxuz0XWhYIRyospbmd600C5Wa0HeNda0kOqGbj8AdmfRMwmr7g yla/Ar7kjuBTtI50QnUFK8tgU3c3pkPam9dzTlucfGmGdZKaQPMPUT6slREavSQnlwGp Z8mQ== X-Forwarded-Encrypted: i=1; AL+hErEDQsY1cj3Xy/3HAvAzSzNeMtt41i8pfwWWw4297muIwX+wV4utTwvgEPHpiQpfB0qljX9rKPGU1PReOQ==@vger.kernel.org X-Gm-Message-State: APuU4Z94yicCNyPu+DBZ6Xeaa5E5SO/Jixdm/6t9Kfnmuy98h26Tc7t5 4j0ng5P/lNnULEnPwdCgKfqGA/y/N3lSncTDYtrbZZa8eBjvRAnzZdHB X-Gm-Gg: AZFdTZcWaATxta1PGpIL2DuQ3Yr1prsKrvFFOapC1xzxTyYP37MeE2kpc8qsn94upPi x6feoodBlbGDPBKxFYfSI2Q1BXN8mgX/jnVRn1HIiyMkPcVd6zePk632OO+NZ5ohMW+AFz9jLNQ thQMfONj4AnTMZVMRXNQZDAE2XT8cPZ2oMsrkevRdz4QRNAkIQIMh0uulbL361X6HvGu8axLhZk s1jH/k9SJkBXnVuL9JSY4Ql10ou6w3Q7ChR7k4H8qyN/AZJZ7y/eh5px7o2WOXRNiqWpVHN4qwi fVoUhfy6Usznc9piqvh3HsTTCW2THJFKpKPrusw/8/gt2PgcvSrH+mbTeqnFt1EG+R2IwM0wbLX LHAUoy3Ie1qCPHtINAqSHSScDTwhT4O6omK3UFXvG2TeF2Do1wOq0d70dLNPiRcC3Coz1svogBO /wLNnj9YTWIVjlsFYeFFyRPwZTQ504l1RLmpcE2Ys9rmtNqbTYynw5dwA7DgeNxqYrv0jO9zTiB CDN2p35yg4HdgDI3lOBLZw2Nah8Qo2QcEMxVBjbdubAauo2roHCnVMpxfCDpgZm/BDKR3kBFCdG Xqtpv/6/9Ly+SLyGxDPf0uCdeiVqt+8CezWuooNvdslfzZP7hftfBePMSP8d5saXXam4y0ivdCi sL4wcnnFR X-Received: by 2002:a05:7300:7b1e:b0:36c:a3ae:936e with SMTP id 5a478bee46e88-3810e418910mr1836902eec.5.1794898292224; Mon, 16 Nov 2026 22:51:32 -0800 (PST) Received: from carrot.home.local (madb688455.ap.nuro.jp. [219.104.132.85]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-379565d269asm44099255eec.23.2026.11.16.22.51.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 22:51:30 -0800 (PST) From: Ryusuke Konishi To: Viacheslav Dubeyko Cc: Wang Jianjian , linux-nilfs , LKML Subject: [PATCH 2/2] nilfs2: introduce atime support Date: Tue, 17 Nov 2026 15:47:48 +0900 Message-ID: <20261117065122.41553-3-konishi.ryusuke@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117065122.41553-1-konishi.ryusuke@gmail.com> References: <20261117065122.41553-1-konishi.ryusuke@gmail.com> X-Mailing-List: linux-nilfs@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Viacheslav Dubeyko Currently, NILFS2 doesn't support atime. And it is possible to see the evidence of it by running generic/003 test-case of xfstests suite: sudo ./check generic/003 FSTYP -- nilfs2 PLATFORM -- Linux/x86_64 hfsplus-testing-0001 6.18.0-rc1+ #10 SMP PREEMPT_DYNAMIC Fri Nov 28 20:48:25 PST 2025 MKFS_OPTIONS -- /dev/loop51 MOUNT_OPTIONS -- /dev/loop51 /mnt/scratch generic/003 35s ... - output mismatch (see xfstests-dev/results//generic/003.out.bad) This patch replaces i_xattr with i_atime and i_pad with i_atime_nsec in struct nilfs_inode of the on-disk layout, and instead of unconditionally disabling filesystem-level atime support, makes it toggleable via the atime compat_ro feature flag. Also, it modifies nilfs_read_inode_common() and nilfs_write_inode_common() with the goal of proper atime support. sudo ./check generic/003 FSTYP -- nilfs2 PLATFORM -- Linux/x86_64 nilfs2-testing 6.19.0-rc1+ #8 SMP PREEMPT_DYNAMIC Tue Feb 17 16:21:59 PST 2026 MKFS_OPTIONS -- /dev/loop51 MOUNT_OPTIONS -- /dev/loop51 /mnt/scratch generic/003 30s ... 34s Ran: generic/003 Passed all 1 tests [1] https://github.com/nilfs-dev/nilfs2/issues/7 Signed-off-by: Viacheslav Dubeyko Co-developed-by: Wang Jianjian Signed-off-by: Wang Jianjian Signed-off-by: Ryusuke Konishi --- fs/nilfs2/Kconfig | 2 +- fs/nilfs2/inode.c | 11 +++++++++-- fs/nilfs2/nilfs.h | 4 ---- fs/nilfs2/segment.c | 2 -- fs/nilfs2/super.c | 8 +++----- include/uapi/linux/nilfs2_ondisk.h | 8 ++++---- 6 files changed, 17 insertions(+), 18 deletions(-) diff --git a/fs/nilfs2/Kconfig b/fs/nilfs2/Kconfig index 0a5ace60e6ab..79b99c33af06 100644 --- a/fs/nilfs2/Kconfig +++ b/fs/nilfs2/Kconfig @@ -20,7 +20,7 @@ config NILFS2_FS snapshot is mountable as a read-only file system concurrently with its writable mount, and this feature is convenient for online backup. - Some features including atime, extended attributes, and POSIX ACLs, + Some features including extended attributes, and POSIX ACLs, are not supported yet. To compile this file system support as a module, choose M here: the diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c index 6ddef3ab0c19..b217eee57c36 100644 --- a/fs/nilfs2/inode.c +++ b/fs/nilfs2/inode.c @@ -387,6 +387,7 @@ void nilfs_set_inode_flags(struct inode *inode) int nilfs_read_inode_common(struct inode *inode, struct nilfs_inode *raw_inode) { + struct the_nilfs *nilfs = inode->i_sb->s_fs_info; struct nilfs_inode_info *ii = NILFS_I(inode); int err; @@ -395,8 +396,12 @@ int nilfs_read_inode_common(struct inode *inode, i_gid_write(inode, le32_to_cpu(raw_inode->i_gid)); set_nlink(inode, le16_to_cpu(raw_inode->i_links_count)); inode->i_size = le64_to_cpu(raw_inode->i_size); - inode_set_atime(inode, le64_to_cpu(raw_inode->i_mtime), - le32_to_cpu(raw_inode->i_mtime_nsec)); + if (nilfs->ns_feature_compat_ro & NILFS_FEATURE_COMPAT_RO_ATIME) + inode_set_atime(inode, le64_to_cpu(raw_inode->i_atime), + le32_to_cpu(raw_inode->i_atime_nsec)); + else + inode_set_atime(inode, le64_to_cpu(raw_inode->i_mtime), + le32_to_cpu(raw_inode->i_mtime_nsec)); inode_set_ctime(inode, le64_to_cpu(raw_inode->i_ctime), le32_to_cpu(raw_inode->i_ctime_nsec)); inode_set_mtime(inode, le64_to_cpu(raw_inode->i_mtime), @@ -702,8 +707,10 @@ void nilfs_write_inode_common(struct inode *inode, raw_inode->i_gid = cpu_to_le32(i_gid_read(inode)); raw_inode->i_links_count = cpu_to_le16(inode->i_nlink); raw_inode->i_size = cpu_to_le64(inode->i_size); + raw_inode->i_atime = cpu_to_le64(inode_get_atime_sec(inode)); raw_inode->i_ctime = cpu_to_le64(inode_get_ctime_sec(inode)); raw_inode->i_mtime = cpu_to_le64(inode_get_mtime_sec(inode)); + raw_inode->i_atime_nsec = cpu_to_le32(inode_get_atime_nsec(inode)); raw_inode->i_ctime_nsec = cpu_to_le32(inode_get_ctime_nsec(inode)); raw_inode->i_mtime_nsec = cpu_to_le32(inode_get_mtime_nsec(inode)); raw_inode->i_blocks = cpu_to_le64(inode->i_blocks); diff --git a/fs/nilfs2/nilfs.h b/fs/nilfs2/nilfs.h index 40dd42133dc6..1cf9e38152a6 100644 --- a/fs/nilfs2/nilfs.h +++ b/fs/nilfs2/nilfs.h @@ -27,7 +27,6 @@ * @i_state: dynamic state flags * @i_bmap: pointer on i_bmap_data * @i_bmap_data: raw block mapping - * @i_xattr: * @i_dir_start_lookup: page index of last successful search * @i_cno: checkpoint number for GC inode * @i_assoc_inode: associated inode (B-tree node cache holder or back pointer) @@ -43,7 +42,6 @@ struct nilfs_inode_info { unsigned long i_state; /* Dynamic state flags */ struct nilfs_bmap *i_bmap; struct nilfs_bmap i_bmap_data; - __u64 i_xattr; /* sector_t ??? */ __u32 i_dir_start_lookup; __u64 i_cno; /* check point number for GC inode */ struct inode *i_assoc_inode; @@ -234,8 +232,6 @@ static inline int nilfs_init_acl(struct inode *inode, struct inode *dir) } #endif -#define NILFS_ATIME_DISABLE - /* Flags that should be inherited by new inodes from their parent. */ #define NILFS_FL_INHERITED \ (FS_SECRM_FL | FS_UNRM_FL | FS_COMPR_FL | FS_SYNC_FL | \ diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index af0c3560444f..68b640a7aa5b 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c @@ -930,8 +930,6 @@ static void nilfs_write_root_mdt_inode(struct inode *inode, nilfs_write_inode_common(inode, raw_inode); /* zero-fill unused portion of raw_inode */ - raw_inode->i_xattr = 0; - raw_inode->i_pad = 0; memset((void *)raw_inode + sizeof(*raw_inode), 0, nilfs->ns_inode_size - sizeof(*raw_inode)); diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index f92bcf1a9544..ddad1e4f55ce 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/super.c @@ -863,11 +863,6 @@ int nilfs_store_magic(struct super_block *sb, sb->s_magic = le16_to_cpu(sbp->s_magic); - /* FS independent flags */ -#ifdef NILFS_ATIME_DISABLE - sb->s_flags |= SB_NOATIME; -#endif - nilfs->ns_resuid = le16_to_cpu(sbp->s_def_resuid); nilfs->ns_resgid = le16_to_cpu(sbp->s_def_resgid); nilfs->ns_interval = le32_to_cpu(sbp->s_c_interval); @@ -876,6 +871,9 @@ int nilfs_store_magic(struct super_block *sb, nilfs->ns_feature_compat_ro = le64_to_cpu(sbp->s_feature_compat_ro); nilfs->ns_feature_incompat = le64_to_cpu(sbp->s_feature_incompat); + if (!(nilfs->ns_feature_compat_ro & NILFS_FEATURE_COMPAT_RO_ATIME)) + sb->s_flags |= SB_NOATIME; + return 0; } diff --git a/include/uapi/linux/nilfs2_ondisk.h b/include/uapi/linux/nilfs2_ondisk.h index 19587700c92c..e94593137adb 100644 --- a/include/uapi/linux/nilfs2_ondisk.h +++ b/include/uapi/linux/nilfs2_ondisk.h @@ -47,9 +47,9 @@ * @i_links_count: links count * @i_flags: file flags * @i_bmap: block mapping - * @i_xattr: extended attributes + * @i_atime: access time (seconds) * @i_generation: file generation (for NFS) - * @i_pad: padding + * @i_atime_nsec: access time (nano seconds) */ struct nilfs_inode { __le64 i_blocks; @@ -65,9 +65,9 @@ struct nilfs_inode { __le32 i_flags; __le64 i_bmap[NILFS_INODE_BMAP_SIZE]; #define i_device_code i_bmap[0] - __le64 i_xattr; + __le64 i_atime; __le32 i_generation; - __le32 i_pad; + __le32 i_atime_nsec; }; #define NILFS_MIN_INODE_SIZE 128 -- 2.53.0