Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795058119; b=G10V5gJiG3iyekrQ1SWslv+ie9VQhtbdPVGHgV1dqpj214P/UyAGrAyJ4a65MN67mVKt JIbbzKqcEsCNzNiyJOVBJXDopcAyI+KwgfQjMjWptqosiQQtFjCbcs9S2HPqGp1XXDMBc qS+Bsk45widMc+/raOxFX2IGTDvdwyCz2kFXOnbPOh2GKAxUiKX0FA8sCrl1mMIdMDHQs +i1FAlYUtbZQRFxNI5qZ6dfZHPEFd+e9MAlkJnAvEH0D49bCbRmvPTDgjBbRc5SHN2LE5 SwrjyJD/zMAphNl8NVj7Zxeavd0Jf0ROfseUZ7PqgNBsRzkMgS09EZCOfBCzIrqhP/A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795058119; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=c1es2o3ujkYE/9bCHhJvmOOxalWuw17o2P0R1kGfRvA=; b=JkOG/IRQTkYS1s/NhLh4PhfP9qzQhV1vCph0JXIuDiXQMbBDCHE2uNRInu2F3+61EgYi JBW8qoCwdVfw2CP8R/klUcHVHIRsIiJWRnflT3RPPKvFCc66btDF/lBF8J85rDH/Odyy5 Jl8ELsX9DhP3Lz2BJo/xIVAzwnGbH+XEsH2rNTrqT5ZDUr1/D4AutrxzvsO/JcZRTVybb 5j7YvMFEVt4XCUrsDtDXio1nLSKXUglOSsjbErzdAKrCuUvvhKP/H7RRJOrmtB/xPFUnm dbsdPPQeoyNKECxnTd7C1usJn+WCHfWqQ7kBFqgcDkJWjYaIB6fjquPJpV8LW0r3GLA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=q9xe+qoS; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D79B606A325; Thu, 19 Nov 2026 03:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=q9xe+qoS Received: by smtp.kernel.org (Postfix) with ESMTPSA id B43201F000C5; Thu, 19 Nov 2026 03:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795058119; bh=c1es2o3ujkYE/9bCHhJvmOOxalWuw17o2P0R1kGfRvA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=q9xe+qoSERbbpi0f1hByvBLcKiwRViRE82Mk/fPrtTfcp9+UdTjgqQEwa0a2DUIYv xlsWo0J+MSG4JRdmT1Amx/DctrkE34P80/QVjlEdlVdBRn2AiNkXSI7Y3AcyFsb5v/ pFsuz1yv7AbpfMJOHAZ/zvC4vapgvozrYZtcQhc4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+32f018fd65e799f79ae0@syzkaller.appspotmail.com, Piyush Patle , Hans Verkuil , Sasha Levin Subject: [PATCH 5.10 0372/1848] media: vidtv: fix frontend reference leak on unbind Date: Wed, 18 Nov 2026 15:40:10 +0100 Message-ID: <20261118145928.986186754@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Piyush Patle [ Upstream commit 6f412f9fe6a1f3ce9694757f50353bbec221d832 ] dvb_register_frontend() keeps two references to the frontend. One is released by dvb_unregister_frontend(), and the other by dvb_frontend_detach(). vidtv only called dvb_unregister_frontend(), so the second reference was never released. As a result, __dvb_frontend_free() was never called, leaking the frontend private data and its struct dvb_device. The detach call was removed by commit 63101b756893 ("media: vidtv: fix driver unbind/remove") because it caused an OOPS. The demod .release callback freed vidtv_demod_state, and the I2C remove callbacks then accessed the freed state. That commit also removed those accesses from the I2C remove callbacks. Restore the detach call, but remove the demod .release callback. vidtv_demod_state is owned by the I2C client and is already freed by vidtv_demod_i2c_remove(), so the frontend detach path should not free it. Tested with kmemleak and KASAN over 10 bind/unbind cycles. The reported frontend and dvb_device leaks were present before the fix and were gone after it, with no KASAN reports. Reported-by: syzbot+32f018fd65e799f79ae0@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=32f018fd65e799f79ae0 Fixes: 63101b756893 ("media: vidtv: fix driver unbind/remove") Cc: stable@vger.kernel.org Tested-by: syzbot+32f018fd65e799f79ae0@syzkaller.appspotmail.com Signed-off-by: Piyush Patle Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/test-drivers/vidtv/vidtv_bridge.c | 2 ++ drivers/media/test-drivers/vidtv/vidtv_demod.c | 9 --------- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/media/test-drivers/vidtv/vidtv_bridge.c b/drivers/media/test-drivers/vidtv/vidtv_bridge.c index 5e0daac89fe1b..e216526db35a7 100644 --- a/drivers/media/test-drivers/vidtv/vidtv_bridge.c +++ b/drivers/media/test-drivers/vidtv/vidtv_bridge.c @@ -471,6 +471,7 @@ static int vidtv_bridge_dvb_init(struct vidtv_dvb *dvb) fail_demod_probe: for (i = i - 1; i >= 0; --i) { dvb_unregister_frontend(dvb->fe[i]); + dvb_frontend_detach(dvb->fe[i]); fail_fe: dvb_module_release(dvb->i2c_client_tuner[i]); fail_tuner_probe: @@ -522,6 +523,7 @@ static int vidtv_bridge_remove(struct platform_device *pdev) for (i = 0; i < NUM_FE; ++i) { dvb_unregister_frontend(dvb->fe[i]); + dvb_frontend_detach(dvb->fe[i]); dvb_module_release(dvb->i2c_client_tuner[i]); dvb_module_release(dvb->i2c_client_demod[i]); } diff --git a/drivers/media/test-drivers/vidtv/vidtv_demod.c b/drivers/media/test-drivers/vidtv/vidtv_demod.c index b7823d97b30d5..4edad5d9e1709 100644 --- a/drivers/media/test-drivers/vidtv/vidtv_demod.c +++ b/drivers/media/test-drivers/vidtv/vidtv_demod.c @@ -343,13 +343,6 @@ static int vidtv_diseqc_send_burst(struct dvb_frontend *fe, return 0; } -static void vidtv_demod_release(struct dvb_frontend *fe) -{ - struct vidtv_demod_state *state = fe->demodulator_priv; - - kfree(state); -} - static const struct dvb_frontend_ops vidtv_demod_ops = { .delsys = { SYS_DVBT, @@ -390,8 +383,6 @@ static const struct dvb_frontend_ops vidtv_demod_ops = { FE_CAN_HIERARCHY_AUTO, }, - .release = vidtv_demod_release, - .set_frontend = vidtv_demod_set_frontend, .get_frontend = vidtv_demod_get_frontend, -- 2.53.0