Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795058384; b=nsm66apAcHn7tJOEHkli/JJZGkX9FPKNJGT6lohr6/EAIlVZW/v7FvIIVgQaxLDXpp5c zxcULeFUgPEEbORr95pMYJ0dbn16tRnapMpUarB/sdnuBHIa5kM9+V3AMUbo2PJ0ekq0P 919EEfLtI/V846Me0DocbMrgDmOTiaaRLaYkpUSzpgKMLto04R1z//eQTkUPA2C1MOmeF ojS09bR3fiOwFyjEbDtDU0WDdl4gjDa8MVWJ++Yg0pXYXcl7QxHH9piVCtOogPoMjgPm2 foQGSWV6mHUVtrPoetQPYK3CxvgDuQNPoMUSAAeIy1RpJZA8f2SpxGc8TaMO/y2nTkA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795058384; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=M7FtkpWOws3dBzXBxq3ImyksT5rrtCulz3CFMMlniDk=; b=tryljjZwcWxVjw830cfKTf2ORvFbnVbZJKKvUWvQrhEzr7dIBsdL7oOQkbyy7mVNVW9Z hMefCaqDIR6X+j6c2oNWBZS1OU49LjWkQMQGQ/PK9WmeeC/vYxg5XqOPvzewaN01b4P+C qBt62UPXq1OS2zPny4G5vxergwM0qedMz35tgvf5FQWZs/e4u/NVuRf8Bi1XgGsDcDb5t y0G/DKrKSFECjN6DWZQDNdqnSGDrLhwUEkNO5/YejwBmk3eS/FbNAvb1V1JkdcIjsrryc gAE7DvkFg+Esb6vop4F04SkKt9fLg/ZdX0sP/Yi+BVS+aNpXDBGcXopmrmKMZC+e/Gw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=w6iNZams; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C4F3606A320; Thu, 19 Nov 2026 03:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=w6iNZams Received: by smtp.kernel.org (Postfix) with ESMTPSA id 013AF1F000C4; Thu, 19 Nov 2026 03:19:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795058384; bh=M7FtkpWOws3dBzXBxq3ImyksT5rrtCulz3CFMMlniDk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=w6iNZamsYjICjGaYE4MgG9LZwnult4nEtVQrNiKvg6kw5wwF1EMzNYHvXBEh9sUEN oT3oaS4MR9mcwlUUcQbAFEu9qt1qLWdiznSoF6xLkHNYdLrlnZB/Zf3QWNMNtv0vll GsF6nuDcMC5IQfRmBwGTIw+FIagIkxd92WxADEaE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guangshuo Li , Nicolas Dufresne , Hans Verkuil , Sasha Levin Subject: [PATCH 5.10 0466/1848] media: mediatek: vpu: release reserved memory on remove Date: Wed, 18 Nov 2026 15:41:44 +0100 Message-ID: <20261118145933.883501811@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guangshuo Li [ Upstream commit 8af0e2bdd9791848d9caf3761825ac51a67c2b9c ] mtk_vpu_probe() may assign a reserved memory region to the VPU device with of_reserved_mem_device_init(). The probe failure path releases the assignment with of_reserved_mem_device_release(), but the normal remove path does not perform the corresponding cleanup. As a result, removing the VPU driver after a successful probe can leave the reserved memory assignment associated with the device after its lifetime has ended. Release the reserved memory assignment after freeing the VPU external firmware memory, matching the cleanup performed by the probe failure path. This issue was found by manual code inspection. Fixes: 3003a180ef6b ("[media] VPU: mediatek: support Mediatek VPU") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Nicolas Dufresne Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/platform/mtk-vpu/mtk_vpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c b/drivers/media/platform/mtk-vpu/mtk_vpu.c index a2f61d97ffeb1..663694dff3ddb 100644 --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c @@ -944,6 +944,7 @@ static int mtk_vpu_remove(struct platform_device *pdev) } vpu_free_ext_mem(vpu, P_FW); vpu_free_ext_mem(vpu, D_FW); + of_reserved_mem_device_release(&pdev->dev); mutex_destroy(&vpu->vpu_mutex); clk_unprepare(vpu->clk); -- 2.53.0