Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795058627; b=5sNxyT+Zt41T0eG1TVExQS73p8viBm6D0+975yFuxoNfCMe4D0s5NddvtiCNZNuKbHn9 nZMEDGpumtdjBUyipwW5hiB5UNABsFUA4nudjwv5/zzDejeRsz8RGiFyjJ9/WYoLLnG3P OO1tAIMnHSgINdlnuj8XDb6QiXXqqR4+ZRsybvDNvf3sz2WZhWEZ4IibhKpPke8RSQDPm AxyaQHETbvYqx9qA5fI49w3LiJxh38JYBPKj1GWCmdu794vFpdxWZhzln/rLZ67pW3Fb7 fCbj6FOY7rsGksZu2PRH2y8ly9cynjx1NZSJpTnyqdX/k703wk7zKrjyAwczWpAftww== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795058627; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=Ebsp9HyEhVxsrR2JkhmVy31IVYBHUho+OfMsdWez6eo=; b=oqDfEvG9FyllJJ/HuwfZFmLE+RtPAKs2wZoDz7GqGN9I7436kD23VC9XGlXrPI7UqEdc wgoKb4giQPt0/UGx1C9cGDzPiRMDVoqbptac1Cq2nP5/AivW6TFITtOJ0Jyyi4nkwlYz0 ePtOyEUvxKK/77AQ2JxUpBnMwkw844tYzRo3sbqfR8f6UBXdCMEiIy7JkbyeHP1FBzdbd lz8q4ksUahunMu0JGOqxZGkwOchI0q6FdYRDaUWnXeondSIY9dC7rf77/vvRYbqzKU3Hl LOWnxZlYEG9guC89yAOkAmuwhEyU19pwOg8mvDHz1D9mPWBjAA6CaIXRUfZF3/Z8jeg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=oM8k1aLC; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 465D0606A31C; Thu, 19 Nov 2026 03:23:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=oM8k1aLC Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53FFC1F000C4; Thu, 19 Nov 2026 03:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795058626; bh=Ebsp9HyEhVxsrR2JkhmVy31IVYBHUho+OfMsdWez6eo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=oM8k1aLCLFj/iuH96SB+/yXkxJaWTv49fJuJUMjXMhVDlcr4VH+KOt2pHQIWWnf/Y wr0y1DbnldVZWWcI4e0Ja4LDyMKTShqAmydqTUb9kQqlIA3/P+w/BC8j5/VHopzjL3 nKhRwItWzXwWBJ7POXL27qYUzN9Gj1goBXIgdfE0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+c3741bb338b5c6d6a4aa@syzkaller.appspotmail.com, Nguyen Ngoc Thang , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 0553/1848] net/rds: ib: dont enable IRQs in rds_ib_conn_free() Date: Wed, 18 Nov 2026 15:43:11 +0100 Message-ID: <20261118145938.078474254@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nguyen Ngoc Thang [ Upstream commit f6fa1d60ec3ceb7e6c26aa91eadfef34f94014e1 ] __rds_conn_create() calls trans->conn_free() with rds_conn_lock held and IRQs disabled when it loses the race to insert a connection. rds_ib_conn_free() takes the device list lock with spin_lock_irq() and releases it with spin_unlock_irq(), so IRQs are turned on while rds_conn_lock is still held: raw_local_irq_restore() called with IRQs enabled WARNING: kernel/locking/irqflag-debug.c:10 at warn_bogus_irq_restore+0xc/0x20 _raw_spin_unlock_irqrestore+0x67/0x80 __rds_conn_create+0x1de5/0x2290 rds_conn_create_outgoing+0x43/0x60 rds_sendmsg+0xfca/0x20e0 __sys_sendto+0x408/0x5a0 It needs an RDS socket bound to an address on an RDMA device (e.g. rxe) and two concurrent sendto() calls to the same new destination. The TCP and loopback ->conn_free() callbacks already use irqsave, so do the same here. Fixes: 745cbccac3fe ("RDS: Rewrite connection cleanup, fixing oops on rmmod") Reported-by: syzbot+c3741bb338b5c6d6a4aa@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=c3741bb338b5c6d6a4aa Cc: stable@vger.kernel.org Signed-off-by: Nguyen Ngoc Thang Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/rds/ib_cm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c index 5cdfd4310bce5..b225f73725442 100644 --- a/net/rds/ib_cm.c +++ b/net/rds/ib_cm.c @@ -1304,6 +1304,7 @@ void rds_ib_conn_free(void *arg) { struct rds_ib_connection *ic = arg; spinlock_t *lock_ptr; + unsigned long flags; rdsdebug("ic %p\n", ic); @@ -1314,9 +1315,10 @@ void rds_ib_conn_free(void *arg) */ lock_ptr = ic->rds_ibdev ? &ic->rds_ibdev->spinlock : &ib_nodev_conns_lock; - spin_lock_irq(lock_ptr); + /* May be called with IRQs already disabled (see __rds_conn_create()) */ + spin_lock_irqsave(lock_ptr, flags); list_del(&ic->ib_node); - spin_unlock_irq(lock_ptr); + spin_unlock_irqrestore(lock_ptr, flags); rds_ib_recv_free_caches(ic); -- 2.53.0