Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795058703; b=JX616M8Cdzw+vQbdmD+j0toMPrQinTfB6iXuEXE+UgaOoqjuIwPXSBgaLBk+GyXZyaXf C6NsJ5lh5LzR4S8MssmloFFtrL2i0QsPNAOGV/RF7Enoa3DjhVmwIuO32BR7yzrUcsCew dh4HuX+gAXae4tPooe4sxxrO5AFpz4vfs1vApXxSK+kKfFT6WFEq5WHIaG8FdnLdZ32WB K3QA2qLPX3w1SQPKMcIUE/t0Whp9AmohWSmspbt/2YwhALJqTRTCFbLZiQ29J0ZGc52XB 7uwYAPywsfi6OIVdq3am/3pg0bJDqGTt1HRju3rrLXuoUc6xQQh2BahmGmWA8vHJ3og== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795058703; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=2HJIJzTsmV1trK8YjVuANIPwcjm6+EkoJ78EQPrYEoE=; b=ug2V5AmWHCS/E9m/f2NQmDOag5cvM/qJoFD32gfefwvjPB4Ncab3azuSVfYju0xvV1hI P6QouN+RGXtyN+xnQ96vaHdrSwBf9S+hI0t52IfeC5m2S8HXONmfwzy0svXxL5Dgc1Dnf 2hXGxB3y3afVYGQ3IctD7NF7CqXYD8fpbb9JhPl46BdQqAzbDk2y+BhzaH3u+hvAwt03J EFDAiv6r7IXFQMY3O1jM/GaFXi9hFzeLVAl6G8kQSxQtspAEVYLtQbbM6eWDW+vN/ioTh ElqKnfZGSqS+DAkiMKInY4YA7n6nISrVh++Xxv5ZtkkCpLGEhFfrEb15EEzwO/jn8wg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=i8wKFRN0; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49E21606A31C; Thu, 19 Nov 2026 03:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=i8wKFRN0 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D3E21F000C4; Thu, 19 Nov 2026 03:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795058703; bh=2HJIJzTsmV1trK8YjVuANIPwcjm6+EkoJ78EQPrYEoE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=i8wKFRN0L79+wXIAUwxqI7CoZOy6dJg9hje/sKWyRpesVREa+TnZeGvwA7ZK6d5FW tv1/O0vJS4XheP8NHLhvIPj1uDftka7LXbPBy3h54an+i7j3UATU1S3W/4oryYQEbJ T79dUlaDlg3ZbpTGblyWAtN5N3inX04BuUTw7QKE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wang Haoran , Li Ximo , Helge Deller , Sasha Levin Subject: [PATCH 5.10 0573/1848] fbdev: atmel_lcdfb: fix list_first_entry() on possibly empty modelist in probe Date: Wed, 18 Nov 2026 15:43:31 +0100 Message-ID: <20261118145939.079297655@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wang Haoran [ Upstream commit 01d1204582f16e8b7bfce29648e5cf77a585d962 ] list_first_entry() does not return NULL on an empty list; it returns a bogus pointer computed by container_of() from the list head. atmel_lcdfb_probe() initializes info->modelist with INIT_LIST_HEAD() and later takes its first entry with list_first_entry(), assuming atmel_lcdfb_of_init() populated it. However, atmel_lcdfb_of_init() drops the return value of fb_add_videomode() — unlike every other fallible call in the same function — so if fb_add_videomode() fails (its internal kmalloc can return -ENOMEM under memory pressure or fault injection), the list stays empty while of_init() reports success. The probe path then dereferences the bogus pointer in fb_videomode_to_var(&info->var, &modelist->mode). Because the bogus pointer lands inside the contiguous fb_info allocation, this may not fault immediately; instead it silently reads adjacent memory as a struct fb_videomode and programs garbage timing parameters into the LCD controller. This was found by code audit; we do not have Atmel hardware to reproduce it. Fix this on two levels: check the return value of fb_add_videomode() in atmel_lcdfb_of_init() so the failure is propagated (root cause), and use list_first_entry_or_null() in atmel_lcdfb_probe() with a NULL check that fails probe gracefully with -EINVAL (defense in depth), consistent with the surrounding error handling which bails out to stop_clk. Reported-by: Wang Haoran Reported-by: Li Ximo Cc: stable@vger.kernel.org Signed-off-by: Wang Haoran Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/atmel_lcdfb.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c index f2b63f13e2444..707a0a0cd74e7 100644 --- a/drivers/video/fbdev/atmel_lcdfb.c +++ b/drivers/video/fbdev/atmel_lcdfb.c @@ -1032,7 +1032,9 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo) if (ret < 0) goto put_display_node; - fb_add_videomode(&fb_vm, &info->modelist); + ret = fb_add_videomode(&fb_vm, &info->modelist); + if (ret < 0) + goto put_display_node; put_display_node: of_node_put(display_np); @@ -1100,8 +1102,13 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev) } atmel_lcdfb_start_clock(sinfo); - modelist = list_first_entry(&info->modelist, - struct fb_modelist, list); + modelist = list_first_entry_or_null(&info->modelist, + struct fb_modelist, list); + if (!modelist) { + dev_err(dev, "no video mode available\n"); + ret = -EINVAL; + goto stop_clk; + } fb_videomode_to_var(&info->var, &modelist->mode); atmel_lcdfb_check_var(&info->var, info); -- 2.53.0