Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795059126; b=LSZxwmDgd11I/ewQDRdv92caIXJxI0m0QQC8f/Gw0IuQ+e6ExnizNg66vxAXEx8r0moQ aolYe80oRN23i9Jfjo8HISi65jUgQQGsXy0Y1lnuQP3CgaN6CRNSA8DJTmmGkbKM/I3rK r6Y+WXMhgB0g50PBPf3Ot0tarROY1jkOVjIBGMO2r7V3u8nkueuiPmh1T7iHDeeQ3hXU4 XUjis2pjMtrEuIKme2Bv6lgumhuWGJNwUqOmlDVOpXFYmafIfgT0+MOUOJak2GGYut1mW lCtKj/DjIuU4nGLe9s5OmSD3TGdw4cqarF0PKhWoHGK9MTL/mbk0/7mLibHTtw93fIA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795059126; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=RCXCp9Et3LlDtW8arrNnnD26pJYVnGEALXAf5fZH4RY=; b=ZGUvQVNVjbvQPXg+qXw400xGFPr7bW5Oz+WZ+ad95IeG1jzaIjo8Eyd4xYwxRc8KN99m hICSiAT3VFEKeQoGSUX7SQ5qeSfmvVoDb5+Nx4lceC6rIKInRSPouMiwYQ+rjVvxQll7o dw4CxiY5VZSPkym7+hLgyS6BfnMrysXxcZUCUIuJMFRev96D+oB80O4mWGug6xfOk2oPX xQ7+01r/nrIM/3EjFca1yJxNilQHZfznxuRQUCbQNjjEmvedhmUSCGfpu2FxmuevFfhUC 4YPvsar63aoIPRWLH51OKv+dwWun85+BgJE/y6lh9HXV0adJnIMKOH2/aHJd/Jac2Bg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=m5ar4yOU; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69E20606A330; Thu, 19 Nov 2026 03:32:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=m5ar4yOU Received: by smtp.kernel.org (Postfix) with ESMTPSA id C01DC1F000C4; Thu, 19 Nov 2026 03:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795059126; bh=RCXCp9Et3LlDtW8arrNnnD26pJYVnGEALXAf5fZH4RY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=m5ar4yOUT6L0kS/0OlSdyY2+yz5nKFhtM0Gb832PmetCAYK9vc4c+fnzrgn9vFuPr 9h0BqMZtgBAtEkwiDVoF/Zmldu0HgkXxxtMHqUkGpqQBWSZ5xRjs76UIaEgFOTBdQo SyTyEpK5D2FHW3KaoPv65yC3A9vjCQj7vgWTMmXk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chris Mason , "Gregory Price (Meta)" , "Lorenzo Stoakes (ARM)" , Muhammad Usama Anjum , "David Hildenbrand (Arm)" , Sasha Levin Subject: [PATCH 5.10 0731/1848] mm/mmu_notifier: set ->mm only after mmgrab() Date: Wed, 18 Nov 2026 15:46:09 +0100 Message-ID: <20261118145946.746464506@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chris Mason [ Upstream commit 5ad9e4b0f1104f5dbfb41125c34bb30ea6dc7a94 ] Radeon uses a non-NULL notifier->mm to decide whether to call mmu_interval_notifier_remove() when freeing a buffer object. __mmu_interval_notifier_insert() sets ->mm before validating the range, so a wrapping userptr range can leave ->mm set after insertion fails. Cleanup then tries to remove an unregistered notifier for which no mm reference was acquired. Set ->mm only after mmgrab(), once insertion can no longer fail. While we could fix radeon's code instead, setting ->mm on success only makes the code more robust. Fix generated by an LLM and sent by Chris Mason in private. Fixes: 3506ff69c3ec ("drm/radeon: use mmu_interval_notifier_insert") Cc: stable@vger.kernel.org Signed-off-by: Chris Mason [ david: simplify description ] Reviewed-by: Gregory Price (Meta) Tested-by: Gregory Price (Meta) Reviewed-by: Lorenzo Stoakes (ARM) Tested-by: Muhammad Usama Anjum Link: https://patch.msgid.link/20261031-fixes_core-v3-29-d6437171ecc3@kernel.org Signed-off-by: David Hildenbrand (Arm) Signed-off-by: Sasha Levin --- mm/mmu_notifier.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c index 9165ca619c8cf..b66b9ae21538f 100644 --- a/mm/mmu_notifier.c +++ b/mm/mmu_notifier.c @@ -922,7 +922,6 @@ static int __mmu_interval_notifier_insert( struct mmu_notifier_subscriptions *subscriptions, unsigned long start, unsigned long length, const struct mmu_interval_notifier_ops *ops) { - interval_sub->mm = mm; interval_sub->ops = ops; RB_CLEAR_NODE(&interval_sub->interval_tree.rb); interval_sub->interval_tree.start = start; @@ -939,8 +938,12 @@ static int __mmu_interval_notifier_insert( if (WARN_ON(atomic_read(&mm->mm_users) <= 0)) return -EINVAL; - /* pairs with mmdrop in mmu_interval_notifier_remove() */ + /* + * Pairs with mmdrop in mmu_interval_notifier_remove(). Drivers take a + * non-NULL ->mm for "registered", so set it only with the reference. + */ mmgrab(mm); + interval_sub->mm = mm; /* * If some invalidate_range_start/end region is going on in parallel -- 2.53.0