Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795059306; b=miEDBE8pkiYoamNkSwslgsunwwSKBWeWFC8r6pM9iOf4wG7vn6gYJOhHCSmiLzQq6VPv QLam28x/KRwKGscrSpOcSydHNBsN7vjzdTkvBxO5YfJ2cH01Bnv2E9vm6DBtms/GYF2XM 21emuC/AC9eMNS66kw8VORsodts8iBlGUbIq8zj/3cDydcW6+1++LCFc486Zx90kN7fju n7AmmBGoQ1OpLqJYh7KwEfDVqd/wNxC0TGLM0MRVpa19lWy2y+J+gITggHb88SoCERIp6 JarY4PbaK7WvdyGy/mKmivQNWS/YloTZSu2dGGcpSCYsXE336w60nyRXG6yNxT5PXAg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795059306; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=LOM22M3kHel+tGm9XP+YNLEGo+zlTauJ6T2SC9RE+PA=; b=xN6zFbup/XhPbefDjnYTIgqFNMKJHA58WMdSyhael7kBlDXbfRM3yCFv4YzE+cHYA92m m5Q1yOXoFypGShQk+cOiWuFlPxAgx44bbsPjEfT6yi4BYrx9YJkUkTG3sqq6Vww2MIhyO ZlQvC+21hSr2Mhrbc8Te3TTS1FhrKzVddDi0mTPerDkQ0EwSKOqwVIFLlIoRHYLYDqQ/I Xigcz2ynYdC5gI8+m5Z+LKQKsh9Lu/Uc2THKt18GkL4XfOTe1mXnQ2FP3OLFO5i8qZBwf qZz2seRuQTpJ8GKkXDFMyA7ZiXqEGWyfYKCR+5dMZcLiteACS5JvyCL/9X7enwqdkmQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=PQvFR0di; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22CDF606A336; Thu, 19 Nov 2026 03:35:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=PQvFR0di Received: by smtp.kernel.org (Postfix) with ESMTPSA id 742AF1F000C5; Thu, 19 Nov 2026 03:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795059306; bh=LOM22M3kHel+tGm9XP+YNLEGo+zlTauJ6T2SC9RE+PA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=PQvFR0diUozAlzto0jGgMOTbcJwJYVaUngHZhSIVMK4Cmc1nXtn88sT1t2Ehet1VX PuhTbqZKwWsdZxasQ98xRIkZntKz/HWSs+hFNaoONmeMx9DcB0VckRwxNkPdbpvc6i C4iupokXq4LMF76beVowsuJSh33NzxAo/GVodFhQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Daehyeon Ko <4ncienth@gmail.com>, Herbert Xu , Sasha Levin Subject: [PATCH 5.10 0792/1848] crypto: algif_skcipher - rewind rounded output bytes Date: Wed, 18 Nov 2026 15:47:10 +0100 Message-ID: <20261118145949.582376314@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Daehyeon Ko <4ncienth@gmail.com> [ Upstream commit 2f90facc7b94934653eb7ebfadcc25d503b89196 ] af_alg_get_rsgl() advances the receive iterator by the unrounded RX scatterlist length. For a continuing skcipher request, _skcipher_recvmsg() then rounds its local length down to a whole chunksize without restoring the iterator. A later chunk starts after bytes which the provider never wrote, while the syscall returns only the processed length. When copy_splice_read() supplies non-zeroed pages and publishes that return as a dense prefix, the gap exposes stale bytes from a previous page lifetime. With unprivileged xts(aes), a 31-byte MSG_MORE request followed by one final byte advances a 47-byte destination while returning 32 bytes. A hardened v7.2-rc5 image retained all 15 seeded stale bytes in 4,829 of 4,829 records. With init_on_alloc enabled, all 72,345 gap bytes observed were zero. Rewind the iterator by the tail excluded during rounding, before rejecting a zero processed length. The crypto request uses only the rounded length; af_alg_free_resources() releases the entire RX list before another receive iteration. The fixed target-like kernel returned byte-identical dense 48-byte output in 4,771 of 4,771 rounds. The unmodified kernel returned the vulnerable 32-byte short record in 2,409 of 2,409 rounds. Fixes: e870456d8e7c ("crypto: algif_skcipher - overhaul memory management") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Daehyeon Ko <4ncienth@gmail.com> Signed-off-by: Herbert Xu [ sashal: added the zero-length guard where no short-input check previously existed ] Signed-off-by: Sasha Levin --- crypto/algif_skcipher.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/crypto/algif_skcipher.c b/crypto/algif_skcipher.c index 6a1a71284fe82..c037c3969e9d6 100644 --- a/crypto/algif_skcipher.c +++ b/crypto/algif_skcipher.c @@ -82,8 +82,17 @@ static int _skcipher_recvmsg(struct socket *sock, struct msghdr *msg, * If more buffers are to be expected to be processed, process only * full block size buffers. */ - if (ctx->more || len < ctx->used) - len -= len % bs; + if (ctx->more || len < ctx->used) { + size_t excess = len % bs; + + len -= excess; + iov_iter_revert(&msg->msg_iter, excess); + + if (!len) { + err = -EINVAL; + goto free; + } + } /* * Create a per request TX SGL for this request which tracks the -- 2.53.0