Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795059622; b=uYApK7bwAimhXhZlwiaWTvUQ1tY4mSaNpO6zcuNS/kNSDvQoDYkZn8kbcZjN3NgTkacx vKY1v2Yij9UcyruyqooCIWv3yGy2chSndUVkwCmuGT2sJ9aOI65VQm9c+tMgEihr8lnN3 rBFVOMEgpZY+QUO82ucclYJYgWK9nQmT0iiPe69MZaoIV/N9/AgJP1WHvZymijNXbi+6d ODmCns9TJxbwuMo0ZwIH+7YJomqx+1bqlgtewU6pgw3Ec4KACEdxqT271LHCfqWnsoJIO hq+y7y34ByQvYJ1jeyd+K+UX3vvBtMwDKnBktU2qoBUj17pdz1z61wks3ldL0dXkkXA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795059622; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=UrO0Tzy1zu1HTiK3E5Kc0elpvhRIUX0KW8qp10lkEMA=; b=IPUwZYwvcRosS+iq+0BG3m13rM7ixpOX/GpnRySGv+C5DAkb8DhKgBUTHbZtEoPxrg+5 9SqMiSfNkrFBux17ZbJ9e+VmmJbKUZZVqFNv+4suEmwSI0vpIQY9geHrFJxlIHPwevbHq tARDNOvqlBaG4bypVay/GpCyVVePPD2ODUyisK/vTVJ+oGh+yO3cxUCTbVFz7gVG8fm8M H6aLDXYsg4i68HBw/d/dhEyvJOrJYRo9987tmi4KXkfASASL89o89pGCWUJ4ier4TRS61 +/4h2UQ+jVtcDgOz+gncNgLtrw8Nmh9uBokfZ7w+udmmwBVIUGllJUZ54JVp+8Kn/bg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=UkT3LshT; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE5E5606A332; Thu, 19 Nov 2026 03:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=UkT3LshT Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3192B1F000C4; Thu, 19 Nov 2026 03:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795059622; bh=UrO0Tzy1zu1HTiK3E5Kc0elpvhRIUX0KW8qp10lkEMA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=UkT3LshTLkGLOHfraKvNjtEAws1vW8lSwRAfOAz9SJu0+O7Owfhie1ZiMN+/jVb7k ShEX0fdqQc4xdddNmkYLD//0T82+MujGT9s5q96CuuS+ZrM9olJKzqFc9boFtuZ427 ksctoERW0HQfxSKbc+YZhHhpgFHyvIjxVZ7MltZw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yehyeong Lee , Juergen Gross , Bjorn Helgaas , Sasha Levin Subject: [PATCH 5.10 0907/1848] xen/pcifront: check that an AER callback exists before calling it Date: Wed, 18 Nov 2026 15:49:05 +0100 Message-ID: <20261118145954.777135066@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yehyeong Lee [ Upstream commit 3b4854b69ee70fffb2fa7acac09e715a7efcbae1 ] pcifront_common_process() handles an AER request from the backend by dispatching on aer_op.cmd to the bound driver's PCI error handler. It only checks that err_handler and err_handler->error_detected are present, then for the mmio_enabled, slot_reset and resume commands it calls the corresponding callback unconditionally. Those three callbacks are optional -- the PCI core NULL-checks each of them individually before use -- and many drivers (for example igb, igc, ice and ixgbevf) install error_detected without all of them. aer_op.cmd comes from the shared ring, so a malicious or buggy backend can send XEN_PCI_OP_aer_mmio (or _slotreset/_resume) for a device whose driver leaves that callback NULL and make the frontend call through a NULL pointer, crashing the guest. Check each callback before calling it. When mmio_enabled or slot_reset is absent, return PCI_ERS_RESULT_RECOVERED so recovery proceeds, as the PCI core does for a missing callback; returning PCI_ERS_RESULT_NONE would instead make xen-pciback tear the guest domain down. Fixes: 956a9202cd12 ("xen-pcifront: Xen PCI frontend driver.") Cc: stable@vger.kernel.org Signed-off-by: Yehyeong Lee Reviewed-by: Juergen Gross Acked-by: Bjorn Helgaas Signed-off-by: Juergen Gross Message-ID: <20261006023443.338194-1-yhlee@isslab.korea.ac.kr> Signed-off-by: Sasha Levin --- drivers/pci/xen-pcifront.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index 2ad209ba659bf..4bf3406dfb49e 100644 --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -609,11 +609,16 @@ static pci_ers_result_t pcifront_common_process(int cmd, case XEN_PCI_OP_aer_detected: return pdrv->err_handler->error_detected(pcidev, state); case XEN_PCI_OP_aer_mmio: - return pdrv->err_handler->mmio_enabled(pcidev); + if (pdrv->err_handler->mmio_enabled) + return pdrv->err_handler->mmio_enabled(pcidev); + return PCI_ERS_RESULT_RECOVERED; case XEN_PCI_OP_aer_slotreset: - return pdrv->err_handler->slot_reset(pcidev); + if (pdrv->err_handler->slot_reset) + return pdrv->err_handler->slot_reset(pcidev); + return PCI_ERS_RESULT_RECOVERED; case XEN_PCI_OP_aer_resume: - pdrv->err_handler->resume(pcidev); + if (pdrv->err_handler->resume) + pdrv->err_handler->resume(pcidev); return PCI_ERS_RESULT_NONE; default: dev_err(&pdev->xdev->dev, -- 2.53.0