Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795060058; b=PU1UraWmJgTsh/B4+VRqgrt7oGFJkuJ+voP9uk5ErExryqtPkf/WK2/lRw4cmYnRgv89 5nzwzwv8BMnBHxOWL+SIlVOjbAzyLlQYmcPza1y6P6NrFB8VDhBUzYP8BbxAUDZ0Z6+i/ vQAaIqcrc/z7/xk6Ex6tUlKNClJ9+ps+xhH+C2ziFc8Oz603Fnbj07z5+Gtgttmdpf4fM tpQhxlWIcmMoF6bGg1SASG38ymH/kaQVNuyJW1JMwxG7Zdr8BacJtu40Fj9iaX4tUUCIX 78nzkHKqEgSy++XP4d0KhOg1/+Bvw9U5w7m9ypFwUmoVU+xuhUHifUDHnwuuQHdC6bw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795060058; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=s9Jltcjus/30c5wrflTLfSwbpwJUKuuj2IbaDW1Cba0=; b=PCz6txWGJ0l1gxvdQzvRieKTJVSpJe55XiVYN+4wSWxDwyJBO7JGibEZGw/x2IqPXlsL 21dT5Tf/RdgHHUUogpwTXTdqe0nGQAEcT61fiEEUqxS6s2yBUCNyBrBsrxuPgVB+comUH Ukfl+Wosqnb+JxCIU/k2H+p2Ji3SGR0QqCRBXPBWxboaSypLp8tdcwGjNP59whWs/SQG3 Y0XM+lwWjCJH+daEKnaxvmElRFy3wcR77yTZB9x5rgUsNNmxjZt4b3YGS7SyX6RfptMna TtBWacOTweAQnOUdj7n0nk3p/WB03A4zaHaB3AYmaWepSeWkIAwEST3IelbDcnmGBig== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=y0HEUVDJ; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D610606A320; Thu, 19 Nov 2026 03:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=y0HEUVDJ Received: by smtp.kernel.org (Postfix) with ESMTPSA id B34E51F000C4; Thu, 19 Nov 2026 03:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795060058; bh=s9Jltcjus/30c5wrflTLfSwbpwJUKuuj2IbaDW1Cba0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=y0HEUVDJnDz7rrSvAJszKXlmolerjUaX6RQZqnyULx61Cj1+i8lfVhCH2Kw7/2HBi gEnUZJvZ5XrA34NmhOfHivcAz87iewobjfBZOZTNTCPbzIg4BxywT9V9Qnt19WX1xs oJxPc77nhvr91D6cdw/ut1fckTXwHT3EkjRLZn6U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yizhou Zhao , Yuxiang Yang , Ao Wang , Xuewei Feng , Qi Li , Ke Xu , Dominique Martinet , Sasha Levin Subject: [PATCH 5.10 1022/1848] 9p/xen: drain response work after unbinding IRQ Date: Wed, 18 Nov 2026 15:51:00 +0100 Message-ID: <20261118145959.952064025@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yizhou Zhao [ Upstream commit 7b6f2e3c29fb4d76f1e4973280792eabbd526602 ] commit ea4f1009408e ("9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition") added cancel_work_sync() to keep xen_9pfs_front_free() from freeing a ring while p9_xen_response() is still running. The work is currently drained before the event channel IRQ is unbound. That leaves a race window where xen_9pfs_front_event_handler() can run after cancel_work_sync() returns and queue p9_xen_response() again. The following unbind_from_irqhandler() synchronizes with the IRQ handler, but it does not cancel work that the handler already queued. The teardown can then free the ring and private data while the response work remains pending, and the worker later dereferences ring->priv and priv->client. Unbind the event channel IRQ before draining the work. Once the IRQ is unbound, no new response work can be queued by the backend event channel, and cancel_work_sync() waits for any work that was queued before or during the unbind. It is then safe to release the ring resources. Fixes: ea4f1009408e ("9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition") Cc: stable@vger.kernel.org Reported-by: Yizhou Zhao Reported-by: Yuxiang Yang Reported-by: Ao Wang Reported-by: Xuewei Feng Reported-by: Qi Li Reported-by: Ke Xu Assisted-by: GLM:GLM-5.1 Signed-off-by: Yizhou Zhao Message-ID: <20260609155202.1706-1-zhaoyz24@mails.tsinghua.edu.cn> Signed-off-by: Dominique Martinet [ sashal: adjusted context to the indexed ring cleanup code with its irq > 0 check ] Signed-off-by: Sasha Levin --- net/9p/trans_xen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c index ff81b323ea7b5..45a16494bd79f 100644 --- a/net/9p/trans_xen.c +++ b/net/9p/trans_xen.c @@ -310,12 +310,12 @@ static void xen_9pfs_front_free(struct xen_9pfs_front_priv *priv) for (i = 0; i < priv->num_rings; i++) { struct xen_9pfs_dataring *ring = &priv->rings[i]; - cancel_work_sync(&ring->work); - if (!priv->rings[i].intf) break; if (priv->rings[i].irq > 0) unbind_from_irqhandler(priv->rings[i].irq, ring); + cancel_work_sync(&ring->work); + if (priv->rings[i].data.in) { for (j = 0; j < (1 << priv->rings[i].intf->ring_order); -- 2.53.0