Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795060191; b=uO7+k6jMOF98RNNfZ84Jmuh9VBlAjkBwVB73eS8rdpyWk/LXSIkgFGYzhbu7cJ0E5Fgx lVDdqG+OOca0fZCTAFfMCtqCQojlQVSoH98MFpAgtFLuwoHcT14ouzHdkH+rSR31bsXyI QkY9N6KhZ9eqHYXNZCqLoWa5pgNH79WdeshSJHB0zO9bchF4w83hLvv7wltNyR4hLFpcw XXVk1J7Vht9x5DXlp4/xILPrmq2QtrpV15SmdvQSfIAoEfZLoa5k1MGRhbyWuZSkrnWVW tzFsK4CkUCjGNq3hoT0sZJu7a9VzlP2XRoQtGdI9Q+MNoljyAYjwncRdoNsqXa4N9jA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795060191; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=Be1YhEzvs9YtJ2uIxAXWwFsEXgjRvNyrp9fMaU3acQw=; b=X6j0QXiaQaQLFxsrtJOIO/dHkB8qMdnVmNos2qsl1GnoLZLXS6nDOv/oPlhCNrfQ8R2h jqsChvvO37w71U3lrDPNHv/s+9uZ9RWxJlvaE7E9BTkKdY1U/RuP5wLAcA5Do5SNZzgqL Cx9e5wO9kE0M0BVnTfPlEIdWZiKVK95/6zSHeq1H/RtR4JFIAes3kVgGoWd4gwWNhepyF j0GtrPKB88ZJrQvFKczqR+T2lCvmMTrGJh0RNIx6LpIYNr9yrPlYP9Pa4vZ0pEZCnofcp +iHUC8OmZk3L7oTpmnvZZQ54ArWKEZaibgimQJjm02VTnIsgGoLs4hrIwfjoivbsApA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=wPSz5xfd; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 400B8606A326; Thu, 19 Nov 2026 03:49:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=wPSz5xfd Received: by smtp.kernel.org (Postfix) with ESMTPSA id 915621F000C4; Thu, 19 Nov 2026 03:49:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795060191; bh=Be1YhEzvs9YtJ2uIxAXWwFsEXgjRvNyrp9fMaU3acQw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=wPSz5xfdB10Lp7ywLKB53kaXNTSbDtFj8ExaHE8B653t8Mhaxy0Hxhbc7X7RKW2V1 +yZz+II7/aU+4MnAR6fCpeV5BdV5CyTotFVk1ELVOXh6dK2Mk8H4LD8MBpCxNVcByY 8vWF8AiHCtenB7tveZOVW4Ff2w8bEB93hF/C72RA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko , =?UTF-8?q?Asaf=20Nuri=20Bertizlio=C4=9Flu?= , Guenter Roeck , Sasha Levin Subject: [PATCH 5.10 1068/1848] hwmon: (coretemp) Fix 32-bit jiffies wraparound in show_temp() Date: Wed, 18 Nov 2026 15:51:46 +0100 Message-ID: <20261118150002.527753686@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guenter Roeck [ Upstream commit 9a6aa085c94c7f2817c4d50a7264e6fb51286f40 ] show_temp() rate-limits MSR reads by storing tdata->last_updated as an unsigned long and comparing it against jiffies using time_after(jiffies, tdata->last_updated + HZ). time_after() relies on signed long subtraction, which only produces the expected result while the two timestamps are within LONG_MAX jiffies of each other. On 32-bit kernels, if tempX_input is not read for more than LONG_MAX jiffies (~24.85 days at HZ=1000), the signed difference flips sign and time_after() evaluates to false. Because tdata->last_updated is only refreshed when time_after() succeeds, subsequent reads remain blocked from refreshing for another ~24.85 days until jiffies wraps past tdata->last_updated + HZ again, returning either a stale cached temperature or -ENODATA if the sensor had never been read since initialization. Store tdata->last_updated as a u64 and use get_jiffies_64() with time_after64(), which does not wrap in any practical uptime. Reported-by: Sashiko Fixes: bebe467823c0 ("hwmon: New coretemp driver") Cc: stable@vger.kernel.org Tested-by: Asaf Nuri Bertizlioğlu Signed-off-by: Guenter Roeck [ sashal: adapted the time comparison to preserve the existing !tdata->valid guard for first-read handling ] Signed-off-by: Sasha Levin --- drivers/hwmon/coretemp.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c index cbe2f874b5e2f..d8ab0175f16b1 100644 --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/coretemp.c @@ -70,7 +70,7 @@ struct temp_data { int temp; int ttarget; int tjmax; - unsigned long last_updated; + u64 last_updated; unsigned int cpu; u32 cpu_core_id; u32 status_reg; @@ -157,7 +157,8 @@ static ssize_t show_temp(struct device *dev, mutex_lock(&tdata->update_lock); /* Check whether the time interval has elapsed */ - if (!tdata->valid || time_after(jiffies, tdata->last_updated + HZ)) { + if (!tdata->valid || + time_after64(get_jiffies_64(), tdata->last_updated + HZ)) { rdmsr_on_cpu(tdata->cpu, tdata->status_reg, &eax, &edx); /* * Ignore the valid bit. In all observed cases the register @@ -167,7 +168,7 @@ static ssize_t show_temp(struct device *dev, */ tdata->temp = tdata->tjmax - ((eax >> 16) & 0x7f) * 1000; tdata->valid = 1; - tdata->last_updated = jiffies; + tdata->last_updated = get_jiffies_64(); } mutex_unlock(&tdata->update_lock); -- 2.53.0