Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795060172; b=rf1YuB9g7Kj0FM/M44ZQLm9OGKgL33uSotoRaoIv/aac0mZx5DfusHphGYwTKMqTxvCR V8deN/TmYpcNbM2nIDKanw1xxKbL/agMWH++BCr6XCkYb2hi51+PwP/w/KV4Ss8wSK861 k+ZNfgy2CBw6MEyAySLFMip0c/O/SMl4yEXaWXCHbXIOpoGcJ7UUZWb/2UxuqcZa7eK6p 4Zrq3SJRMLqHOG7flFLRxT9DipNhT6O5Fz8sKeIdrRw3Orcid6/G+AtEb8+8ML9z+SgEo HRsiMeNzXKQWaEpzYp0ou+k9CtHeuNOcjHXgI84Omu3bCwzeERM2meOyXfEbiNgPuIg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795060172; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=GIQfqmeUyFy3at/Ro60P8EbkoV3kl73iXS2rUMZVaf8=; b=bw++xoWuMAYPeWICYJZmxlmO84FHeDIdQBmSQd2uZwRZFX9tumXDn1wovs/rjZuNz0f2 KQpBTCG0VekBoXZGPGNs5jrMpPbdEWgqmtFbrYXj57KhldC9ThYkv62g5lDG35hog1nAb hVUwHAuUWQk4a7sQh/efEzsD16mEGsYXwyj2TsifVyaFrRF7/l3vleKOCaPdObSHMJhTm sYFVDTszehFTFfLRJ2YJtxxKcl5H6UlFPZO5nqTDfiYXAXWos3f5OAFnkDD/irRwt1OQT T2Cr7JSMKHs3i1CanUIlZPFaJQNiXwXCKAKnizmQNZhfYKJDahx2ZuGHrBHCK1G3JwA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=jpyXgMui; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACAEE606A320; Thu, 19 Nov 2026 03:49:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=jpyXgMui Received: by smtp.kernel.org (Postfix) with ESMTPSA id 143631F000C4; Thu, 19 Nov 2026 03:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795060172; bh=GIQfqmeUyFy3at/Ro60P8EbkoV3kl73iXS2rUMZVaf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jpyXgMuiWsu/LqfXBwMf7BNeMG7z3fRomBKPmLgIzH/GgF+XgOU+i6jzQb1IOE+Cz I5EUdkM22whY4z23lL3LradbVi+kG7GnH/vXfCEw8M8G9wMk8c4tRlerBElBWY6BFN Kx6n6LjTO/TN0l+bW3n7NURqsKN0IKvXOGvb7oGc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Josef Bacik , Rik van Riel , Pedro Falcato , Muhammad Usama Anjum , "David Hildenbrand (Arm)" , Sasha Levin Subject: [PATCH 5.10 1102/1848] mm/filemap: dont lose a folio lock wakeup to a signal Date: Wed, 18 Nov 2026 15:52:20 +0100 Message-ID: <20261118150005.290580318@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Josef Bacik [ Upstream commit 8ccb6ded6a47b59b4907ed4f8c293cf8122de889 ] An exclusive waiter in folio_wait_bit_common() can leave the wait loop because of a fatal signal, then be woken by folio_unlock() before finish_wait(). If the waker did not hand over the lock, the waiter returns -EINTR without trying to acquire it. folio_wake_bit() stops after waking the first exclusive waiter, so this loses the wakeup and can leave other waiters asleep indefinitely on an unlocked folio. After finish_wait(), let a waiter woken without a lock handoff try once more to acquire the lock. If successful, return success so the caller's eventual unlock wakes the next waiter. Otherwise, the current lock owner will do so. Fix generated by an LLM and sent by Josef Bacik in private. Fixes: 5ef64cc8987a ("mm: allow a controlled amount of unfairness in the page lock") Cc: stable@vger.kernel.org Signed-off-by: Josef Bacik [ david: clarify and simplify comment + description ] Reviewed-by: Rik van Riel Acked-by: Pedro Falcato Tested-by: Muhammad Usama Anjum Link: https://patch.msgid.link/20261031-fixes_core-v3-7-d6437171ecc3@kernel.org Signed-off-by: David Hildenbrand (Arm) [ sashal: Replaced folio_flags(folio, 0) with &page->flags to match the existing page-based wait function. ] Signed-off-by: Sasha Levin --- mm/filemap.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index f8a28274828f3..5fed26cf2020e 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1328,10 +1328,22 @@ static inline int wait_on_page_bit_common(wait_queue_head_t *q, * return value based on that state without races. * * Also note that WQ_FLAG_WOKEN is sufficient for a non-exclusive - * waiter, but an exclusive one requires WQ_FLAG_DONE. + * waiter, but an exclusive one must also acquire the bit. */ - if (behavior == EXCLUSIVE) - return wait->flags & WQ_FLAG_DONE ? 0 : -EINTR; + if (behavior == EXCLUSIVE) { + if (wait->flags & WQ_FLAG_DONE) + return 0; + /* + * We might have just been woken up and the waker will not + * wake up anybody else. If we ignore that now, the remaining + * waiters may not get woken up: take the bit now if it is + * still free. + */ + if ((wait->flags & WQ_FLAG_WOKEN) && + !test_and_set_bit(bit_nr, &page->flags)) + return 0; + return -EINTR; + } return wait->flags & WQ_FLAG_WOKEN ? 0 : -EINTR; } -- 2.53.0