Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795060296; b=ZqYNZsO5mcN326x3LobQ75Rr8cQ7Mh+RccJYxAW/rAQkaweJG6TnK1Cf/jWhoaiR9WRw x5+DEyAsohl5GQRGukws+DjWmWU6032GO6bT7Htx0gW9qYsr9CNhmAG9fQtzucRy5qT4c PrLLwS4AN5YkYGQ4OePY1FdCUpLoYhqUlCMMwDiCGUTEW5OAjg5u0DpQjQ+l1M6TVDs0M SkgiDXn9W8dDFTCzXE54wLw2y9DorP5bCBTgexK9ikBdBJNx2bmbbPqj5YY3o62jkYXLw cMVqV9+zLSRPCihP5cXLCeljZZwUTXn3kO/hAAHlKmfRXABGcs9v1EyaXQqPqpnP73g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795060296; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=yN1F104S1fveUt3LPuKB13mQcq5bxXoPDuoZXBnpfjQ=; b=eNggdayd3Kmc1ndLE+DwQGojhtk+xgP8ojv5xadejxCTtJ2xE2U9A61aXX/CteH5ePTJ EtC6giIzEsW4KFoDUVSSjxRYR3uf/Dklu3yq4KQJM3v0icpoy3wilmyLIefusQzL67iwh c2WtoBto5YiqhHZUT3GfOrTpUKckAomVK2fjWRh+UXGggm4IzwoJYEX0gHMdc3H43eJ7s Iw/pvK8LZxAu22Dghw2HMH8ZRM4YTA3MLMTyTvDb5IF414zdGnpXL0KQESY2KL16TI9ty jM81D0Y1gqfOZtq2T7Rb1ZjqVluBZP2yNUieeKAA/QTvOGf8YXs/k8vTb1e22ecwQ8Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Q+MnXMQT; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A8D0606A320; Thu, 19 Nov 2026 03:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Q+MnXMQT Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4B4F1F000C4; Thu, 19 Nov 2026 03:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795060296; bh=yN1F104S1fveUt3LPuKB13mQcq5bxXoPDuoZXBnpfjQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Q+MnXMQT2y41nErtxRJqVA07Xn8UEsSe1Wp/NJQA20TByrWtWywazGDHG4RTJ7Foc hqUb5GPgVmM4p48BMM/nbdh0tZOoYLv1/Qqs340szXS8d9uKE28YlKmANR7Tl/dI7F Q4wtb544ptD2mGDd2SHUi8eQT2iNh0ZsY272UIRU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sashiko-bot , Ian Rogers , Stefano Sanfilippo , Stephane Eranian , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 5.10 1146/1848] perf jitdump: Validate unwinding sizes against record payload Date: Wed, 18 Nov 2026 15:53:04 +0100 Message-ID: <20261118150007.732113199@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnaldo Carvalho de Melo [ Upstream commit 92d50319b4f0c0bbee8a236a09063272cd22faab ] jit_repipe_unwinding_info() copies unwinding_size and eh_frame_hdr_size from the jitdump record into jd-> fields without checking them against the actual payload size. Downstream, jit_add_eh_frame_info() in genelf.c computes unwinding_table_size = unwinding_size - eh_frame_hdr_size, which underflows when eh_frame_hdr_size > unwinding_size. The result is passed as d->d_size to libelf, causing an OOB heap read into the output ELF file. Validate that unwinding_size fits within the record payload and that eh_frame_hdr_size does not exceed unwinding_size before allocating or storing the values, so a bogus record cannot force a large allocation that is then discarded. mapped_size is likewise taken from the record and was narrowed into an int for the mmap2 len computation in jit_repipe_code_load() and jit_repipe_code_move(); values above INT_MAX would turn negative, producing a wrong mmap2 length. Use uint64_t for usize so the value cannot truncate. Fixes: 0284fecd13b6db3e ("perf jit: Add unwinding support") Reported-by: sashiko-bot Reviewed-by: Ian Rogers Cc: Stefano Sanfilippo Cc: Stephane Eranian Assisted-by: LLM Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/jitdump.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/jitdump.c b/tools/perf/util/jitdump.c index e23ba5866ffce..49b055313ea6a 100644 --- a/tools/perf/util/jitdump.c +++ b/tools/perf/util/jitdump.c @@ -469,7 +469,8 @@ static int jit_repipe_code_load(struct jit_buf_desc *jd, union jr_entry *jr) u16 idr_size; const char *sym; uint64_t count; - int ret, csize, usize; + int ret, csize; + uint64_t usize; pid_t nspid, pid, tid; struct { u32 pid, tid; @@ -550,7 +551,7 @@ static int jit_repipe_code_load(struct jit_buf_desc *jd, union jr_entry *jr) event->mmap2.pgoff = GEN_ELF_TEXT_OFFSET; event->mmap2.start = addr; - event->mmap2.len = usize ? ALIGN_8(csize) + usize : csize; + event->mmap2.len = usize ? ALIGN_8((uint64_t)csize) + usize : (uint64_t)csize; event->mmap2.pid = pid; event->mmap2.tid = tid; event->mmap2.ino = st.st_ino; @@ -603,7 +604,7 @@ static int jit_repipe_code_move(struct jit_buf_desc *jd, union jr_entry *jr) char *filename; size_t size; struct stat st; - int usize; + uint64_t usize; u16 idr_size; int ret; pid_t nspid, pid, tid; @@ -750,6 +751,18 @@ jit_repipe_unwinding_info(struct jit_buf_desc *jd, union jr_entry *jr) return -1; unwinding_data_size = jr->prefix.total_size - sizeof(jr->unwinding); + + /* + * Validate sizes before allocating — jit_add_eh_frame_info() + * computes unwinding_size - eh_frame_hdr_size and uses the + * result as a buffer length for libelf. + */ + if (jr->unwinding.unwinding_size > unwinding_data_size || + jr->unwinding.eh_frame_hdr_size > jr->unwinding.unwinding_size) { + pr_warning("jitdump: invalid unwinding sizes in unwinding_info record\n"); + return -1; + } + unwinding_data = malloc(unwinding_data_size); if (!unwinding_data) return -1; -- 2.53.0