Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795060396; b=1z4LCLlh+8vb3Mu3dqOPUn5DNEMKb4lM9uyPLz23YU+OvirmlK4Jfiq6z9rJr8VoA9xS 0d+UkESFM6v8aIdvWHbnhG8uH8Z5X34PCIGltkZXuy3JZvnS6+JSdw0XZrA/myUAjHFr1 gK1z/f+OM3gm79HyBgDf1MlFp9WQ1I04EknBvSz4ezSrr9xu3u8X8ZwJd/+sm7DzfVVi4 yg+o2NH0O/0DaSVX8Aoe7RbgzXUOsY/+v+Mb+QxTOXZvVEPvj/8HOTrqxNn60uRW6ZvFq tXWvHNEHCZc85dVVU2/fK1Le7K67MDKtSirL96nx/bML6QYTf0BilRUGTy82JkVZEcw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795060396; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=8y6TkBLUmagVweaGCjFQ4aG+W2uYyvFxRhdv9b+M5dA=; b=SC7NAn7b/cnrhsrSFxXy8JPiJ6IJIIrowgrYCci6fCQbGEFZJz5bS3opsQm3qnRDfqgU znNXHBfl2d0JbU5m8WHlZ1OvO0kgcXcEtul4Tsi6BB1Het476rtoc6S8YW9vSKY+4tSa/ bOCx+OCnxIHRzmsBsP1nAKwW1HaYaIu/ibTdBXzTJ+o6e+thoQta6+QDTiPwkojrrZTu9 yNZzNn9VgFxzcEDKQBY7VJeJsyd10XxXW4lZcy9tNZJTXlv6KrYniaCCqyH4eX1d++fw8 NnP0DRPLu/AGgAbIESu3wrk9nZFXKrsYNwNF27pHYDkvOxDYfa3hY4T9HBsutO6pYvQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=syKEbmm9; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA415606A326; Thu, 19 Nov 2026 03:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=syKEbmm9 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1DEB1F000C4; Thu, 19 Nov 2026 03:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795060396; bh=8y6TkBLUmagVweaGCjFQ4aG+W2uYyvFxRhdv9b+M5dA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=syKEbmm9eX9ktzyPCFoaCbydEmxTuRpxstIOeEwEOk/ac4iSOflF4JwX+kdDtaZbE H2UYdPF0r7JWIs5ywiiR4A55AU9y0rc2bZ/Nzj0A3zej2XUy21pMDRpSPNEY4uWyjn F7DDiqxA9EF98SNKjxqZYqlGJ0gR/B9B6y//G+5E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hongling Zeng , Jernej Skrabec , Frank Li , Vinod Koul , Sasha Levin Subject: [PATCH 5.10 1183/1848] dmaengine: sun6i-dma: Fix use-after-free in error handling paths Date: Wed, 18 Nov 2026 15:53:41 +0100 Message-ID: <20261118150009.064580922@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hongling Zeng [ Upstream commit f472919f4c0650d7fb22bb230eacaada0c6ee951 ] In error handling paths, the for loop frees v_lli in the loop body, then accesses v_lli->v_lli_next and v_lli->p_lli_next in the increment expression, which is use-after-free. Fix by refactoring the cleanup into a helper function sun6i_dma_free_desc() that saves both the next virtual and physical pointers before freeing the current node, preventing the use-after-free. Fixes: 555859308723 ("dmaengine: sun6i: Add driver for the Allwinner A31 DMA controller") Signed-off-by: Hongling Zeng Suggested-by: Jernej Skrabec Reviewed-by: Jernej Skrabec Reviewed-by: Frank Li Link: https://patch.msgid.link/20260727061142.44195-1-zenghongling@kylinos.cn Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/sun6i-dma.c | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c index dd358971f9506..21e0d0db8cd66 100644 --- a/drivers/dma/sun6i-dma.c +++ b/drivers/dma/sun6i-dma.c @@ -397,16 +397,12 @@ static inline void sun6i_dma_dump_lli(struct sun6i_vchan *vchan, v_lli->len, v_lli->para, v_lli->p_lli_next); } -static void sun6i_dma_free_desc(struct virt_dma_desc *vd) +static void sun6i_dma_free_desc(struct sun6i_dma_dev *sdev, + struct sun6i_desc *txd) { - struct sun6i_desc *txd = to_sun6i_desc(&vd->tx); - struct sun6i_dma_dev *sdev = to_sun6i_dma_dev(vd->tx.chan->device); struct sun6i_dma_lli *v_lli, *v_next; dma_addr_t p_lli, p_next; - if (unlikely(!txd)) - return; - p_lli = txd->p_lli; v_lli = txd->v_lli; @@ -423,6 +419,17 @@ static void sun6i_dma_free_desc(struct virt_dma_desc *vd) kfree(txd); } +static void sun6i_dma_free_desc_virt(struct virt_dma_desc *vd) +{ + struct sun6i_desc *txd = to_sun6i_desc(&vd->tx); + struct sun6i_dma_dev *sdev = to_sun6i_dma_dev(vd->tx.chan->device); + + if (unlikely(!txd)) + return; + + sun6i_dma_free_desc(sdev, txd); +} + static int sun6i_dma_start_desc(struct sun6i_vchan *vchan) { struct sun6i_dma_dev *sdev = to_sun6i_dma_dev(vchan->vc.chan.device); @@ -752,10 +759,7 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep_slave_sg( return vchan_tx_prep(&vchan->vc, &txd->vd, flags); err_lli_free: - for (p_lli = txd->p_lli, v_lli = txd->v_lli; v_lli; - p_lli = v_lli->p_lli_next, v_lli = v_lli->v_lli_next) - dma_pool_free(sdev->pool, v_lli, p_lli); - kfree(txd); + sun6i_dma_free_desc(sdev, txd); return NULL; } @@ -821,10 +825,7 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep_dma_cyclic( return vchan_tx_prep(&vchan->vc, &txd->vd, flags); err_lli_free: - for (p_lli = txd->p_lli, v_lli = txd->v_lli; v_lli; - p_lli = v_lli->p_lli_next, v_lli = v_lli->v_lli_next) - dma_pool_free(sdev->pool, v_lli, p_lli); - kfree(txd); + sun6i_dma_free_desc(sdev, txd); return NULL; } @@ -1354,7 +1355,7 @@ static int sun6i_dma_probe(struct platform_device *pdev) struct sun6i_vchan *vchan = &sdc->vchans[i]; INIT_LIST_HEAD(&vchan->node); - vchan->vc.desc_free = sun6i_dma_free_desc; + vchan->vc.desc_free = sun6i_dma_free_desc_virt; vchan_init(&vchan->vc, &sdc->slave); } -- 2.53.0