Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795060469; b=bo6accRq3hmsjLkK2t5HGgY/2kpfYHbkd3roXuJicsyAjpLo7gMCf6IlKOSaTq5eve7i lH237C5fUdRuZCHK4S/l6lmYM5m4KxBwztakCxFqrIFlXAqMVuocmGZUiIGlq1nxw7fbz zoqeM2OIXu+8ABSS5Hz0dhxoG/RLccDlEf4cwHRfoTjGqS9NSe3ZvBbifNHo5e1MX4VaY xfYNJXki0ftg17KQGcwzp3/e69ck83RjotJMRINNkDzlhsJdRHej59kNTtzYmbza7QDWa sGTNJAhMD6slN5qfT0NzF7kLHFNRsx2aU+tiBVOfHPDQCL1GA/OqnzdZ0jCGq6krYOg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795060469; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=rI79xf5sQB+vgqQ9+MYSzBk1BBo1R0wKcrYM1G/JRfQ=; b=N3fxS+ik/AystRGocv95ehWJb6pNTPIbbkBrZPBRq7ifGZHaTGB/miGU3EEAUYzPslSk RmJ5suT5gs1d6ltCDULa4n+YxlIu5dD0CGBQgN6h5FYKcluyCQ55Sc2ffZ98qZ4S8m2jU dfeezfIJkhvYvED3GCmTweYyV1uvde7WKQ2CdZ+Bct0gTwPSch1zd2+zrWdraLutDxHvh kOh907d41F79TnM0cguBxJreZCRWC9LUBi43pedaf6Qy9G3F5Y8QQB8XfhQqxbGp4H/Ur idTnegqDaEYfndgc7Dh91X9jxVuTrVz+2GnRGFcMH829zs2c8BffM6mNeaddBV4pQ5w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ayBsmygu; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29206606A326; Thu, 19 Nov 2026 03:54:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ayBsmygu Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79D2F1F000C4; Thu, 19 Nov 2026 03:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795060469; bh=rI79xf5sQB+vgqQ9+MYSzBk1BBo1R0wKcrYM1G/JRfQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ayBsmyguzT50jos3Uj7IPsrry3VDET1I5LB4VLVXjxvR0YA9yo/LefB0MfwWBsomd BVrVMHanyg7fQQjZrLhUh1RgoIwtplzrAHPjC1ll+xywfZPpRnoWo51P2jSr3D5iYX LCvL4T9SjDKkfIoX7qXB31GccXbocmegD2E24MoE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Arka Mondal , Alan Stern , Sasha Levin Subject: [PATCH 5.10 1211/1848] usb-storage: alauda: check the return value of alauda_read_map() Date: Wed, 18 Nov 2026 15:54:09 +0100 Message-ID: <20261118150010.690889763@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arka Mondal [ Upstream commit eb882419790c6710646904c6b25132189152cf33 ] alauda_ensure_map_for_zone() ignores the value alauda_read_map() returns. On failure lba_to_pba[zone] and pba_to_lba[zone] are left NULL, and both callers dereference them immediately: pba = MEDIA_INFO(us).lba_to_pba[zone][lba_offset]; alauda_read_map() returns USB_STOR_TRANSPORT_ERROR when either kcalloc() fails or an alauda_get_redu_data() transfer fails, so one failed bulk transfer is enough to reach the NULL dereference. Return that value from alauda_ensure_map_for_zone() and check it in alauda_read_data() and alauda_write_lba(). Fixes: e80b0fade09e ("[PATCH] USB Storage: add alauda support") Link: https://bugzilla.kernel.org/show_bug.cgi?id=217862 Signed-off-by: Arka Mondal Acked-by: Alan Stern Link: https://patch.msgid.link/20260901065831.43567-3-arka@arkamondal.net Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/storage/alauda.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c index db73d1452fa29..de74f98f7a8be 100644 --- a/drivers/usb/storage/alauda.c +++ b/drivers/usb/storage/alauda.c @@ -697,11 +697,13 @@ static int alauda_read_map(struct us_data *us, unsigned int zone) * Checks to see whether we have already mapped a certain zone * If we haven't, the map is generated */ -static void alauda_ensure_map_for_zone(struct us_data *us, unsigned int zone) +static int alauda_ensure_map_for_zone(struct us_data *us, unsigned int zone) { if (MEDIA_INFO(us).lba_to_pba[zone] == NULL || MEDIA_INFO(us).pba_to_lba[zone] == NULL) - alauda_read_map(us, zone); + return alauda_read_map(us, zone); + + return 0; } /* @@ -849,7 +851,9 @@ static int alauda_write_lba(struct us_data *us, u16 lba, unsigned int new_pba_offset; unsigned int zone = lba / uzonesize; - alauda_ensure_map_for_zone(us, zone); + result = alauda_ensure_map_for_zone(us, zone); + if (result != USB_STOR_TRANSPORT_GOOD) + return result; pba = MEDIA_INFO(us).lba_to_pba[zone][lba_offset]; if (pba == 1) { @@ -980,7 +984,10 @@ static int alauda_read_data(struct us_data *us, unsigned long address, unsigned int lba_offset = lba - (zone * uzonesize); unsigned int pages; u16 pba; - alauda_ensure_map_for_zone(us, zone); + + result = alauda_ensure_map_for_zone(us, zone); + if (result != USB_STOR_TRANSPORT_GOOD) + break; /* Not overflowing capacity? */ if (lba >= max_lba) { -- 2.53.0