Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795060472; b=IreAh3B05eVjgKuOkT6+GxGkK5a0Ehn4TUzodFlYEJqq6miyHQtbA8SpFclnZwsklECm Q3cgoegDPnqoLdvQia1xQD3JvdWFkwCq5kqlsZrz7FM5+Ih33nHh3mxztyz4/xUoN/53A nlljUTg3oP99hsXCQIubDNtJZCZYl5uDrJ/FTFBTYPZ+APoQGrpChZcvDZJhc3nNaqBPC 0arp2Vl6RwRhxYAqNZoQzzCrhBQ7wjria+hW3s9aoK7PYmPyl9fmxA2OzsxsW3NbKMsrE No/bFeNe89sALcbzh1VmsLZb4h6iqqYcckpIjhliEEaCZvBrgYXCDKhoTCwlJj3togg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795060472; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=EuFY1rbZosxrwErlqwF2rA3X7rrHQSfyBCooOBRm9YE=; b=RVZrefmxtRLleDxHvi/bjDFh6nGGelzWxdi2mxCdnOKOyCJtBKQQZ8dt7a6OMCfqyg5s SsRAZLWncgZPSOicy+h+R2dARyhWgg9d3DynTk8QEWBzQ+KGHwoVhyusgvr7aW2xK9lMJ xdajrWKP/CFlUpvVZhvCum3mqNFED4d6a/B923IGq/qYI6OOQzxGIMkVJmAS11P+j0Lll /A53mrZNzAjjmERYC9TZpqRZ78DuXVTx6Su+nShBQoSTFb+ANxPldhJiXUV1rFFunGQwl mrQYdiS+bY6PUm/gzfCSaYxfkJhfUAB4fFysGy9TTsv1bGx4G+T7LcqRnNETUp3J6Rg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=FlECBErm; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DDD0606A326; Thu, 19 Nov 2026 03:54:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=FlECBErm Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EFD01F000C4; Thu, 19 Nov 2026 03:54:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795060471; bh=EuFY1rbZosxrwErlqwF2rA3X7rrHQSfyBCooOBRm9YE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FlECBErm0gHWGwoq0ezC3S6hK9Ll5n3KCybpZ+8qtPJIMIGKsa/HHLw06eHV4ZENl Jgr1wXqrnfHPJnZpgk/fKup2K8R0xsTgKp1O6w3vS2ywUa6XRjECVfIC4IpUq3TqzZ kZxJ3W1obtf4hUhl9+2J3kOkFJsz5Hjf2bg27GBI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alan Stern , Arka Mondal , Sasha Levin Subject: [PATCH 5.10 1212/1848] usb-storage: alauda: fix out-of-bounds zone index Date: Wed, 18 Nov 2026 15:54:10 +0100 Message-ID: <20261118150010.730274953@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arka Mondal [ Upstream commit c4542993c071fcafe7335698bf52650dee7e3555 ] MEDIA_INFO(us).lba_to_pba and .pba_to_lba are arrays of num_zones pointers, allocated by kcalloc() in alauda_init_media(). alauda_ensure_map_for_zone() reads lba_to_pba[zone] and pba_to_lba[zone], and when either is NULL alauda_read_map() writes a pointer back to both. Two separate errors let zone reach num_zones, one element past the end. max_lba is capacity >> (blockshift + pageshift), which counts physical blocks, but zone is lba / uzonesize and uzonesize is 125/128 of zonesize. On a 16 MB card (alauda_card_ids id 0x73) num_zones is 1 and uzonesize is 1000, so lba 1000 to 1023 pass the bounds check and index element 1 of a one-element array. alauda_read_data() also calls alauda_ensure_map_for_zone() before it compares lba against max_lba, so any larger lba is used as an index before the check rejects it. alauda_write_data() already checks first. Bound lba by num_zones * uzonesize on both paths and move the read side's call below the check. alauda_transport() reports num_zones * uzonesize * blocksize for READ_CAPACITY, so the new bound is exactly the range the device advertises and no block becomes unreachable. sd never issues an lba past the reported capacity; an SG_IO READ_10 can. Fixes: e80b0fade09e ("[PATCH] USB Storage: add alauda support") Suggested-by: Alan Stern Signed-off-by: Arka Mondal Acked-by: Alan Stern Link: https://patch.msgid.link/20260901065831.43567-4-arka@arkamondal.net Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/storage/alauda.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c index de74f98f7a8be..d0440c117f642 100644 --- a/drivers/usb/storage/alauda.c +++ b/drivers/usb/storage/alauda.c @@ -949,6 +949,7 @@ static int alauda_read_data(struct us_data *us, unsigned long address, unsigned char *buffer; u16 lba, max_lba; unsigned int page, len, offset; + unsigned int num_zones; unsigned int blockshift = MEDIA_INFO(us).blockshift; unsigned int pageshift = MEDIA_INFO(us).pageshift; unsigned int blocksize = MEDIA_INFO(us).blocksize; @@ -973,7 +974,9 @@ static int alauda_read_data(struct us_data *us, unsigned long address, /* Figure out the initial LBA and page */ lba = address >> blockshift; page = (address & MEDIA_INFO(us).blockmask); - max_lba = MEDIA_INFO(us).capacity >> (blockshift + pageshift); + num_zones = MEDIA_INFO(us).capacity >> (MEDIA_INFO(us).zoneshift + + blockshift + pageshift); + max_lba = num_zones * uzonesize; result = USB_STOR_TRANSPORT_GOOD; offset = 0; @@ -985,10 +988,6 @@ static int alauda_read_data(struct us_data *us, unsigned long address, unsigned int pages; u16 pba; - result = alauda_ensure_map_for_zone(us, zone); - if (result != USB_STOR_TRANSPORT_GOOD) - break; - /* Not overflowing capacity? */ if (lba >= max_lba) { usb_stor_dbg(us, "Error: Requested lba %u exceeds maximum %u\n", @@ -997,6 +996,10 @@ static int alauda_read_data(struct us_data *us, unsigned long address, break; } + result = alauda_ensure_map_for_zone(us, zone); + if (result != USB_STOR_TRANSPORT_GOOD) + break; + /* Find number of pages we can read in this block */ pages = min(sectors, blocksize - page); len = pages << pageshift; @@ -1052,6 +1055,7 @@ static int alauda_write_data(struct us_data *us, unsigned long address, unsigned int pagesize = MEDIA_INFO(us).pagesize; struct scatterlist *sg; u16 lba, max_lba; + unsigned int num_zones; int result; /* @@ -1078,7 +1082,9 @@ static int alauda_write_data(struct us_data *us, unsigned long address, /* Figure out the initial LBA and page */ lba = address >> blockshift; page = (address & MEDIA_INFO(us).blockmask); - max_lba = MEDIA_INFO(us).capacity >> (pageshift + blockshift); + num_zones = MEDIA_INFO(us).capacity >> (MEDIA_INFO(us).zoneshift + + blockshift + pageshift); + max_lba = num_zones * MEDIA_INFO(us).uzonesize; result = USB_STOR_TRANSPORT_GOOD; offset = 0; -- 2.53.0