Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795060483; b=AKBMLPxj5EM57sRoZKSQhOXhYTrZKC+ecuMR0flTMeMw21HP4fPimxYC/J/oi+n6iHTD mQjdZHNyMmddI/9zb32kAiXm065PKYsaH+bhwSHK9Zd94peBgJtuiy/1FSjfyFP+18Pw/ tXWAULQrserkW5K/u8PMJVT/WRwJ9vDYWehXO68ikxcfEXWuqwEl7MJuIdGzw7PmUaXok JcmjCjRC8Bqp+ompVoM94GulxpqpW7WIFc+KZAmUAXL97YNJeF2cJH5r9gpCmy5SKLBP0 P7PTo3lYFDao0u0LRM0BzAsvYIOtkxSLXORd8DCAE/8oUhEaWvIB7IwChie0NXXJZtA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795060483; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=zosmwNfkFV8RAenUb0qUo5DqaHxNsmW0mYDIt4ozAIs=; b=MM+jUh3oUHJqgUIyKJi+DEAG0ZyWJ0vyIJ7sePGBH+zuZLcqIMAt7WDvxC5rRZcTD5CU 1pAQm+fGytK4ezD30GZSU3zakqweLz04VhyIMVMMXqc5fW4G99WebXi2ra1aHi1DFk1YW LMzZNkaFKK24sWg1MrAX9awffcZDtYQLhYew8E1TINOTD4yH3VAGE7yVbCXU1ctPHji9B D/gnlTtEDpxbA3KGfg1mR8HzEDO1ta2nBQ/+P1P2zhHdFM3VOsJM0+i3VciVB24rJ17+S mNqcVkqGZwRIXxExUIxAXYAgwG/GDpbVOf6hq3VQ8bH0GAiIUlGzjkBWNjismWy1QzQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=s8kKrVxb; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A5B6606A320; Thu, 19 Nov 2026 03:54:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=s8kKrVxb Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C8911F000C5; Thu, 19 Nov 2026 03:54:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795060482; bh=zosmwNfkFV8RAenUb0qUo5DqaHxNsmW0mYDIt4ozAIs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=s8kKrVxbj3PeW+9Ma4HPfocsfYlF4x/2PEOlsjBRYZNpEgmBYyvNPGABrcFIPzYDa J3DDMu1Es/q+VrG+9Mtkh0W8rCxSw77FZWBZfE1syjwoxJYrUqGGgjRctqrgZMZuzR oZULKcSGZEHTxzox4YpOvhcwEEGMUe2d8L/+SB9E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chaithanya Lagisetty , Frank Li , Vinod Koul , Sasha Levin Subject: [PATCH 5.10 1215/1848] dmaengine: sprd: use clk_bulk API to fix clock imbalance Date: Wed, 18 Nov 2026 15:54:13 +0100 Message-ID: <20261118150010.844630658@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chaithanya Lagisetty [ Upstream commit d09cd5e8bbc98969b5333015b45c525078ac0f6f ] sprd_dma_enable() enabled sdev->clk and then the optional ashb_clk. If enabling ashb_clk failed, sdev->clk was left enabled: both callers (probe and resume) treat a non-zero return as "nothing was enabled" and bail out, leaking sdev->clk. Convert the driver to the clk_bulk API. clk_bulk_prepare_enable() enables all clocks and unwinds them on failure, and clk_bulk_disable_unprepare() disables them, which fixes the imbalance and simplifies the enable/disable paths. Both clocks are fetched with devm_clk_bulk_get_optional(); the optional ashb_eb clock simply becomes a NULL entry that the bulk helpers treat as a no-op, while the mandatory enable clock is still checked explicitly. Fixes: 9b3b8171f7f4 ("dmaengine: sprd: Add Spreadtrum DMA driver") Signed-off-by: Chaithanya Lagisetty Reviewed-by: Frank Li Link: https://patch.msgid.link/20260819053518.2825514-1-nagachaithanya9911@gmail.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/sprd-dma.c | 45 ++++++++++++------------------------------ 1 file changed, 13 insertions(+), 32 deletions(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index e6ba7f7df8638..e27b77715a679 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -208,8 +208,7 @@ struct sprd_dma_chn { struct sprd_dma_dev { struct dma_device dma_dev; void __iomem *glb_base; - struct clk *clk; - struct clk *ashb_clk; + struct clk_bulk_data clks[2]; int irq; u32 total_chns; struct sprd_dma_chn channels[]; @@ -260,31 +259,12 @@ static void sprd_dma_chn_update(struct sprd_dma_chn *schan, u32 reg, static int sprd_dma_enable(struct sprd_dma_dev *sdev) { - int ret; - - ret = clk_prepare_enable(sdev->clk); - if (ret) - return ret; - - /* - * The ashb_clk is optional and only for AGCP DMA controller, so we - * need add one condition to check if the ashb_clk need enable. - */ - if (!IS_ERR(sdev->ashb_clk)) - ret = clk_prepare_enable(sdev->ashb_clk); - - return ret; + return clk_bulk_prepare_enable(ARRAY_SIZE(sdev->clks), sdev->clks); } static void sprd_dma_disable(struct sprd_dma_dev *sdev) { - clk_disable_unprepare(sdev->clk); - - /* - * Need to check if we need disable the optional ashb_clk for AGCP DMA. - */ - if (!IS_ERR(sdev->ashb_clk)) - clk_disable_unprepare(sdev->ashb_clk); + clk_bulk_disable_unprepare(ARRAY_SIZE(sdev->clks), sdev->clks); } static void sprd_dma_set_uid(struct sprd_dma_chn *schan) @@ -1132,16 +1112,17 @@ static int sprd_dma_probe(struct platform_device *pdev) if (!sdev) return -ENOMEM; - sdev->clk = devm_clk_get(&pdev->dev, "enable"); - if (IS_ERR(sdev->clk)) { - dev_err(&pdev->dev, "get enable clock failed\n"); - return PTR_ERR(sdev->clk); - } + /* The ashb_eb clock is optional and only present for AGCP DMA */ + sdev->clks[0].id = "enable"; + sdev->clks[1].id = "ashb_eb"; + ret = devm_clk_bulk_get_optional(&pdev->dev, ARRAY_SIZE(sdev->clks), + sdev->clks); + if (ret) + return dev_err_probe(&pdev->dev, ret, "get clocks failed\n"); - /* ashb clock is optional for AGCP DMA */ - sdev->ashb_clk = devm_clk_get(&pdev->dev, "ashb_eb"); - if (IS_ERR(sdev->ashb_clk)) - dev_warn(&pdev->dev, "no optional ashb eb clock\n"); + if (!sdev->clks[0].clk) + return dev_err_probe(&pdev->dev, -ENOENT, + "get enable clock failed\n"); /* * We have three DMA controllers: AP DMA, AON DMA and AGCP DMA. For AGCP -- 2.53.0