Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795060706; b=42P4i3T3vaFhGAkS+rIEv59z3oXz4BZe8h6vUpEdzzIw/E6ow4ysgrzJeq65YYQoENp3 r5NfpVH/pHAVG+9GeSWjHLvYXOknJz25v1eLgcTUself/w9YUHgW3dy9k+IRzfRJEzZjJ UqqKn71e2cxDqV/fNRA0HAtgP0h0ulh0L0p3K9i1QSZRi2zOXZg8+sK+3toPJWfAXXiyM 34e84GG7RMY4lbBTrafzlnVinbtbWobYNhNN9hiI4SwAaYlcsZ+6PdwmPK9SN59uIVDGx i10xtNP9QeCXcOOX7L7dYbo6N0R+yTk2sXB6DGwSCvLQxXIrZIhHdTDq6QkcZdZiKKA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795060706; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=JNSuWrBhylxlE+KO/JsdnTeonvRR0fzLsiUqGH7PtaM=; b=i6FPMx9MAvjkfzsSltMXqx0z1iFXhz+uL6Px+TufWUYs3iKt9REvnLxEch/cGA+K68fn XvW/5b2Fk0ntWG/0B+f4NP9i7iIRJb1aZqtnDwXea06y3J5iTBfRHgXI+fO8zr9LU2lXJ 3OWZqBGRawMDePTGrGOFhfjx8rykyLtaTuv81vwoocQv1wmMGEkFichXYjTxxuFBCh9XK ceT5ZAsvfvFw3bEJBRIKC7/MAeXDqV5b7ftPNg8PivIAjubZirJyKSqq5cNuwgl2cJcBE 008cXQiFOOQphOeGjvtBJCDVEZj5Z2uUKnG7ogjq8RGOfA6DEAuQGwqI6SugFj8vzWQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=j70SRAte; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1935C606A330; Thu, 19 Nov 2026 03:58:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=j70SRAte Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AE2D1F000C4; Thu, 19 Nov 2026 03:58:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795060706; bh=JNSuWrBhylxlE+KO/JsdnTeonvRR0fzLsiUqGH7PtaM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=j70SRAteNfa74YnK+V8JamCcNuwAQJo7NkxNoVujg7h7VSDBbFN8vAtIq5sZy6RLs m1t0PHycprdCW4MaRvw8phicRjWzzHSvjOapE3nu9MsbTfdcJj0VGipW5352LQcnc1 0y19iH1EWWfr5n4qsLxog032NRJ+QKBDcM8ZU5Ic= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ping-Ke Shih , Kim Wooseok <5mghybrid@khu.ac.kr>, Sasha Levin Subject: [PATCH 5.10 1296/1848] wifi: rtl8xxxu: free RX skb when URB submission fails Date: Wed, 18 Nov 2026 15:55:34 +0100 Message-ID: <20261118150013.783053600@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kim Wooseok <5mghybrid@khu.ac.kr> [ Upstream commit 9f7edf4e8584c87e3c478c6dd87c08d51b5157c2 ] When usb_submit_urb() fails, rtl8xxxu_submit_rx_urb() unanchors the URB but leaves the newly allocated skb in urb.context. For ENOMEM/EAGAIN, the RX worker puts the request back on the pending list. The next submission allocates another skb and overwrites that pointer, leaking the previous buffer. Stopping before the retry also leaks it, because pending-list cleanup frees only the URB. Free the skb and clear urb.context in rtl8xxxu_submit_rx_urb() when submission fails. This keeps buffer allocation and failure cleanup in the same function, so a request returned for retry or teardown no longer owns an skb. Remove the corresponding cleanup from start and the RX worker; they only need to decide whether to retry or free the URB. Fixes: 26f1fad29ad9 ("New driver: rtl8xxxu (mac80211)") Reviewed-by: Ping-Ke Shih Assisted-by: GPT-6 Astra Signed-off-by: Kim Wooseok <5mghybrid@khu.ac.kr> Signed-off-by: Ping-Ke Shih Link: https://patch.msgid.link/20260921-codex-rtl-rx-v3-submit-v4-1-eeb09fe8f791@khu.ac.kr Signed-off-by: Sasha Levin --- .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index cdbb39b3986ec..e7a8e4a6b9a64 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -5199,7 +5199,6 @@ static void rtl8xxxu_rx_urb_work(struct work_struct *work) struct rtl8xxxu_priv *priv; struct rtl8xxxu_rx_urb *rx_urb, *tmp; struct list_head local; - struct sk_buff *skb; unsigned long flags; int ret; @@ -5231,8 +5230,6 @@ static void rtl8xxxu_rx_urb_work(struct work_struct *work) default: dev_warn(&priv->udev->dev, "failed to requeue urb with error %i\n", ret); - skb = (struct sk_buff *)rx_urb->urb.context; - dev_kfree_skb(skb); usb_free_urb(&rx_urb->urb); } } @@ -5810,8 +5807,11 @@ static int rtl8xxxu_submit_rx_urb(struct rtl8xxxu_priv *priv, skb_size, rtl8xxxu_rx_complete, skb); usb_anchor_urb(&rx_urb->urb, &priv->rx_anchor); ret = usb_submit_urb(&rx_urb->urb, GFP_ATOMIC); - if (ret) + if (ret) { usb_unanchor_urb(&rx_urb->urb); + dev_kfree_skb(skb); + rx_urb->urb.context = NULL; + } return ret; } @@ -6371,7 +6371,6 @@ static int rtl8xxxu_start(struct ieee80211_hw *hw) struct rtl8xxxu_priv *priv = hw->priv; struct rtl8xxxu_rx_urb *rx_urb; struct rtl8xxxu_tx_urb *tx_urb; - struct sk_buff *skb; unsigned long flags; int ret, i; @@ -6422,13 +6421,8 @@ static int rtl8xxxu_start(struct ieee80211_hw *hw) rx_urb->hw = hw; ret = rtl8xxxu_submit_rx_urb(priv, rx_urb); - if (ret) { - if (ret != -ENOMEM) { - skb = (struct sk_buff *)rx_urb->urb.context; - dev_kfree_skb(skb); - } + if (ret) rtl8xxxu_queue_rx_urb(priv, rx_urb); - } } schedule_delayed_work(&priv->ra_watchdog, 2 * HZ); -- 2.53.0