Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795051322; b=cTEH0ohfdLIDDyJGoLMt2LrW1llZt6t1rm4lsE0ZXc6/9Z90FPzWxFHApcuWRYtWtUV4 mJsetHN4AnYFgQImkCnQfZl44YUktbesNzRknG70xC/zlUXFBjr3+n6lzaE9zvieCMYRq 0c1CdrtiR8hANZixvpoR6FoDECVK+LX09TV09Aykf+KunGuU9OS8FbrTlcKUUFimFdoDk TQrjIzeUdsXmgLfuyTbAGP1LuyxI0h8eNfzMfNbj0jx/IHA6TrW/ixtqEiL8eVY/Nkxuq Xabc9mta2RZMG9QpvDy10PN8dXPXQgGmHEsLZ3J+zOZl42Dqb1k6NH8sXEQa7MW+sfg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795051322; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=+BPE448O/hjCZXrourjqgh8URrQyI794gRVhOe25hRA=; b=Ls5V9KLDVEaM/oS+1Zz1pGknAqET4JKdQ+s7H7LHfaXuQvph6lVr4p786ODrUfMldt16 RLPKTg/CBSK5+ul6KbQ34y5eAlNBYnG0r78+UdTyuoiRxH2D+vy4D+SxK1Q/w2qSqs0Xy 3zyd+0bdPxtefxpm44N0EcuDY4DQFnVqtkVhOyEdGCAlmHUWYK2vGcJ6QTyH9CztTpAc3 HwYO0Nip1+z/t7kVMTjCp4fKj/wHJrqmdLe3YmqP5RA6uTcg4vRyJSTASapzSBG/Yhfl2 pRX9FWhUAW/If32ScDEbJDPdwVgqRkh39tWWlDaZx3eZzCURyLzxBJQKE/10ckuuZ3g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=oB7O9r2V; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56744606A320; Thu, 19 Nov 2026 01:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=oB7O9r2V Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFAA51F000C4; Thu, 19 Nov 2026 01:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795051322; bh=+BPE448O/hjCZXrourjqgh8URrQyI794gRVhOe25hRA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=oB7O9r2V/impUOEktEiLQm+hlCSdfwKFwT7rQh9paBrfbDfb8BjMA/+4PqtkhlVSC yyH4uL3MRwMEu519Jzp6cQcrhljc8MufF0AC+lODH3j6urtDY1fG2e9bLgQFfVO53q l4ErO+7rfW5Ft8Nlxj/RiDrU4iYdlxYY0spvFIho= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Benjamin Marzinski , Yury Norov , Sasha Levin Subject: [PATCH 5.15 0130/2214] bitops: make the *_bit_le functions use unsigned long Date: Wed, 18 Nov 2026 15:30:06 +0100 Message-ID: <20261118150015.419855242@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Benjamin Marzinski [ Upstream commit 1c61b0a6e5c472737619f74f79c390363ee258df ] The *_bit_le functions use a signed integer for the bit number. However, the *_bit functions can use an unsigned long. This causes problems if there is a large bitmap and a bit number > 0x80000000 is passed in. Since that is a negative int, it will get sign extended to a long when getting passed to the *_bit function, turning it into a huge bit number. This usually ends up with the memory address wrapping around and the function accessing memory before the start of the bitmap. Avoid this by making the *_bit_le functions take an unsigned long. This can be triggered by faking an almost 4TB dm-mirror device, which uses bitmaps to track the mirror regions: $ dmsetup create bigzero --table '0 8589934590 zero' $ dmsetup create mymirror --table '0 8589934590 mirror core 2 2 nosync 2 /dev/mapper/bigzero 0 /dev/mapper/bigzero 0' This will access memory before the start of the sync_bits bitmap, and likely hit the guard page of the previously allocated clean_bits bitmap, causing a kernel panic with the old code. I looked and didn't see any crazy code using the signed int to intentionally try and access bits before some address within the bitmap. Signed-off-by: Benjamin Marzinski Signed-off-by: Yury Norov Signed-off-by: Sasha Levin --- include/asm-generic/bitops/le.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/include/asm-generic/bitops/le.h b/include/asm-generic/bitops/le.h index 5a28629cbf4d4..a46c45be38ad0 100644 --- a/include/asm-generic/bitops/le.h +++ b/include/asm-generic/bitops/le.h @@ -80,47 +80,47 @@ unsigned long find_next_bit_le(const void *addr, unsigned #error "Please fix " #endif -static inline int test_bit_le(int nr, const void *addr) +static inline int test_bit_le(unsigned long nr, const void *addr) { return test_bit(nr ^ BITOP_LE_SWIZZLE, addr); } -static inline void set_bit_le(int nr, void *addr) +static inline void set_bit_le(unsigned long nr, void *addr) { set_bit(nr ^ BITOP_LE_SWIZZLE, addr); } -static inline void clear_bit_le(int nr, void *addr) +static inline void clear_bit_le(unsigned long nr, void *addr) { clear_bit(nr ^ BITOP_LE_SWIZZLE, addr); } -static inline void __set_bit_le(int nr, void *addr) +static inline void __set_bit_le(unsigned long nr, void *addr) { __set_bit(nr ^ BITOP_LE_SWIZZLE, addr); } -static inline void __clear_bit_le(int nr, void *addr) +static inline void __clear_bit_le(unsigned long nr, void *addr) { __clear_bit(nr ^ BITOP_LE_SWIZZLE, addr); } -static inline int test_and_set_bit_le(int nr, void *addr) +static inline int test_and_set_bit_le(unsigned long nr, void *addr) { return test_and_set_bit(nr ^ BITOP_LE_SWIZZLE, addr); } -static inline int test_and_clear_bit_le(int nr, void *addr) +static inline int test_and_clear_bit_le(unsigned long nr, void *addr) { return test_and_clear_bit(nr ^ BITOP_LE_SWIZZLE, addr); } -static inline int __test_and_set_bit_le(int nr, void *addr) +static inline int __test_and_set_bit_le(unsigned long nr, void *addr) { return __test_and_set_bit(nr ^ BITOP_LE_SWIZZLE, addr); } -static inline int __test_and_clear_bit_le(int nr, void *addr) +static inline int __test_and_clear_bit_le(unsigned long nr, void *addr) { return __test_and_clear_bit(nr ^ BITOP_LE_SWIZZLE, addr); } -- 2.53.0