Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795060935; b=b6dAbukR2VdbMsZ7ZteNqpxD/Dk+JWvuN+H3SToBYPgG+fdAlKosP7o4Hy0N0yyKTOdz mFta09QIp6GUiV3WRAFp3Q9YynHSULiJr4COsOitZRzjS9MooFzFYY4NKmK4u0uWc6D6K YHUthQrt6bXT++bVrVP5Tmev+Jync11bifZex3vfRLpyAr+HYCFgWfhQpMW2og9org4LJ g4DYCzpB+nP9TKhkeEa3U3aMP+dnNGTTXNxuZ2oNgizynEw4IJFxZmvIdmglX3s50l8bB NvqVU9BrmS1o6Hg3oQB8eHwUtpxC3z3U8VrlC8EkH4SXhiV9LvpGddF5UXZZDp1l5MQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795060935; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=guioVm/wcYdRYRq9e99bt/w80GSdZYjQdS8HyzkkSlc=; b=u7xPWAVbHZWtBAPMmLmb59ft4ysGLaHqpSG7jZwYdDZxpdG81u5swOzF49X0mj30V1Z/ yg2+6ojnEsqM2vMPmgQsRHdhA9cfsYYoQOl/CAdb+bgNGlfVrhex3Iz2t8dortgFPjPu7 nEicycHBpJGmQR5MP9T6rnpvb0bKAluGxy/l2nAa/y3F/bXCe40DBJ+WBakeD/RB/dT+C jkUhQcVRdzXa9Caq4cl06p/56II3x4v8OOZp/p3N1UQ0uE4GNfhKRt7L8ISdzXikdQ8Ta FdoVxSZFsOK8f3928gmn++0uzzlJPs3DShTjEvCiQtDaG0AlVxDNGa8i7nHURLUKrMQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=zG9tHjHU; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D194A606A32A; Thu, 19 Nov 2026 04:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=zG9tHjHU Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37B781F000C4; Thu, 19 Nov 2026 04:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795060935; bh=guioVm/wcYdRYRq9e99bt/w80GSdZYjQdS8HyzkkSlc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=zG9tHjHUfBtjXZB7UzKNbIlaUwmAh0tPC02qUuhb5gBsZiIfD+SoHaEsAqUQaijzI NCl+l96gfvNEN6HXVCrcu8W+WU4lvez8GHwmzeraWL5ejSrCOr4AzM3fmW31VX3VQq TH6IgOZoL89HuOOjQliJ1j8IGFbITV7a+7ZWr+nk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ijae Kim , Myeonghun Pak , Lee Jones , Sasha Levin Subject: [PATCH 5.10 1335/1848] mfd: da9150: Balance IRQ wake on teardown Date: Wed, 18 Nov 2026 15:56:13 +0100 Message-ID: <20261118150015.615944070@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Myeonghun Pak [ Upstream commit ef464f82f3aecad4071af71074b2ceb77ffbb609 ] DA9150 enables IRQ wake after registering its regmap IRQ chip, but does not disable it on a later probe failure or driver removal. This leaves the wake depth elevated after the handler is removed, and repeated bind attempts can accumulate the imbalance. Remember whether enabling IRQ wake succeeded and balance only a successful call. Remove MFD children first so their nested IRQ users are gone, then disable wake before removing the regmap IRQ chip. Preserve the existing non-fatal behavior when IRQ wake cannot be enabled. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: b8fce55c09d3 ("mfd: Add support for DA9150 combined charger & fuel-gauge device") Assisted-by: LLM Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Link: https://patch.msgid.link/20260923021936.957065-1-mhun512@gmail.com Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/da9150-core.c | 8 ++++++-- include/linux/mfd/da9150/core.h | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/da9150-core.c b/drivers/mfd/da9150-core.c index 7f0aa1e8db96f..0bb32089173e9 100644 --- a/drivers/mfd/da9150-core.c +++ b/drivers/mfd/da9150-core.c @@ -451,7 +451,7 @@ static int da9150_probe(struct i2c_client *client, da9150->irq_base = regmap_irq_chip_get_base(da9150->regmap_irq_data); - enable_irq_wake(da9150->irq); + da9150->irq_wake_enabled = !enable_irq_wake(da9150->irq); ret = mfd_add_devices(da9150->dev, -1, da9150_devs, ARRAY_SIZE(da9150_devs), NULL, @@ -464,6 +464,8 @@ static int da9150_probe(struct i2c_client *client, return 0; mfd_fail: + if (da9150->irq_wake_enabled) + disable_irq_wake(da9150->irq); regmap_del_irq_chip(da9150->irq, da9150->regmap_irq_data); regmap_irq_fail: i2c_unregister_device(da9150->core_qif); @@ -475,8 +477,10 @@ static int da9150_remove(struct i2c_client *client) { struct da9150 *da9150 = i2c_get_clientdata(client); - regmap_del_irq_chip(da9150->irq, da9150->regmap_irq_data); mfd_remove_devices(da9150->dev); + if (da9150->irq_wake_enabled) + disable_irq_wake(da9150->irq); + regmap_del_irq_chip(da9150->irq, da9150->regmap_irq_data); i2c_unregister_device(da9150->core_qif); return 0; diff --git a/include/linux/mfd/da9150/core.h b/include/linux/mfd/da9150/core.h index d116d5f3ef561..369698036d1aa 100644 --- a/include/linux/mfd/da9150/core.h +++ b/include/linux/mfd/da9150/core.h @@ -65,6 +65,7 @@ struct da9150 { struct regmap_irq_chip_data *regmap_irq_data; int irq; int irq_base; + bool irq_wake_enabled; }; /* Device I/O - Query Interface for FG and standard register access */ -- 2.53.0