Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795060883; b=mqGxqy+cUGBxWASRP+Y2JPDpyI6UWVaDm3zx7LmXBjDc1GxSYccDZq9hsBRr/tozFU8d QHtdZ5CHuouudbrfz2tN9vwo/ZXPIea9gl/GGVRmWdVfOsmzGjqBKlxDlO6KMbiss7Xvk QnVHDvsuTU3uqPGAwLkEAohe1aDHHEdmzxWxl7VhqVMIp9m4/k1qHYaIx1i3y+ozj5GSS adD2xyFzV8r3eGexVhBChhCkV+fYN6epK4s1m+Jw6b9nnYhiPIKKl6f7qapz2BGk7GKx7 KV4V3acIQhABGLIsVbc/zl/j6+RIXGKQ0Yrikv+YwkvbwFL6Xfdou1/SpfcCvMKuiew== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795060883; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=Y/GEYQeVfp6vZdC8kiwZKfdDYK8+OX5gsTxlmgRJLNw=; b=2jwKEv838CVBbv/Kw2IYEPNR6Lvf2oS8xNHbzU/KT/tMiYN5hLttjvZ9ZaXusCDbu+bE +siweuhxZ+HlNAExMcV+GxzLpRdyvEUbyDc+OF6BRG0JUywnNRGawsTkKpHlyX+8lFuQV xjs3Ggs6dBOFlvniWqb52Irh46iIDckN3ZB7G2ppix9CqLvaPL7w0OiuUyErqDZFl7Lzo 8fmmVjZOOJfSTf/kiftFBqQKrwJt4dyKooks+JghTyTO9CmAQwo6fdx3xXTLsoIBkr2kf cXAGZVKFBaf7jdLsdGNmfEdiNNQsMN6laSzF6RU5c6Wm/4vrrRLUan2JTaYxtqiqr1A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=mg6A67Wm; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A9D8606A325; Thu, 19 Nov 2026 04:01:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=mg6A67Wm Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57D881F000C4; Thu, 19 Nov 2026 04:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795060882; bh=Y/GEYQeVfp6vZdC8kiwZKfdDYK8+OX5gsTxlmgRJLNw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mg6A67WmpPEBZr6dNlMSTsBVHr6ISojQG2gm9+zXbOZ5p8SLiywpPJhL0evGEEN8R LcW1ZSIovksZCnPFO22fy0G624SVM1vpX+Zmmf9sA6FnV3KfTqQyisfL0Bv2sS52Ww ybUg3Hgcln9kFpvnZjqf/gTgQhJiVuf5yca93uYY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Breno Leitao , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.10 1357/1848] ACPICA: Fix memory leak in acpi_ds_create_field() Date: Wed, 18 Nov 2026 15:56:35 +0100 Message-ID: <20261118150016.420882000@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Breno Leitao [ Upstream commit dbb3d99ee95c32711950850ddd33eb22a6042eb2 ] acpi_ds_create_field() allocates internal_pcc_buffer for operation regions in the PCC address space. The function runs once per field, so a second field on the same region overwrites the pointer and orphans the previous buffer. The matching ACPI_FREE() in acpi_ut_delete_internal_obj() only ever sees the last one. An arm64 platform whose SSDT declares regions with multiple fields each leaks two buffers at boot, as detected by kmemleak: unreferenced object 0xffff000051e65400 (size 192): comm "swapper/0", pid 1, jiffies 4294668436 backtrace (crc 0): __kmalloc_noprof acpi_ds_create_field acpi_ds_load2_end_op acpi_ds_exec_end_op acpi_ps_parse_loop acpi_ps_parse_aml acpi_ns_load_table acpi_load_tables acpi_init Do not allocate a region if it was previously allocated before, preserving the current design, but, not leaking memory. Fixes: aa6ec56b574d ("ACPICA: ACPI 6.3: add PCC operation region support for AML interpreter") Link: https://github.com/open-acpica/acpica/commit/c71849d476bb5f97ca1867849e893368e12a69e6 Signed-off-by: Breno Leitao [ rjw: Subject tweak, fixed the Fixes: tag ] Link: https://patch.msgid.link/20260925-acpica-pcc-field-leak-v2-1-e37008e715af@debian.org Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/acpica/dsfield.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/acpica/dsfield.c b/drivers/acpi/acpica/dsfield.c index fa768b3a989e9..9a06858b38491 100644 --- a/drivers/acpi/acpica/dsfield.c +++ b/drivers/acpi/acpica/dsfield.c @@ -522,7 +522,8 @@ acpi_ds_create_field(union acpi_parse_object *op, } if (info.region_node->object->region.space_id == - ACPI_ADR_SPACE_PLATFORM_COMM) { + ACPI_ADR_SPACE_PLATFORM_COMM && + !region_node->object->field.internal_pcc_buffer) { region_node->object->field.internal_pcc_buffer = ACPI_ALLOCATE_ZEROED(info.region_node->object->region. length); -- 2.53.0