Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795061151; b=3NapNBAgT67qQdIz/W74nvx8vj0MxlWFRzY1zHGw0Dtpb5qu/wQSJBQmOkEWfL8Y1RUT CTab1lC/jOi5A6TpAhOWHZhjeftPbCKskwGafFmpiaOs9+/Rk0HdC91UiuL8zOB1lHSh0 96nB+tyhfeyET5Zpmne8m7KTLF9F04qu6h6C9oA+LqoBOLArCw3/O5jmS+c9uCBARwSw7 bCsM/O5rxn7DH0oIotagSp3UJKM1zbJgn1xcF36YkLJx7gOWMzzxi/Q6pcOoAK3G0cK3F vLFLlxtNklIZfq9P26pXEjry5Rjmxc1NDBg34hOsMBJlb+sLQilBKccgnTWSabMmB0g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795061151; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=JRWEHAYdHOeJGiz/SZ5mJr52blzbFqYOoxVweG/aKmo=; b=svCri3wV84VqKTWbohtKV7jcnDlgFe84sEYXA+JPqxqMDzlLddCpkR6nMWoYhv9MbgYF QgHf13m71g6czckim1F8jmNtoZ0oY2l45dui6cPyZ02HHz18z8pmeI3kprOHwZpkXgNpk Lya+AwSLGBLUoh2Y+JCFKbAufSkQYMjW6IIkru2xSQcsYKZDvL8umnFu2tsl7Z03KQCDP yQIrP5MUYRyBJd+6PcW5mNg8tKUG5n7LuIejf1F5Xm/rX/d6ZsF5lejsrvFLd92or8715 HtNldUyqcjhwMbi0RDzocVbd3Kffb3PPpcTKLEiAbTS10xyrxCKwcFdx0kEZnKck4DQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=enVGt9Wf; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19087606A326; Thu, 19 Nov 2026 04:05:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=enVGt9Wf Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6977D1F000C5; Thu, 19 Nov 2026 04:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795061151; bh=JRWEHAYdHOeJGiz/SZ5mJr52blzbFqYOoxVweG/aKmo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=enVGt9Wf8CEs3v/QfzbW+GYNCh5uoJtdShqMS87c5l3UjrFCobf8YnWwuT5osMqqe 5Gz6td3Ti2pUbXcIY41JIU6s6NIvftY96zE4Kv9EB0p9xA8M/YUIFsXIrPlZEJvloL KCU7s46cppcv/8cm6+OoFPNOPAcbxQsh+E4X39KI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+6a132745caefcf42cb0d@syzkaller.appspotmail.com, Li Youhong , Yu Kuai , Sasha Levin Subject: [PATCH 5.10 1449/1848] md/raid5: drain released_stripes before destroying the cache Date: Wed, 18 Nov 2026 15:58:07 +0100 Message-ID: <20261118150020.093288064@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Li Youhong [ Upstream commit af560e357a81964544be40c549e241b032ef7565 ] grow_one_stripe() calls raid5_release_stripe() for each new stripe. When mddev->thread is already set, that queues the stripe on conf->released_stripes and wakes the thread. Only raid5d moves that list onto inactive_list. Takeover calls setup_conf() while mddev->thread still belongs to the previous personality, so those stripes stay on released_stripes. If setup_conf() then fails, shrink_stripes() only frees inactive_list and kmem_cache_destroy() warns that objects remain. Move stripes still queued on released_stripes onto inactive_list before shrink_stripes() frees them. Fixes: 773ca82fa1ee ("raid5: make release_stripe lockless") Reported-by: syzbot+6a132745caefcf42cb0d@syzkaller.appspotmail.com Closes: https://lore.kernel.org/linux-raid/6ab6b743.7eec07f4.c25c.0006.GAE@google.com/T/#t Signed-off-by: Li Youhong Link: https://patch.msgid.link/20260929083916.50620-1-dayou5941@163.com Signed-off-by: Yu Kuai Signed-off-by: Sasha Levin --- drivers/md/raid5.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 9f403ac87de01..09a7640529d86 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -2653,6 +2653,37 @@ static int drop_one_stripe(struct r5conf *conf) static void shrink_stripes(struct r5conf *conf) { + struct list_head temp[NR_STRIPE_HASH_LOCKS]; + int i; + + /* + * grow_one_stripe() parks new stripes on released_stripes when + * mddev->thread is already set. Takeover leaves the previous + * personality's thread there, so raid5d never moves them to + * inactive_list. Drain them before the cache is destroyed. + * slab_cache is assigned only after device_lock and the hash + * lists exist; earlier abort paths have nothing to drain. + */ + if (conf->slab_cache) { + for (i = 0; i < NR_STRIPE_HASH_LOCKS; i++) + INIT_LIST_HEAD(&temp[i]); + + spin_lock_irq(&conf->device_lock); + release_stripe_list(conf, temp); + spin_unlock_irq(&conf->device_lock); + + for (i = 0; i < NR_STRIPE_HASH_LOCKS; i++) { + if (list_empty(&temp[i])) + continue; + spin_lock_irq(conf->hash_locks + i); + if (list_empty(conf->inactive_list + i)) + atomic_dec(&conf->empty_inactive_list_nr); + list_splice_tail_init(&temp[i], + conf->inactive_list + i); + spin_unlock_irq(conf->hash_locks + i); + } + } + while (conf->max_nr_stripes && drop_one_stripe(conf)) ; -- 2.53.0