Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795061440; b=i2tdpQiIjALHeTubat0DVRaH2YM28endnNjspMABDIfTYiZGrZaWyBYttMSkhrxHpmE9 EhllV9k4jLnh64E6RGQ7AWgCtLdpdXfHseM7aSxOK/wenkJ8WbCWs4sGk3v1XTJpCcmdK pRt3rHZqLheScQ4iGfR0u6Ksd1zIBjrz6EL8ZBijVCDIGCAfO6JdyIQT86N7TTUwHs8cl /EUHUQrS14kGMePs1KEGhGSBoDG8bI5AKx4KdY9megPAUzTT0Kvf8HBopBCKXUcdFsAIy AZiy9kLvpxpAi32BEnSF2O2X3KnyUZtGzNdxFNgR9nnlasP5UDU4Uszc0Mn8R6BgbXw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795061440; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=VY1Zet4KA5R3lf6AVr2osUOSjSYG+IlpAv0swT3MrDk=; b=1dYkxU07WPZLrKnHgExH2VGhMH+M6nNfXmru2jt3GSzaUgEnGdqMx3M3EVtIMrrob5mG LX7e7EbJOCfW2wyQ0Q7ETk+eHZnsn9DtsZQxdo3grPEs51fjT1uq4dsDF05g6yLMNlgjf nrdHI+gUSPe+P7S/8hk7l/dcvnwAkznyw5iWio/MNRxXLmm2YMvizdhAxC6/hLKuo9Wrp bIrKyQAr2YXcaJfexXL05GOzVh1hLZni3Ax0g4AWr9O83jS52dTAKPK93RBIvzyAuZUP3 RbQLMFalxodqz8WMpNrqaB7aihM2NOW4d9Xa6f/377AlOlNYeNl2kTd7lnDb3jUFdJQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=zqfM2ppL; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E698606A326; Thu, 19 Nov 2026 04:10:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=zqfM2ppL Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7883A1F000C4; Thu, 19 Nov 2026 04:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795061440; bh=VY1Zet4KA5R3lf6AVr2osUOSjSYG+IlpAv0swT3MrDk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=zqfM2ppL/vHJZ0mIrFvBWhVJWsJJy/1WbA3ajcL5fiqkaic/RZnDsyGuXw0hcghjE 8a/mQzWWieywfPrv68drV5Kd0zbsDgDoVpTjpEUgXIMWKw9kmzSu6T4jMJFtV6Yqwa UOrl88TL6A5PIcG+XoiHLqTtgTRwRKYt7Ilmntk8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marc Kleine-Budde , Jonas Rebmann , Mark Brown , Sasha Levin Subject: [PATCH 5.10 1512/1848] spi: spi-sun4i: sun4i_spi_transfer_one(): fix transfers for SUN4I_FIFO_DEPTH Date: Wed, 18 Nov 2026 15:59:10 +0100 Message-ID: <20261118150022.604657070@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marc Kleine-Budde [ Upstream commit f3ce7a3ca82bd9cda9ef61250aeff65fe6b44809 ] In commit 6d9fe44bd73d ("spi: sun4i: fix FIFO limit"), the TX-FIFO is filled max to SUN4I_FIFO_DEPTH - 1 (= 63) bytes to work around timeouts observed on A10s SoCs. Commit 196737912da5 ("spi: sun4i: Allow transfers larger than FIFO size") added support for transfers larger than the FIFO size. But this commit only enabled the TX-FIFO empty interrupt for transfers larger than the FIFO (= 64) bytes. This breaks transfers with exactly 64 bytes: the TX-FIFO is only filled with 63 bytes but the interrupt to refill the FIFO is not triggered. The problem can be reproduced with the following command: | spidev_test -D /dev/spidev0.1 -S 64 -s 20000000 -I 1 | | [ 7797.548745] spi_master spi0: spi0.1: timeout transferring 64 bytes@20000000Hz for 110(100)ms | [ 7797.557237] spidev spi0.1: SPI transfer failed: -110 | [ 7797.562308] spi_master spi0: failed to transfer one message from queue | [ 7797.568936] spi_master spi0: noqueue transfer failed To fix the problem enable the TX-FIFO interrupt if the total TX length is larger than SUN4I_FIFO_DEPTH - 1 (= 63) bytes. Fixes: 196737912da5 ("spi: sun4i: Allow transfers larger than FIFO size") Signed-off-by: Marc Kleine-Budde Signed-off-by: Jonas Rebmann Link: https://patch.msgid.link/20260914-spi-sun4i-fixes-v3-1-9fe919d5cecf@pengutronix.de Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-sun4i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index ab99cc7438652..3e2ed10510398 100644 --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -321,7 +321,7 @@ static int sun4i_spi_transfer_one(struct spi_master *master, sun4i_spi_enable_interrupt(sspi, SUN4I_INT_CTL_TC | SUN4I_INT_CTL_RF_F34); /* Only enable Tx FIFO interrupt if we really need it */ - if (tx_len > SUN4I_FIFO_DEPTH) + if (tx_len > SUN4I_FIFO_DEPTH - 1) sun4i_spi_enable_interrupt(sspi, SUN4I_INT_CTL_TF_E34); /* Start the transfer */ -- 2.53.0