Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795061400; b=fTtQ0ra6pcF3HuzBUv9gRNlqlcPZ5ORDLeAEU1VMwNg3c+l3gOxYSr7W3YiC5W0zoeM7 1xoWs9TGRf+Zz70s+cuupwa4DufXlvoZtxXOKPJ5SZN+9+qUD/0CH7pZyFr9+tTzC+WPs rLpDyntSh1NZZJxS2RyOm1CgENX7x2ERAcbmpwwkFOKFtYUbrg0YdynJxtbWVHBusu/Gw BvZcvKwn/xhvlZjyqANwKLimqfv0h7xvui3zWLlWvmwfGFvrcmcvxt4nR3jtBxNn2Yi+t UCBSKaliDHRHfAUTQUYUQP5qfMM0BjGCzNXWhgxGupzDzFavT2bTUqsA9IHACeFftyQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795061400; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=OjBGY0RHCJuLz4za9IlDuyMc+pGqfyn1sfpZdXUQQ48=; b=tyxnRNghtFsnOSxRsrrJ8/a1sJHc5zXc7cFvr6VNMfnkxaDP+jScCNJeRSV6b6ovY2im Nt6lTaTC3+OEQcX0ZmrmqHXher1eNPCAwT5aHgiJziis/WjNJJtEMUTMAgYH4x8k5R6Wj C/jpWw929DeE/C4OjsoAusfNvGclaNDtr8QgYLdnp37xEMtzQ+8k2cVn5y8bnJNh8wYTc H6qLKXxcY/v0Io2Aq/5wmwT6pjG2PMDEkymSCTWRxsnW5bS5zXAr0k87P9iYe2nHG+pgA VWXtu4aMQdHMXlMcEbf+RV591KUlkQj8hvovoY+DxkR4bkrjpUpty2/ViS6w8smZsjA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=jHwYOoZo; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA057606A326; Thu, 19 Nov 2026 04:09:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=jHwYOoZo Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A8371F000C4; Thu, 19 Nov 2026 04:09:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795061399; bh=OjBGY0RHCJuLz4za9IlDuyMc+pGqfyn1sfpZdXUQQ48=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jHwYOoZoq5NSqhyPVVzcQatV+ORE+89UVMYvt8r2AM3EBbr/PcPXeyrvMp5m4WmyU YTXDJcQseLv5J5nB/pNVnPN7zlmyRu3k7sBHqhXfEVMWFLfPH195JC6mm2bx9Vg51B DaZB6CwnuuN1RIa/HYUMg/nwgaJRGq2nv1nAXVAs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Takashi Iwai , Sasha Levin Subject: [PATCH 5.10 1538/1848] ALSA: usb-audio: Check mixer matrix size for UAC2/3 at parsing Date: Wed, 18 Nov 2026 15:59:36 +0100 Message-ID: <20261118150023.894503809@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Iwai [ Upstream commit 22185ffd7b31885d03fdeb20055a8707779a70f9 ] The matrix of input/output channels specified in a UAC2/3 mixer unit must fit to the upper limit 256. Add a sanity check and returns an error if an invalid size is detected. Link: https://lore.kernel.org/d46fcac6-bd7e-4fc4-95e1-4e8d39f92ad3@zipdox.net Signed-off-by: Takashi Iwai Link: https://patch.msgid.link/20260930155356.348608-2-tiwai@suse.de Stable-dep-of: c01fb2ed90c0 ("ALSA: usb-audio: Fix invalid UAC2/3 mixer unit matrix evaluation") Signed-off-by: Sasha Levin --- sound/usb/mixer.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 48178272bf422..a375578aa0aef 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -2195,6 +2195,16 @@ static int parse_audio_mixer_unit(struct mixer_build *state, int unitid, num_outs = err; input_pins = desc->bNrInPins; + if (state->mixer->protocol == UAC_VERSION_2 || + state->mixer->protocol == UAC_VERSION_3) { + if (input_pins * num_outs > 256) { + usb_audio_err(state->chip, + "invalid channels for MIXER UNIT %d: input=%d, output=%d\n", + unitid, input_pins, num_outs); + return -EINVAL; + } + } + num_ins = 0; ich = 0; for (pin = 0; pin < input_pins; pin++) { -- 2.53.0