Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795061573; b=lbiSOf4d/sUPbHDo744kC/fdEvpXKe1PUplovmPJEiB4Jvi9Wkj83NKL/KU8anUiqE8O JDPxatCE8WWzLgfno/P9EZrKH2RtOrEDjm6NIrT9vZzzl5KvaOrXg849lwC3/bXDBMjmY 5eNmQWjiZDZwRyLnaDMZ68s/9DQJ+Soe5z1356V6cySQ9Qv78wH191gMT7dFi669fXh0r k2cYo3qqOgsZ1izN8nHF3Vd6Z0OHUDe5+NxDmCeCfNAz8Di6ogtOts0RSxVgznhDwvek/ MzB1TU8GsKzIkhFCyj7aPyF3gJOU2JsYxTy3SuDCzCgABB5YcNQC0tmhxJogg8lGUbQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795061573; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=zvFpo7lUwq5Rn/1I4V31+Uj1rq+Q7fDFe5acR79OI9k=; b=1LPo4J404mI/OSHtFCbXjnqP0/K4GXXaYYxqOmSHajNu8Jx2NQLnyx93yrXkzHB9lyO7 fZMoyYov7E73OjJOn5bz1KoAdFwYqQaXSys1bCwyadLVVxW7gDkDt3xsiCh+jh5qFIQOx edcAWO08CsjtJotTub6e2uMYi/BUYIkopv81FwVVgMrtTjo6Hw7pOdpvk5WV+3LBhkgUq FiqkbNfpqzcJhHvP4wZsai138/Qw8ovgq3E7VIdc4NFGMUv8WSDuZJB3RlgiCTv4wyKn2 Ze+mb1av8sYjV2PL63kZWmzWGPNVd4vQy2STLHYvjx5lc5x9LQUiwTqLIQxBleZ2VuA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=A5hLWiUL; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E3FB60A2609; Thu, 19 Nov 2026 04:12:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=A5hLWiUL Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC6DC1F000CC; Thu, 19 Nov 2026 04:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795061573; bh=zvFpo7lUwq5Rn/1I4V31+Uj1rq+Q7fDFe5acR79OI9k=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=A5hLWiULyrDKcFBimUQfNfSCeZcwhimZkIE9A7CBtXIHUCbEhZj5dPLlVQDChbqI2 VXx0m9oGOzaUfTYOGNl4cVlD8y5jKXrluTTf6X+NXjiWAcG4U8wgTnTwP0+TDdHZ/R cavhyetS9gMUSQZaj20+0XcVP+whutW9MbcenjPg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Antoni Pokusinski , Alexandre Belloni , Sasha Levin Subject: [PATCH 5.10 1559/1848] rtc: abx80x: properly handle shared IRQs Date: Wed, 18 Nov 2026 15:59:57 +0100 Message-ID: <20261118150024.875164864@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Antoni Pokusinski [ Upstream commit 632916c7bde35495f2f6776d8e335c3ec6e306ec ] The abx80x RTC driver registers its interrupt handler with IRQF_SHARED, but the handler always returned IRQ_HANDLED and cleared the status register even when no interrupt source from the RTC was active. This could cause the driver to claim interrupts belonging to other devices sharing the same IRQ line and could also clear unrelated status bits in the RTC status register. Only handle the interrupt when the alarm or watchdog flags are set, and clear only those interrupt status bits that were handled. Return IRQ_NONE when the interrupt was not generated by the RTC. Fixes: 718a820a303c ("rtc: abx80x: add alarm support") Signed-off-by: Antoni Pokusinski Link: https://patch.msgid.link/20260916205138.16771-5-apokusinski01@gmail.com Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-abx80x.c | 52 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 50 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c index c95fdbadbcca7..439b5a76ec2f7 100644 --- a/drivers/rtc/rtc-abx80x.c +++ b/drivers/rtc/rtc-abx80x.c @@ -48,12 +48,18 @@ #define ABX8XX_CTRL2_RSVD BIT(5) #define ABX8XX_REG_IRQ 0x12 +#define ABX8XX_IRQ_EX1E BIT(0) +#define ABX8XX_IRQ_EX2E BIT(1) #define ABX8XX_IRQ_AIE BIT(2) +#define ABX8XX_IRQ_TIE BIT(3) +#define ABX8XX_IRQ_BLIE BIT(4) #define ABX8XX_IRQ_IM_1_4 (0x3 << 5) #define ABX8XX_REG_CD_TIMER_CTL 0x18 #define ABX8XX_REG_OSC 0x1c +#define ABX8XX_OSC_ACIE BIT(0) +#define ABX8XX_OSC_OFIE BIT(1) #define ABX8XX_OSC_FOS BIT(3) #define ABX8XX_OSC_BOS BIT(4) #define ABX8XX_OSC_ACAL_512 BIT(5) @@ -249,6 +255,7 @@ static irqreturn_t abx80x_handle_irq(int irq, void *dev_id) struct i2c_client *client = dev_id; struct abx80x_priv *priv = i2c_get_clientdata(client); struct rtc_device *rtc = priv->rtc; + unsigned int status_flags_clear; int status; status = i2c_smbus_read_byte_data(client, ABX8XX_REG_STATUS); @@ -265,9 +272,15 @@ static irqreturn_t abx80x_handle_irq(int irq, void *dev_id) if (status & ABX8XX_STATUS_WDT) dev_alert(&client->dev, "watchdog timeout interrupt.\n"); - i2c_smbus_write_byte_data(client, ABX8XX_REG_STATUS, 0); + status_flags_clear = status & (ABX8XX_STATUS_AF | ABX8XX_STATUS_WDT); - return IRQ_HANDLED; + if (status_flags_clear) { + i2c_smbus_write_byte_data(client, ABX8XX_REG_STATUS, + status & ~status_flags_clear); + return IRQ_HANDLED; + } + + return IRQ_NONE; } static int abx80x_read_alarm(struct device *dev, struct rtc_wkalrm *t) @@ -821,6 +834,41 @@ static int abx80x_probe(struct i2c_client *client, i2c_set_clientdata(client, priv); + /* Disable unused interrupts */ + data = i2c_smbus_read_byte_data(client, ABX8XX_REG_IRQ); + if (data < 0) { + dev_err(&client->dev, "Unable to read irq register\n"); + return -EIO; + } + + err = i2c_smbus_write_byte_data(client, ABX8XX_REG_IRQ, + data & ~(ABX8XX_IRQ_EX1E | + ABX8XX_IRQ_EX2E | + ABX8XX_IRQ_TIE | + ABX8XX_IRQ_BLIE)); + if (err < 0) { + dev_err(&client->dev, "Unable to write irq register\n"); + return -EIO; + } + + data = i2c_smbus_read_byte_data(client, ABX8XX_REG_OSC); + if (data < 0) { + dev_err(&client->dev, "Unable to read Oscillator Control register\n"); + return -EIO; + } + + /* Unlock write access to Oscillator Control Register */ + if (abx80x_write_config_key(client, ABX8XX_CFG_KEY_OSC) < 0) + return -EIO; + + err = i2c_smbus_write_byte_data(client, ABX8XX_REG_OSC, + data & ~(ABX8XX_OSC_ACIE | + ABX8XX_OSC_OFIE)); + if (err < 0) { + dev_err(&client->dev, "Unable to write Oscillator Control register\n"); + return -EIO; + } + if (abx80x_caps[part].has_wdog) { err = abx80x_setup_watchdog(priv); if (err) -- 2.53.0