Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795061560; b=RcNS3OtXfilL/lIFagSKqvcSuSNxFi+2jnRyeJDPewUxY9ytQdDDjQl4UhypPkTVHLGW kLOIN1BIxDSb9iiumasXLJIu1mGJA4/IGi6vkUxHrQySYCCStb4VTtHq2I9lT6haJv9Q3 rbzPKkJB2JhKD8URRtPoFuJIkeI/b987Mw9AcmpGVRqrxOsM9AjU+sfXnVFqyn+rM+QPB PxvaT/Tx86XKHxCU1AdUgoqAdNEjoSmptYTfGrjXozU1Zy16am6gqtoejfFoSM6h8DnPP +H5q4rpqpga/it9zvVDxeyjjc8HUUcBq/XgUaoN3uOcrRSmJUURSjftDHkeh/yvTk2Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795061560; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=ISLOuqiYa6QM1VfwpJZc5QGOWnbDFnpLDKRIrY81/8Q=; b=Ntp8OBzgnVvlaPitcu9m9kl4RQwfZpKZULUgU1TZPEFhDv8xSguLwz/9HgiO3FC+N191 OZXWg7Kz2CI8GZY5z6MEc4dZxjbmyF/X7F6RnrAjvMbuNzle+qew0OcQoGSTF57zOP02B 8eKwb5jULngV4sRa2RIV96Pf25OHRcxGkYJ5/PeEJveVtBECZP85h7JbHx7/XCgJHKV+7 cMdhPUSaL/GuX3o1bPHAsi17SSN6TXM148czbKlpEqO9RxX9TabDBTxYExQ4BsUObxExN d6VAe5aRUw0/IqgT7HAZFGt+rqnJRuH0Cd63NaNu4hHn/6UjCYWZbIkvardGUlmqJag== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=IlakIAKr; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B8B2606A33B; Thu, 19 Nov 2026 04:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=IlakIAKr Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17ED81F000C4; Thu, 19 Nov 2026 04:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795061559; bh=ISLOuqiYa6QM1VfwpJZc5QGOWnbDFnpLDKRIrY81/8Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IlakIAKr+zQhse8eFwsa6IB1A+uASpYt9qGzayiycPkrJGEk0SMEYubEW9W5pCz4q FjciHT6j3fXftq9nwv3+cwQNhFlzfJuZLl/Gqel67MDTLOx5y9CqnOxjmbtI2ZhKqq lKMJzAJZKkIs+1MMGeDZg0CM/x3EW6Fpwhn/5tYg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yogesh Gaur , Sasha Levin Subject: [PATCH 5.10 1594/1848] comedi: ni_atmio16d: validate the IRQ supplied by userspace Date: Wed, 18 Nov 2026 16:00:32 +0100 Message-ID: <20261118150026.228904364@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yogesh Gaur [ Upstream commit 71424db0ebb5f484fa3f386910f8ce9da95b8b2e ] comedi boards are configured through the COMEDI_DEVCONFIG ioctl, so it->options[1] is a number chosen by userspace. ni_atmio16d passes it to request_irq() without checking it first, which lets an interrupt owned by another irqdomain -- a PCI device's IO-APIC GSI, for instance -- be claimed for this board. When the owner of that interrupt is later released the descriptor is freed while this driver's handler is still installed on it. The driver already documents which interrupts the board can assert -- "0 == no irq; or 3,4,5,6,7,9,10,11,12,14,15" -- so use exactly that set rather than the whole ISA range. Bound the value before requesting it, as das16m1.c already does. An out-of-range value is ignored rather than rejected, so the board still attaches without interrupt support, exactly as it does today when request_irq() fails. Fixes: 2323b276308a ("Staging: comedi: add ni_at_atmio16d driver") Assisted-by: LLM Signed-off-by: Yogesh Gaur Link: https://patch.msgid.link/20260909104848.1763-3-yogeshgaur.83@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/comedi/drivers/ni_atmio16d.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio16d.c b/drivers/staging/comedi/drivers/ni_atmio16d.c index 3b2e714b47249..897413fb86ac7 100644 --- a/drivers/staging/comedi/drivers/ni_atmio16d.c +++ b/drivers/staging/comedi/drivers/ni_atmio16d.c @@ -593,7 +593,9 @@ static int atmio16d_attach(struct comedi_device *dev, /* reset the atmio16d hardware */ reset_atmio16d(dev); - if (it->options[1]) { + /* only irqs 3, 4, 5, 6, 7, 9, 10, 11, 12, 14, and 15 are valid */ + if (it->options[1] >= 3 && it->options[1] <= 15 && + (1 << it->options[1]) & 0xdef8) { ret = request_irq(it->options[1], atmio16d_interrupt, 0, dev->board_name, dev); if (ret == 0) -- 2.53.0