Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795061668; b=f7PUhmyqZdNRWO7W5aBL8IcfV2kPcYhGegjdM41+5sfSq5qaooa/MVaIoFnwbXWKjJa/ 5mk2DXVYLY4KS/EA4pSqoaFmL30aykE1lArJY6RU4WCg0QE/dx1xk8RrV0ETQiD38EVDD 7uRk07H4EQeE7vACfrMZsENj2efm0nsg1glGuSk88fOHgusXdPzsXUul4lqpZoscFj1lg 6jETBK+Co8t/t/ZCX8LDRB1fba8hrditjcj6MfHTgR9pzMSCIpqdusNepTMN7CSIDOPYy y+V5ZCtBsiiLvYFp7SnMO0gy5xZ7FOfRFuwvko9a/fWw5D+6iohHlKrOYHTVZAy9KgQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795061668; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=lRHfO8GieyxDPjdAWZ72qeR6Dg19cesBUs6pAPPumIA=; b=sMulsa8dom5GrgbZEoa9G3VULuKDw+shbsno6HiItB86GsVugk+itoOQ9FJARTUt0156 F5z9YKcQ+9Q0y0mazRHLt03/lZSZ6YP9dVwGhA2HXeCpTj1V+i+CsiuRAKRyQeIw3XiCJ eNcI2UKJBa/a/NbDYEgL/inaeCSWnLM6HvUVPc062mHeJ2xb7sy7n6+dsaRC/6gbujaDz QUyBxSSlMlzWoC1sYQ+FRd+l/eW4VBfHRFdwhU2RT6/RpaYqF+mRUI+7fEHqKu8vdGVKH EpfdZ3/dno12QKTpYIN/FbpnK8pDNnaM/KCDjU908LpiMkF33CoBocph7kx1x0/ZIaA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=WHbKbcYm; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A1B3606A335; Thu, 19 Nov 2026 04:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=WHbKbcYm Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BA151F000C5; Thu, 19 Nov 2026 04:14:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795061668; bh=lRHfO8GieyxDPjdAWZ72qeR6Dg19cesBUs6pAPPumIA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=WHbKbcYmpAi9JQzKB+bvA1mz6OL0hOP4ZytnPHPlI+Dxuba2FS/VCkz0x3BUUai7P vpiI3hIJIgbY2gCobCSXDmciboxZWWP654otZ50S+KmkyHDStTtkv69Ypy2futWhZz TM2oo6cfPJaOPMBnMHrS0TqvMlppFguRV/cpj1bo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, HyeongJun An , Charles Keepax , Mark Brown , Sasha Levin Subject: [PATCH 5.10 1634/1848] ASoC: codecs: wm8991: Fix definition of right input PGA controls Date: Wed, 18 Nov 2026 16:01:12 +0100 Message-ID: <20261118150027.979463958@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: HyeongJun An [ Upstream commit 2dfecdc25d4937a36675c0c36ee0addc99e1e7f9 ] The right input PGA boost (R12MNBST, R34MNBST) and routing (R12MNB, R34MNB) bits are in Input Mixer4 (R42), not in Input Mixer3 (R41), where these controls write the left channel bits. Fixes: 203db220718c ("ASoC: WM8991: Add initial WM8991 driver") Assisted-by: Claude:claude-opus-5-5 Signed-off-by: HyeongJun An Reviewed-by: Charles Keepax Link: https://patch.msgid.link/5c0196e45dff1769682d885fc26e613648e05436.1791959026.git.sammiee5311@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/wm8991.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wm8991.c b/sound/soc/codecs/wm8991.c index 16bc8609d0d20..79f7a64845f78 100644 --- a/sound/soc/codecs/wm8991.c +++ b/sound/soc/codecs/wm8991.c @@ -169,8 +169,8 @@ static const struct snd_kcontrol_new wm8991_snd_controls[] = { SOC_SINGLE("LIN12 PGA Boost", WM8991_INPUT_MIXER3, WM8991_L12MNBST_BIT, 1, 0), SOC_SINGLE("LIN34 PGA Boost", WM8991_INPUT_MIXER3, WM8991_L34MNBST_BIT, 1, 0), /* INMIXR */ - SOC_SINGLE("RIN12 PGA Boost", WM8991_INPUT_MIXER3, WM8991_R12MNBST_BIT, 1, 0), - SOC_SINGLE("RIN34 PGA Boost", WM8991_INPUT_MIXER3, WM8991_R34MNBST_BIT, 1, 0), + SOC_SINGLE("RIN12 PGA Boost", WM8991_INPUT_MIXER4, WM8991_R12MNBST_BIT, 1, 0), + SOC_SINGLE("RIN34 PGA Boost", WM8991_INPUT_MIXER4, WM8991_R34MNBST_BIT, 1, 0), /* LOMIX */ SOC_SINGLE_TLV("LOMIX LIN3 Bypass Volume", WM8991_OUTPUT_MIXER3, @@ -446,9 +446,9 @@ static const struct snd_kcontrol_new wm8991_dapm_inmixr_controls[] = { WM8991_RDBVOL_SHIFT, WM8991_RDBVOL_MASK, 0, in_mix_tlv), SOC_DAPM_SINGLE_TLV("RIN2 Volume", WM8991_INPUT_MIXER6, WM8991_RI2BVOL_SHIFT, 7, 0, in_mix_tlv), - SOC_DAPM_SINGLE("RINPGA12 Switch", WM8991_INPUT_MIXER3, WM8991_L12MNB_BIT, + SOC_DAPM_SINGLE("RINPGA12 Switch", WM8991_INPUT_MIXER4, WM8991_R12MNB_BIT, 1, 0), - SOC_DAPM_SINGLE("RINPGA34 Switch", WM8991_INPUT_MIXER3, WM8991_L34MNB_BIT, + SOC_DAPM_SINGLE("RINPGA34 Switch", WM8991_INPUT_MIXER4, WM8991_R34MNB_BIT, 1, 0), }; -- 2.53.0