Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795061797; b=er8vWAKhuLiUXhKZJx/q+T9wtVcqReKDz6Cor46CaQY3M+9Q1HkHlPFFQPMdyyNqwTTT lOts2jgDOsca1fnn7vQ4m+gzn75YGXRYcMp+lFKBAZtzP6Afccv2d7RpSY4tpETPDAD0a dfKr21qGquY5SWCD5jpWG0LhwQihDfG91jxzAX/HqW6GBmezg2TL+tOW9y6hT9T7Be8qg vAfNVHQsDworvTi2Ct9XFfZ3pX5oPg7JxoooAPgBDZWWPuBWzF/HWqqA5KSelT9zW1yzZ KFBd4gA/PSvInNCSCbEu4jaJk4jpSNRV9vzT3EUXg4Gtq8gcmRQ6UXWBNNA74cNoHug== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795061797; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=KuQe8vuij9ZdAt+TV7VFeUvqfsequgweejKcbolKn60=; b=zW5IRIzEG4GsCSpzSuuOSJZT0B75OKM7HfB6Hkw7bZjNZZbjtir6PmM9TEQ8Ee/gNKkI UGbHWJ3IFprdIH2ktQZqh7/Gim+cbdrVapei2pYsHC5gzid4AR0RIlOs+LVbTvUwo5a9m 2GORe1v/S/5qz5CQp97ptu2m03Ot8kgChdFycVx1em8fAZZobqW3Sn8R/uEyjQkzBWXwt qPa+4kus0lWEQAb+SX3/Br6X4Vhd/gnQ1EeP8CssAmOSPdJo9nTgHvJkbe452CYfiaUqo adruWBweTib/KTdeBl/Yv6VZBxad86qTKQ07QptiCvfzJAAz2hfLCDAtetcFPDVmLNA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=FyjAaInd; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32E83606A325; Thu, 19 Nov 2026 04:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=FyjAaInd Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8165D1F000C5; Thu, 19 Nov 2026 04:16:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795061797; bh=KuQe8vuij9ZdAt+TV7VFeUvqfsequgweejKcbolKn60=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FyjAaInd9ri6YWnl2rUWXloOsCDYwdSxcq4Asf6jCjl9706ADsfBsztBtc8um7fl8 uXk/hpZ2oG+CXvwzpKLPPRNKOMfTfKmff/yJUuALf4lC5/JZDyWPo3gbk3QSqgRtVA +IaPh3RqlEeGUZFvorSRoEWgsJlaOQLhKSL2G2aI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+b5a7cd83622c747977de@syzkaller.appspotmail.com, Matheus Alves de Almeida , Jason Gerecke , Jiri Kosina , Sasha Levin Subject: [PATCH 5.10 1679/1848] HID: wacom: fix wacom_intuos_irq NULL pen_input deref Date: Wed, 18 Nov 2026 16:01:57 +0100 Message-ID: <20261118150030.077774674@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Matheus Alves de Almeida [ Upstream commit 2f985de0afbe9366af9d322ea20589712c1dc8fe ] Currently, wacom_intuos_irq() passes the parent of wacom_wac's pen_input to the dev_dbg() in the unknown report path. However, pen_input can be NULL on interfaces without a pen, causing a NULL pointer dereference. Get the HID device from the enclosing struct wacom and use hid_dbg() instead. Fixes: eb71d1bb270e ("Input: wacom - use dev_xxx() instead of naked printk()s and dbg()s") Reported-by: syzbot+b5a7cd83622c747977de@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=b5a7cd83622c747977de Signed-off-by: Matheus Alves de Almeida Reviewed-by: Jason Gerecke Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/wacom_wac.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 0301f345a0242..db48dbcb8ce40 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -1066,10 +1066,10 @@ static int wacom_intuos_general(struct wacom_wac *wacom) return 2; } -static int wacom_intuos_irq(struct wacom_wac *wacom) +static int wacom_intuos_irq(struct wacom_wac *wacom_wac) { - unsigned char *data = wacom->data; - struct input_dev *input = wacom->pen_input; + unsigned char *data = wacom_wac->data; + struct wacom *wacom = container_of(wacom_wac, struct wacom, wacom_wac); int result; if (data[0] != WACOM_REPORT_PENABLED && @@ -1080,23 +1080,23 @@ static int wacom_intuos_irq(struct wacom_wac *wacom) data[0] != WACOM_REPORT_CINTIQ && data[0] != WACOM_REPORT_CINTIQPAD && data[0] != WACOM_REPORT_INTUOS5PAD) { - dev_dbg(input->dev.parent, + hid_dbg(wacom->hdev, "%s: received unknown report #%d\n", __func__, data[0]); return 0; } /* process pad events */ - result = wacom_intuos_pad(wacom); + result = wacom_intuos_pad(wacom_wac); if (result) return result; /* process in/out prox events */ - result = wacom_intuos_inout(wacom); + result = wacom_intuos_inout(wacom_wac); if (result) return result - 1; /* process general packets */ - result = wacom_intuos_general(wacom); + result = wacom_intuos_general(wacom_wac); if (result) return result - 1; -- 2.53.0