Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795061883; b=KfabSUK2xO+Qyo2cznznHSjhjvNdGKYrYpsZH1XEIS2oZRymctiwQapO28JzVIL5XpUx CL7AY31M5pPozubn2CiENhdHN/JdjhNjUnqc/+iTQntmXcwtJcVT3ki+TS5QZdFsaJq1r 5SHZ5ED3ICkNRpI22owM+8CVk0etOqBScKKMRrdg9cm3XRfTjWxSE9utor2EWc5jaLh70 8q1JgAdArRXXpZY2n7ey2jSJCxWTtXAjJZxikUuO+tDneT4zAlza6vDXppKhiCVVxSSCz qvm1sAcxG430QpzFqO2SIjiYoVhzY5tBcD9Ay1Xag1h056096DYFvJyWYdAKZHo5wYQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795061883; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=cTXwhmTjCFEC68FuqBv1NH0A1WBX5s5oSZGc1ilp7Rg=; b=swhlHss6ZyjcAPoit1CYtr1VM290lpDAIqpiTN4q7IE7b2Ar1pZVArkXQp6q+6X8aVIQ QKhomF7iiuOLtn7JUbDUh8ce2JKPB4yn3lD336fi40AzmBA+qRzkMWf0yNW+5d28+it9B QqFQ5csGhGU4H3nc6z9fJb3ERf7nl2rHjxvOTKUR/jzXuMEpGuZTwJ827OmFy0BD4nkdP CqKrxmG0b5Wrcgulo4rVWLL2UWK0XR2S+qkqPlNf4OqeEX7IjakYrHe3qWozmigmE7RAF uyFgGK+BMMB7sFpWi1MajjOQiy73d0RMb0Ak4dz48bza8dWrqO3nQgIdcV1eILOhNow== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=QUlghw9J; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3311606A320; Thu, 19 Nov 2026 04:18:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=QUlghw9J Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0275F1F000C4; Thu, 19 Nov 2026 04:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795061883; bh=cTXwhmTjCFEC68FuqBv1NH0A1WBX5s5oSZGc1ilp7Rg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QUlghw9JgjHzV16kQSLX3K5W9Sm8/iVJaLU7b1egovZWCTCYfjBWvZWm4P01ZbAJz By+HM3cJweI38EqdwWZ85AkQMz+nI2DbWUg04l0PFrnxKGURvXJGEMUEg82rVzOOGn kWa1XOn/nwrdX9dD83ny5M49jobnBBi9VmHy4piY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Leon Romanovsky , Sasha Levin Subject: [PATCH 5.10 1712/1848] RDMA/core: Reject LAG selection when source MAC lookup fails Date: Wed, 18 Nov 2026 16:02:30 +0100 Message-ID: <20261118150031.360133659@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Leon Romanovsky [ Upstream commit fdfd099222d9de9e2f1b8d69e94494c5489272cc ] GID deletion can clear the source device association after LAG lookup retains the bonding master. Ignoring the resulting L2 lookup failure copies uninitialized source MAC bytes into the synthetic hash packet. Read the source MAC before allocating the packet and propagate lookup errors to the caller, so failed lookups cannot influence slave selection. Fixes: bd3920eac133 ("RDMA/core: Add LAG functionality") Link: https://patch.msgid.link/20261015-ib-core-fixes-v1-3-60f6da3ddec3@nvidia.com Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/core/lag.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/core/lag.c b/drivers/infiniband/core/lag.c index c18642accfce5..9f2e5431757f9 100644 --- a/drivers/infiniband/core/lag.c +++ b/drivers/infiniband/core/lag.c @@ -19,6 +19,11 @@ static struct sk_buff *rdma_build_skb(struct net_device *netdev, u8 smac[ETH_ALEN]; bool is_ipv4; int hdr_len; + int ret; + + ret = rdma_read_gid_l2_fields(ah_attr->grh.sgid_attr, NULL, smac); + if (ret) + return ERR_PTR(ret); is_ipv4 = ipv6_addr_v4mapped((struct in6_addr *)ah_attr->grh.dgid.raw); hdr_len = ETH_HLEN + sizeof(struct udphdr) + LL_RESERVED_SPACE(netdev); @@ -26,7 +31,7 @@ static struct sk_buff *rdma_build_skb(struct net_device *netdev, skb = alloc_skb(hdr_len, flags); if (!skb) - return NULL; + return ERR_PTR(-ENOMEM); skb->dev = netdev; skb_reserve(skb, hdr_len); @@ -70,7 +75,6 @@ static struct sk_buff *rdma_build_skb(struct net_device *netdev, skb_reset_mac_header(skb); eth = eth_hdr(skb); skb->protocol = eth->h_proto = htons(is_ipv4 ? ETH_P_IP : ETH_P_IPV6); - rdma_read_gid_l2_fields(ah_attr->grh.sgid_attr, NULL, smac); memcpy(eth->h_source, smac, ETH_ALEN); memcpy(eth->h_dest, ah_attr->roce.dmac, ETH_ALEN); @@ -86,8 +90,8 @@ static struct net_device *rdma_get_xmit_slave_udp(struct ib_device *device, struct sk_buff *skb; skb = rdma_build_skb(master, ah_attr, flags); - if (!skb) - return ERR_PTR(-ENOMEM); + if (IS_ERR(skb)) + return ERR_CAST(skb); rcu_read_lock(); slave = netdev_get_xmit_slave(master, skb, -- 2.53.0