Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795061892; b=2Fdm6zGlnRBGWKTJRYa2BwFb44ZQxA1a2U2o68vWiJEw5IZFt5FauzYpzFqgXyXAitSM tahd5LX+IHiXIatKB1Ze64JPbMoeZubNoAGO4Fd4tc8LgdLihxBTIXjbXb42EdBvcrK6+ Zbbqtq6ZL3rn9Q4OghqpUBo3bKWLOnYJDwbzwKE6jqd43TOqKDTMrzupRGQjR2eOmzRU2 ToNwQAN7JA9BT/pmy2GeZxb7JeEHE53Wu/Ih+COoTNt3EaGl9R7NDyyIv11OU1wB6bJab SjrLEpyusSGvso0E4Cn7cFVPxYMT6J4ptQhjUJRvST0+dx0U6i0jh0lKmHicVe45Xbg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795061892; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=4tEwWh5geEIxw+6evHxTZsfw5NldOrBX8E/ocIcjiAQ=; b=0jXCNW9Ua7k0Ct144S4mvQQLWS12Iq0D90qMcIypo6g5uhAZRMomzJCy+XjH08xre2CR APzYR3btiWsXpgyu2i7783YF7JrGxHdULFOwEUuBE09wSoPClEKsf7suKAA6RWAqwn3uu Imin4xJH7miNLv3aL7NQ3QbPAkFWaufArWlLXPp1Z2he66FLAkvfR6owkM6rTVOzQf66Z 61BEQ3KuH5QDgouVKOwHd9Wvow38ocSjNMi8FFP81rLQYBM5NE6T4jhzhtKVDAWMiDH4h qfByszp6+YB9Dgk9JwzbjeIEFXvSeqGKMlPfqBHFMYHb5bKgdhjlo9Mb119dmyqeyVQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="uJ23NQ/M"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06DD2606A320; Thu, 19 Nov 2026 04:18:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=uJ23NQ/M Received: by smtp.kernel.org (Postfix) with ESMTPSA id 590B61F000C4; Thu, 19 Nov 2026 04:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795061891; bh=4tEwWh5geEIxw+6evHxTZsfw5NldOrBX8E/ocIcjiAQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=uJ23NQ/MOzVjr00ZWZVKYs8DRgzSi6/hhzWWrX0fH7m2s4FzFRSc1JT5I4b8a/UMm 2v/esdD90dsZ4UhsmOksfdGBT3bQ7VWRcxY7vvUjtBEgnQvtr1Se3Ry5NSFl8pT32Y kxHRridg3sH8lzQruq0xG6zF91Ryr++dXTzIe7PI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, HyeongJun An , Mark Brown , Sasha Levin Subject: [PATCH 5.10 1714/1848] ASoC: codecs: sta32x: Fix definition of limiter threshold controls Date: Wed, 18 Nov 2026 16:02:32 +0100 Message-ID: <20261118150031.436009927@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: HyeongJun An [ Upstream commit e06bf60ee5bffa9eeacff0bf8b03d4572b04f67d ] The limiter attack and release thresholds are the two 4-bit halves of one register, so their maximum is 15, not 16. With 16 the controls on bits 3:0 also write bit 4, which belongs to the other threshold. Fixes: c034abf6e503 ("ASoC: add STA32X codec driver") Assisted-by: Claude:claude-opus-5-5 Signed-off-by: HyeongJun An Link: https://patch.msgid.link/179118fc7680b2b872d1f917b7fd21f54a73a6d8.1792135145.git.sammiee5311@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/sta32x.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/sta32x.c b/sound/soc/codecs/sta32x.c index add3af887515f..7bc570ba96fb5 100644 --- a/sound/soc/codecs/sta32x.c +++ b/sound/soc/codecs/sta32x.c @@ -484,21 +484,21 @@ SOC_ENUM("Limiter2 Release Rate (dB/ms)", sta32x_limiter2_release_rate_enum), * two different enum definitions; provide both */ SOC_SINGLE_TLV("Limiter1 Attack Threshold (AC Mode)", STA32X_L1ATRT, STA32X_LxA_SHIFT, - 16, 0, sta32x_limiter_ac_attack_tlv), + 15, 0, sta32x_limiter_ac_attack_tlv), SOC_SINGLE_TLV("Limiter2 Attack Threshold (AC Mode)", STA32X_L2ATRT, STA32X_LxA_SHIFT, - 16, 0, sta32x_limiter_ac_attack_tlv), + 15, 0, sta32x_limiter_ac_attack_tlv), SOC_SINGLE_TLV("Limiter1 Release Threshold (AC Mode)", STA32X_L1ATRT, STA32X_LxR_SHIFT, - 16, 0, sta32x_limiter_ac_release_tlv), + 15, 0, sta32x_limiter_ac_release_tlv), SOC_SINGLE_TLV("Limiter2 Release Threshold (AC Mode)", STA32X_L2ATRT, STA32X_LxR_SHIFT, - 16, 0, sta32x_limiter_ac_release_tlv), + 15, 0, sta32x_limiter_ac_release_tlv), SOC_SINGLE_TLV("Limiter1 Attack Threshold (DRC Mode)", STA32X_L1ATRT, STA32X_LxA_SHIFT, - 16, 0, sta32x_limiter_drc_attack_tlv), + 15, 0, sta32x_limiter_drc_attack_tlv), SOC_SINGLE_TLV("Limiter2 Attack Threshold (DRC Mode)", STA32X_L2ATRT, STA32X_LxA_SHIFT, - 16, 0, sta32x_limiter_drc_attack_tlv), + 15, 0, sta32x_limiter_drc_attack_tlv), SOC_SINGLE_TLV("Limiter1 Release Threshold (DRC Mode)", STA32X_L1ATRT, STA32X_LxR_SHIFT, - 16, 0, sta32x_limiter_drc_release_tlv), + 15, 0, sta32x_limiter_drc_release_tlv), SOC_SINGLE_TLV("Limiter2 Release Threshold (DRC Mode)", STA32X_L2ATRT, STA32X_LxR_SHIFT, - 16, 0, sta32x_limiter_drc_release_tlv), + 15, 0, sta32x_limiter_drc_release_tlv), BIQUAD_COEFS("Ch1 - Biquad 1", 0), BIQUAD_COEFS("Ch1 - Biquad 2", 5), -- 2.53.0