Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795061951; b=AZgrqlIOAIAXuNceiWENvcyXCy2785TmyF9j1RnlwjBVAeWI9E/uiAXrQOMtlDky0hVm YfLBXTIuoFB1q3kOMYq4WOg5fpU/e08lxNpI33WucXVwfJnm6uyPawJHg7P9G/gCLflUF kA6CX8Kz7xn3JKIT8M39nk1mVJDqTmvF3u6ufH8am6r7fLtlfVVdVgrQ+5HX/luOkbfhR U5Yj4a/LYTacnaT6mewVETgBc4tMQgiKk61KLi+ZZyHBV1PkW77yp0oCkajaNXPiZ1DZt cjUrJAeMQAKJwv2Qp03EWic5f1TkW9EcfbVs0vfgP+r53RBj0AunYzyKZFOuvqyk7dQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795061951; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=/6ONosKxhXrQtoRhFotFFaaCUq7B92HXIZwLIzN/k18=; b=w0HJQQeXZv2s8KF2zSKyBr6EYhxh4Z7nPJHoOp2azfGeVcMcLHu0Y10EWYo1m5pP5Fpk XAw3oQJtY0NDya705/OQ9/KmvYI+U7XAK5PynffDRhRuArkukmBXxmM64P36cmErMcVq4 aN2uaosAT4/XWM9p+cvA4azhGd4pzEpbw4gBus1w2ORDC2xQSUuYQwMcVtvyLTy6b535L mxEkDVCqDadttS3Tls4Dmy4UT6VcMQaMUKnzZKNG5mXKq8+/fg+ZH2VeR0W+/9LJZWyPM V6yKysm3jBn+oqMuRvWmQp6FRAnBihe8OFl78HBuIZpWKj8LBeCYJWuGzlrAtiFtOYg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=h7ZBB5bZ; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EBE6606A320; Thu, 19 Nov 2026 04:19:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=h7ZBB5bZ Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B7F91F000C4; Thu, 19 Nov 2026 04:19:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795061950; bh=/6ONosKxhXrQtoRhFotFFaaCUq7B92HXIZwLIzN/k18=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=h7ZBB5bZAFJm/nOHIb5kP9jcxla9M8usBy6CPOXEz1HdKxTgdGodWP5/v4+U2VNV7 DvooaiJmz2vMYsZlCr7gY+7N20gos6IkLbj4vvhuY0CanGrFBmrIj4ZL7j2EofS3Lm odxxA7QfwKXaiDGfpBiiSReVagOdQ5eOPe5Y5Sxs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Li RongQing , Leon Romanovsky , Sasha Levin Subject: [PATCH 5.10 1729/1848] RDMA/mlx5: Fix CQ resize destination index mask Date: Wed, 18 Nov 2026 16:02:47 +0100 Message-ID: <20261118150031.969877952@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Li RongQing [ Upstream commit 0fe31052d948a3a993bb2f58cd5886f7ec279ea7 ] In copy_resize_cqes, the destination CQE index is computed as (i + 1) & cq->resize_buf->nent, but resize_buf->nent is produced by roundup_pow_of_two(), so it is a power of two with exactly one bit set. Masking with a single-bit value can only yield 0 or nent itself. The buffer has nent entries, so valid indices are 0 .. nent - 1 and nent is one past the last slot; whenever the masked result is nent the following memcpy writes one entry out of bounds. Use (nent - 1) as the wrap mask instead. For a power-of-two nent, (i + 1) & (nent - 1) is the correct modulo-nent reduction, keeping the index within [0, nent - 1]. This matches get_sw_cqe(), which addresses the CQ buffer via n & cq->ibcq.cqe, where cq->ibcq.cqe == entries - 1 is exactly the nent - 1 wrap mask. Fixes: bde51583f49b ("IB/mlx5: Add support for resize CQ") Signed-off-by: Li RongQing Link: https://patch.msgid.link/20261019050503.2313-1-lirongqing@baidu.com Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/mlx5/cq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/cq.c b/drivers/infiniband/hw/mlx5/cq.c index c505017a289ba..2d7cc91e2c0f8 100644 --- a/drivers/infiniband/hw/mlx5/cq.c +++ b/drivers/infiniband/hw/mlx5/cq.c @@ -1215,7 +1215,7 @@ static int copy_resize_cqes(struct mlx5_ib_cq *cq) while (get_cqe_opcode(scqe64) != MLX5_CQE_RESIZE_CQ) { dcqe = mlx5_frag_buf_get_wqe(&cq->resize_buf->fbc, - (i + 1) & cq->resize_buf->nent); + (i + 1) & (cq->resize_buf->nent - 1)); dcqe64 = dsize == 64 ? dcqe : dcqe + 64; sw_own = sw_ownership_bit(i + 1, cq->resize_buf->nent); memcpy(dcqe, scqe, dsize); -- 2.53.0