Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795061956; b=wCnYVDimwSbzPM75TaW/WhtoughdGeFlMCd23+y1dxHO+E83PJPaWsqhpr5GLnVgxUOo 25SvfukNxGyq1ufAKgA76bvvwAlaV4E8mqrhmCVRcjVerDKFVcrKmTytVyaM7GNrbo8cB Y1M4Siycjg2sWH6z5qCeb5H3BmzIT9WEu3WxUwjV1+nzlIaV75RJC/TaOZr13Ds27jRr6 LSIDSWVpTZwaeScSQYmF80deDpKqq4Yg26vzPk2faJDOJzm/zwiLmmgX+8hc37xilvs3O Wv4eJJZT+BLTCQBBxMO3rarqt+5xTsjhILysvn/bm5byJIpFDzmMN9N4p6gnS0sk78g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795061956; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=pBtzzf+bDOy+YK/KkZ7b+YWXZzMX3Rzy6dggLicRa9g=; b=axIhjLvyWJqJInD5P6D9yD+GFQH3aRFza3middh0btZ8PAHareqJjM2iKH9RHglTQrOA brXOuK/zwfUGAu3YbcUECWXRV5SKd8jWKYVuh2G58WbzF0eQT4Dqh67tfAhfu6yuDkXI1 SsHVagBdrF5DA2aQtyEVKg0Vgkd85QzWoiy/M/4IouKHQnarOsKhFjPvaeKFz+4jXMC6h lyt6uq06fpYXWarEQlh0zekri3dzOITsdnMwBJmHX+amHIlYJLgggWTwDmxaiza76Ed2l fxm1C2MfQ1+ByFXJVBnWJIFSreJ26v3zbQKWHHZbu5gIVRTzq0sIbPIG+TXO6yKG5DQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=C9sMclZL; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F68B606A320; Thu, 19 Nov 2026 04:19:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=C9sMclZL Received: by smtp.kernel.org (Postfix) with ESMTPSA id A40421F000C4; Thu, 19 Nov 2026 04:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795061956; bh=pBtzzf+bDOy+YK/KkZ7b+YWXZzMX3Rzy6dggLicRa9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=C9sMclZLfIgyWdSqphG6k6Y0TXWz4QUCDc9lc1Eyq83Fx5ihVhIE9AHOU2skSpRfm Hk0waGiPERxOeWsH3rYkfy+9oRNiN5TODVfR+wLrPg7ZBrWtoYngfje2pZUhZ/S5UM OZ4y5Gbvij0DfjAuuKnZElIxKftJem6iIX79VoOs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Eric Dumazet , Kuniyuki Iwashima , Ido Schimmel , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 1739/1848] ipv6: account route exceptions to the netns of their dst Date: Wed, 18 Nov 2026 16:02:57 +0100 Message-ID: <20261118150032.342622328@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit 8ff017b891e89276c15f06dfd7155981d572af77 ] rt6_insert_exception() and rt6_remove_exception() update rt6_stats->fib_rt_cache of dev_net(rt6i->dst.dev), but the device of an exception dst can move to another netns while the exception is still in its bucket. This happens when the bucket is flushed from an RCU callback, for instance from nexthop_free_rcu() for the nh_info of a replaced nexthop, whose exceptions still point to live routes. If the device moves to another netns before that callback runs, the decrement hits the other netns, whose u32 counter underflows in /proc/net/rt6_stats, while the counter of the original netns never goes back down. Account exceptions to the netns their dst was allocated in, derived from dst->ops as ip6_dst_gc() already does, which does not depend on the device. The dst already relies on that netns' ip6_dst_ops being alive when it is destroyed, which happens after the exception is removed. Fixes: 81eb8447daae ("ipv6: take care of rt6_stats") Signed-off-by: Eric Dumazet Reviewed-by: Kuniyuki Iwashima Reviewed-by: Ido Schimmel Link: https://patch.msgid.link/20261016091556.2750902-1-edumazet@kernel.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/ipv6/route.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 0439d9e6a9601..98e670e425f25 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1437,6 +1437,15 @@ static struct rt6_info *rt6_make_pcpu_route(struct net *net, */ static DEFINE_SPINLOCK(rt6_exception_lock); +/* Exceptions are accounted to the netns their dst was allocated in. + * Unlike dev_net(dst->dev), it does not change when the device moves to + * another netns or when dst_dev_put() points the dst to blackhole_netdev. + */ +static struct net *rt6_exception_net(const struct rt6_info *rt) +{ + return container_of(rt->dst.ops, struct net, ipv6.ip6_dst_ops); +} + /* Remove rt6_ex from hash table and free the memory * Caller must hold rt6_exception_lock */ @@ -1449,7 +1458,7 @@ static void rt6_remove_exception(struct rt6_exception_bucket *bucket, if (!bucket || !rt6_ex) return; - net = dev_net(rt6_ex->rt6i->dst.dev); + net = rt6_exception_net(rt6_ex->rt6i); net->ipv6.rt6_stats->fib_rt_cache--; /* purge completely the exception to allow releasing the held resources: @@ -1711,7 +1720,7 @@ static int rt6_insert_exception(struct rt6_info *nrt, rt6_ex->stamp = jiffies; hlist_add_head_rcu(&rt6_ex->hlist, &bucket->chain); bucket->depth++; - net->ipv6.rt6_stats->fib_rt_cache++; + rt6_exception_net(nrt)->ipv6.rt6_stats->fib_rt_cache++; /* Randomize max depth to avoid some side channels attacks. */ max_depth = FIB6_MAX_DEPTH + prandom_u32_max(FIB6_MAX_DEPTH); -- 2.53.0