Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795061959; b=JisPSXJ7c+33rKhwIBiNpXu2RrjZ4jGR4IBoct8W+G+7yWptT0tqFz/tdvpssZvpB1ZQ pRxr0DtkdGYM6EZvqzeKdpoKSF8pJk9IhVPC35Kr8q3TweV536rIsyhIiJQTLXAfqgrE1 AJ5Qteyo2HQvo9xA66TP5Y2tv6QFiQvXgiz1hpe21TCCylD6+NdrIjoSRLtpxWJ1FK1dG E6jmcYaIzpzKLuLiLwDdp2Bwz7wEipi8fD+pSC82u1TYwH/XXdd6Q99YFmsQz80HddPPN G4XHpW1/wjLsYU/u9dBv6DhPojExLGmLF7J/o3kU9664XBTjpeCxwLlFR9J4pL47FtA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795061959; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=SbAwef7yi9F6p7o9m+vQjX8NoXKwCgj2no+9Oj5f+lQ=; b=li9DZSolTQfO3IZAWPmniP1stOv41xB0YboUNzGUmTWvEH1s9xZxbMQvO4hL4gV1t2mM o63L/FjVZvFzt5R7gMs9qFEhrNYTrulqd++vHUV9NyAkHf0ec7KDdxmQI9uOu+KH7Ngvm UREJAErjd4lCnRkGKasYTUDmt8VG/mGubVg5DX0UThDbzVAE42Y6r0v0oZF3EQp2y9Hn+ SCilDXGaiN19xnIVbDoyeInRC9yOJPGmug0UGqxJtL0FDdglr5RcsAsCw9sa5gRY3aG+f wyuNlGVjDG2wB3oP9QQHbE9pWHn1fl4xpjntK4XXFYlHG0T9BP+uJ8lFBV6hm25DXkg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=nk2ow0Uf; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25707606A325; Thu, 19 Nov 2026 04:19:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=nk2ow0Uf Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7668F1F000C4; Thu, 19 Nov 2026 04:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795061959; bh=SbAwef7yi9F6p7o9m+vQjX8NoXKwCgj2no+9Oj5f+lQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nk2ow0UfVTSfpolbSxHzdw1DqxS+kzcdovmzpV9Dgf57I2DNBZFrHF/yWbvT76SaB nnWAm2h5nlC7Q1nTiKZgOJ533i+Nt/J53nE74r6frYQP0kIRFuXCY+yNEouPisP5z7 +8xlsBeIIAEuGdp9k9TdjoYy5A/O3M78k6j4ky/Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jiale Yao , Oliver Hartkopp , Hangbin Liu , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 1740/1848] team: reject CAN, IEEE 802.15.4 and 6LoWPAN devices in team_port_add Date: Wed, 18 Nov 2026 16:02:58 +0100 Message-ID: <20261118150032.382005014@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jiale Yao [ Upstream commit 9043be310c6a4c5e57f7bba4b9870554eac7aa96 ] When the first port has a non-Ethernet type, team_setup_by_port() copies port_dev->type to the team device while netdev_priv() of the team device still holds a struct team. Several L2 stacks identify their devices by dev->type alone and then access type specific data that the team driver never sets up: - CAN protocols rely on the CAN mid-layer private data (ml_priv) - IEEE 802.15.4 code dereferences ieee802154_ptr and the mlme ops in ml_priv - the 6LoWPAN netdev notifier writes through lowpan_dev(dev) on NETDEV_DOWN and reads it on NETDEV_UP/NETDEV_CHANGE Enslaving such a device (e.g. vxcan, wpan0, lowpan0) therefore leads to NULL pointer dereferences or to writes into struct team. This is the same problem that syzbot reported for the bonding driver with a vxcan device enslaved to a bond master, which crashed in can_rx_unregister() and was fixed by commit 8ba68464e478 ("bonding: refuse to enslave CAN devices"). The team driver has the same gap. Reject ARPHRD_CAN, ARPHRD_IEEE802154, ARPHRD_IEEE802154_MONITOR and ARPHRD_6LOWPAN devices in team_port_add(). Link: https://lore.kernel.org/all/b58d98e0-8fe3-4e4e-b8a5-c1c7e647ccca@hartkopp.net/ Link: https://syzkaller.appspot.com/bug?extid=8ed98cbd0161632bce95 # bonding splat Fixes: 1d76efe1577b ("team: add support for non-ethernet devices") Signed-off-by: Jiale Yao Signed-off-by: Oliver Hartkopp Reviewed-by: Hangbin Liu Link: https://patch.msgid.link/20261019155407.61487-1-socketcan@hartkopp.net Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/team/team.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 6d7be450e57c7..f39339438cdc5 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1163,6 +1163,17 @@ static int team_port_add(struct team *team, struct net_device *port_dev, return -EINVAL; } + if (port_dev->type == ARPHRD_CAN || + port_dev->type == ARPHRD_IEEE802154 || + port_dev->type == ARPHRD_IEEE802154_MONITOR || + port_dev->type == ARPHRD_6LOWPAN) { + NL_SET_ERR_MSG(extack, + "CAN, IEEE 802.15.4 and 6LoWPAN devices can't be added as a team port"); + netdev_err(dev, "Device %s is CAN, IEEE 802.15.4 or 6LoWPAN. These device types can't be added as a team port\n", + portname); + return -EINVAL; + } + if (netif_is_team_port(port_dev)) { NL_SET_ERR_MSG(extack, "Device is already a port of a team device"); netdev_err(dev, "Device %s is already a port " -- 2.53.0