Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795062197; b=QL/VxeFMF3gfBngJDrWr2z7r9747Qx/sqR+Qy0ctHsnI0CJXlk5W74k+qhHT05WQxgM1 rMHxLxT5o9a/bBAAOLxD5jJra7JfGJ27Pt3KoiOX2KUVpqqRf+bPAcTgjEGXXzg0gAtFW /kuDg2t/3jt/18oFhxYOsAWFbv5LZ5WoZkZ7BhOeutrAKF3EVnmI/inwqiCGPqFJXytNk hmV+umcIS+SURxOdVYTwR4EgYOst/qSeMnELU78SSW7/Kx7ir6yMkWHB7saR+gwBEa2NU 6DLpE4bcxiKy01mN3INAB29fH3klnwJdHTVbNNfwNMZj9nRnvLuq6GuxPQfFnifUpHw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795062197; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=V4Zb5SngnG48OCo85XnEp0wGbYAdHmCDcDojXyfUkT8=; b=2jrwYeABWkdNwk+/FZTA0NUih3+kW8b5auJGN4+vBzToGDN2asDI8fcSkLmmM7bQQeqk 7EtjmJkGIyq5jHfTFNRaxHnTrTt+RWhBN40TvieyQ0+HeuSkhhiRctoVx2TDsRYd0y+Vc hLYu7IX55BnAEQVDYwau0DdeJghIpUAjbed49+0nvWCyFjP4rpUsMHeWtPI24iIsA5f0M UmlVKOmfmLyPYoYf75mb1K16PbjvP74UbV7HAvrhRkT5TLMpxYi7K7EHOrMr8z1h7LgPC ykIVKutpA9gaIcv3zo3LZ4g4cPlGUuPYrRbaN/ZdRvIrQibMp9hvP+A2LPm+/i/Wh3Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=YRe2G7B9; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1893606A32A; Thu, 19 Nov 2026 04:23:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=YRe2G7B9 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FC691F000C5; Thu, 19 Nov 2026 04:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795062196; bh=V4Zb5SngnG48OCo85XnEp0wGbYAdHmCDcDojXyfUkT8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=YRe2G7B9a5Lveh8zS/GmE9Ze2yxbolO3ZljnuOZkRWi/bf/4lCPqq+/+EGAvo5XUl UdsJ4G1RlIA3gockjIYp+cXTdWR4lLJwVnEgWHzh3hgao8E+3HLlFJwvAA8znZrYye ggvPhi9IMpYvUVWShHn1Fa5hm5mi6AwtJH8iT798= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Henry Martin , Dave Miller , Sasha Levin Subject: [PATCH 5.10 1773/1848] netlink: fix out-of-bounds bitmap access clearing stale mc groups Date: Wed, 18 Nov 2026 16:03:31 +0100 Message-ID: <20261118150033.607955632@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Henry Martin [ Upstream commit 6430fb7f1cc4e329e386521b7b208df443de92f2 ] netlink_realloc_groups() sizes nlk->groups to the number of groups that exist at bind/ADD_MEMBERSHIP time. When more multicast groups are registered later (e.g. a new genl family), existing sockets keep their smaller bitmap. When clearing a multicast group of a departing family, __netlink_clear_multicast_users() runs netlink_update_socket_mc() on each socket on mc_list, which does test_bit()/__assign_bit() on group - 1 with no regard to nlk->ngroups. Skip sockets whose bitmap predates the group: such a socket can never have joined it. The overflow windows differ per architecture, both needing privileged module (un)loading. On 32-bit kernels the ~54 dynamically allocated genl groups already exceed the initial 32-bit bitmap, so the table can grow there directly. On 64-bit kernels the same in-tree set fits the initial 64-bit bitmap only while allocation stays contiguous: genl_allocate_reserve_groups() takes the first free contiguous range and unregister does not compact, so an unload/reload sequence can fragment the ~59 free IDs until no fitting range remains, forcing the table past 64 bits and reaching the same stale-bitmap overflow on the next family teardown. This issue was discovered by Tencent CodeBuddy Security. Fixes: 84659eb529b3 ("[NETLIKN]: Allow removing multicast groups.") Signed-off-by: Henry Martin Signed-off-by: Dave Miller Signed-off-by: Sasha Levin --- net/netlink/af_netlink.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 7e608b03ec5eb..eeb0b633a2e5f 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -2168,8 +2168,12 @@ void __netlink_clear_multicast_users(struct sock *ksk, unsigned int group) struct netlink_table *tbl = &nl_table[ksk->sk_protocol]; struct hlist_node *tmp; - sk_for_each_bound_safe(sk, tmp, &tbl->mc_list) + sk_for_each_bound_safe(sk, tmp, &tbl->mc_list) { + /* bitmap predates the group, can't be a member */ + if (group - 1 >= nlk_sk(sk)->ngroups) + continue; netlink_update_socket_mc(nlk_sk(sk), group, 0); + } } struct nlmsghdr * -- 2.53.0