Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795062188; b=jhejNWEtBbFIYaTSUDlsjZjqa8adPxeXTZTy1DukwXbKcVN53gMhKmcNfqMoXXfTTEpn CuM1nJE4w5OlmtI779awAo/Mr9ftiSM9y7gydJyyUUhYNidfxPnJtwqdwHouN0nSQKtRO 21g20mEUBFD83ypVZxk2kH2kKo+iHEChc7/R7NQnEeUAPYR2H1yKFsufxDdXloHADvnjz nMDWMsOS7aTnm2D1hK/7/2bM2puu36Gl3xcBb0mFxMjHPgMq7ztENw+ixzhXg8gOdLjhA RsXqr3HawxTzRl3SPpDf/NGI2eX5O5RDQF6ntYKm5rL3IOvBOkFHzlFK48oyPh4i5mA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795062188; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=FazZHup/5kPo0FmkyPgX8Q4yCw/E7odQp/AAhpBYAig=; b=y8LS6P61708LbmAFZsNpVI1OtLxhVhw92DWCfS5xH0awBuXfQflMg5T2bqKPJYV9VcZF GE5e92fZ1884hx/xf1i/JGaEURz+DNYy6cyr17mnmdQhNvDkSW2h7RdGaUx2/efsPxI/c +xahOEF0yKaUoQYhyJKMxnoHzAMV/PjataAqbl9+VxMQIQKA4AvwSjDulMoa18MShXtSF glxJuLZB3SnUmMNuMZWHdYhfv4USDL55+xN5RCj8K89UHIhUCARxeQtb1puZ1fFCgovDi utkOuL3kKkUfDw5KsXZgdSWWSaJiqzutiwY/sn0lnLaIhka/MdU4t3DnPSVEb3oDm6A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=fMfwanA3; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E687606A330; Thu, 19 Nov 2026 04:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=fMfwanA3 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83C501F000C7; Thu, 19 Nov 2026 04:23:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795062188; bh=FazZHup/5kPo0FmkyPgX8Q4yCw/E7odQp/AAhpBYAig=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fMfwanA3QGr91ZaHFWOC0lk+hlnLoOIrvRE2RvTo9IWODR6XSgV6ec5C9KL6DCxWx W3k2sj4z5FW46dlAZDc485Nl1RpK3IJqPFmQHJgpjC9VQXs5ynzQokPHx6oXQmR+K7 zGdCYkQvzeefsFkr/Io+7je2Cf25JwUAEkre2020= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+0017742620a9d06f06ef@syzkaller.appspotmail.com, Nguyen Ngoc Thang , Tung Nguyen , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 1780/1848] tipc: fix refcount panic in tipc_rcv() when receiving shared skb Date: Wed, 18 Nov 2026 16:03:38 +0100 Message-ID: <20261118150033.865232623@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tung Nguyen [ Upstream commit 5308a2049b764aa55513c90c68933abf596c51d2 ] TIPC assumes that the received skb is not shared with other users. However, syzbot reports a bug triggered by receiving a shared skb: ... RIP: 0010:pskb_expand_head+0x135a/0x13a0 net/core/skbuff.c:2308 __pskb_pull_tail+0x111/0x1870 net/core/skbuff.c:2890 skb_cow_data+0x2ed/0xc50 net/core/skbuff.c:5398 tipc_aead_decrypt net/tipc/crypto.c:892 [inline] tipc_crypto_rcv+0x346/0x23d0 net/tipc/crypto.c:1843 tipc_rcv+0x4b7/0x1040 net/tipc/node.c:2119 tipc_l2_rcv_msg+0x2d9/0x470 net/tipc/bearer.c:669 deliver_ptype_list_skb net/core/dev.c:2533 [inline] ... The root cause is that local delivery hooks in the kernel (e.g., deliver_skb()) may increment the skb's reference count (`users`) before TIPC processes it on ingress. Fix this by calling skb_share_check() to ensure exclusive ownership before passing the skb to tipc_rcv(). As TIPC needs to modify the skb's data, the cloned skb needs to be uncloned when needed. This can be addressed in separate patch. Reported-by: syzbot+0017742620a9d06f06ef@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=0017742620a9d06f06ef Closes: https://lore.kernel.org/all/20261018145928.58317-1-ngocthang2710.1999@gmail.com/T/ Fixes: b97bf3fd8f6a ("[TIPC] Initial merge") Co-developed-by: Nguyen Ngoc Thang Signed-off-by: Nguyen Ngoc Thang Signed-off-by: Tung Nguyen Link: https://patch.msgid.link/20261023052921.54220-1-tung.quang.nguyen@est.tech Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/tipc/bearer.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index 7f4d825dc775d..fe56328d4ff43 100644 --- a/net/tipc/bearer.c +++ b/net/tipc/bearer.c @@ -645,6 +645,10 @@ static int tipc_l2_rcv_msg(struct sk_buff *skb, struct net_device *dev, { struct tipc_bearer *b; + skb = skb_share_check(skb, GFP_ATOMIC); + if (!skb) + return NET_RX_DROP; + rcu_read_lock(); b = rcu_dereference(dev->tipc_ptr) ?: rcu_dereference(orig_dev->tipc_ptr); -- 2.53.0