Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795062149; b=Y8RHh88KIMawN+rxLvbG6DMcWAOiy2zNCa1Ir8KGG7l0isrDFCyMr1amoohTKGH4wqd8 Z9A0VBKY8DRrHLdfVv60QHjfEE3Mh+88GxZd0GN+Wmd18mHtFh8Yj5pnH4exBGzVElomq ixgDSjNzvjKEmasKfkrg2tXV6kefrwXQvHQSAqhAJrthkSTc3dFglu11Yr6X+elQdlacR L7ZcEJ2qdlJ1auKFDM4bmCuaOZxHGmqq9MeY6QVN90QsQwtJMh9HGhHLgMv4ISf6yTLsm 5KsHpGz1AOdLaEQ+CdWGSWdy4M/ewh3M0ar4XXbXCYrWZyGq9g2b1kbk2qFVmeAEalg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795062149; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=YVhCJ2xyIuB+OwyRLz4IM1s/9Rk/i9DZ1o6mS2Zcspc=; b=XrJ7nSgZDgKzq6hA0Rvi9u53rxis/WQx6OcJTPi4fIC49CxmYiz/bbNU6rWhav4U7OCd 9eb+Yd1KJqAIp+NLbVLyswzyh8RsVDDATc9zHhf+8QI312RVWRl77R0/0ZFbFOydel5Cy cE36Ex+S1t5bpuMDqfkA23jmPujIxYvIh0iu0CzPs1vffCEDSa6FZF2F06mLxVBbOKZi3 a1FyfJ50yxCAUBXjl271te1S+aF6g65XZhIga8MFI/sityTEvm+hBxCQ51cg1kxeEgO9e 1e984WcGjaLNldQn0kLjH9CNZVzze2er/0GjpnQd0KJKCNZyzkzEbhiu5O+cz/akCvw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=h8w1zGK5; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 793D6606A325; Thu, 19 Nov 2026 04:22:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=h8w1zGK5 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6AB81F000C4; Thu, 19 Nov 2026 04:22:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795062149; bh=YVhCJ2xyIuB+OwyRLz4IM1s/9Rk/i9DZ1o6mS2Zcspc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=h8w1zGK5xgGAD6BoRfKyNQCwbrXDIt4auzALMtDatJV4tPfztF03NOuUmyijL3OYt gSV8LNyztZGkaOb6FeutN5rRSGbpDB4YfS4s8OBSEmzg9LV5UpeLrUH1XLWosYFUWH a4ljkvvadJrCFhccMzzUGrL75CEMdBQXdQTH+uk8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Chris Mason , Jens Axboe , Keith Busch , Sasha Levin Subject: [PATCH 5.10 1806/1848] nvmet-rdma: disable interrupts under rsp_wr_wait_lock Date: Wed, 18 Nov 2026 16:04:04 +0100 Message-ID: <20261118150034.920810758@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chris Mason [ Upstream commit 14e4e09443ac2b5cd90c1e313ee3c0bdd4928e0d ] rsp_wr_wait_lock protects the list of commands waiting for room in the send queue, and it's taken with plain spin_lock(). But nvmet_rdma_queue_response() calls nvmet_rdma_release_rsp() directly if ib_post_send() fails, and that processes the wait list. The call chain starts in nvmet_req_complete(), which for a block device namespace runs from the bio end_io callback, which can be in hard interrupt context. An interrupt that completes a command on a CPU holding the lock for the same queue spins forever. Lockdep over siw with a null_blk namespace: inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage Use spin_lock_irqsave() for both takers. The processing loop still drops the lock, and restores the caller's interrupt state, around nvmet_rdma_execute_command(). Fixes: 8f000cac6e7a ("nvmet-rdma: add a NVMe over Fabrics RDMA target driver") Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Chaitanya Kulkarni Signed-off-by: Chris Mason Signed-off-by: Jens Axboe Signed-off-by: Keith Busch Signed-off-by: Sasha Levin --- drivers/nvme/target/rdma.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c index 4a28767ec3ef1..b1d447cf599b9 100644 --- a/drivers/nvme/target/rdma.c +++ b/drivers/nvme/target/rdma.c @@ -511,7 +511,9 @@ static int nvmet_rdma_post_recv(struct nvmet_rdma_device *ndev, static void nvmet_rdma_process_wr_wait_list(struct nvmet_rdma_queue *queue) { - spin_lock(&queue->rsp_wr_wait_lock); + unsigned long flags; + + spin_lock_irqsave(&queue->rsp_wr_wait_lock, flags); while (!list_empty(&queue->rsp_wr_wait_list)) { struct nvmet_rdma_rsp *rsp; bool ret; @@ -520,16 +522,16 @@ static void nvmet_rdma_process_wr_wait_list(struct nvmet_rdma_queue *queue) struct nvmet_rdma_rsp, wait_list); list_del(&rsp->wait_list); - spin_unlock(&queue->rsp_wr_wait_lock); + spin_unlock_irqrestore(&queue->rsp_wr_wait_lock, flags); ret = nvmet_rdma_execute_command(rsp); - spin_lock(&queue->rsp_wr_wait_lock); + spin_lock_irqsave(&queue->rsp_wr_wait_lock, flags); if (!ret) { list_add(&rsp->wait_list, &queue->rsp_wr_wait_list); break; } } - spin_unlock(&queue->rsp_wr_wait_lock); + spin_unlock_irqrestore(&queue->rsp_wr_wait_lock, flags); } static u16 nvmet_rdma_check_pi_status(struct ib_mr *sig_mr) @@ -977,6 +979,7 @@ static bool nvmet_rdma_execute_command(struct nvmet_rdma_rsp *rsp) static void nvmet_rdma_handle_command(struct nvmet_rdma_queue *queue, struct nvmet_rdma_rsp *cmd) { + unsigned long flags; u16 status; ib_dma_sync_single_for_cpu(queue->dev->device, @@ -995,9 +998,9 @@ static void nvmet_rdma_handle_command(struct nvmet_rdma_queue *queue, goto out_err; if (unlikely(!nvmet_rdma_execute_command(cmd))) { - spin_lock(&queue->rsp_wr_wait_lock); + spin_lock_irqsave(&queue->rsp_wr_wait_lock, flags); list_add_tail(&cmd->wait_list, &queue->rsp_wr_wait_list); - spin_unlock(&queue->rsp_wr_wait_lock); + spin_unlock_irqrestore(&queue->rsp_wr_wait_lock, flags); } return; -- 2.53.0