Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795062158; b=33yju7dR8dpqAnbeC9HiFab3cmXYNU9Nfi0dAMmdcztRdPwrWBLLoOuSk2AHHlf5Z3lM 1KTqEXpoy6mIfAXNIT5Ice+iCR5hwC9tDVVXcRuWW58Wr5+PO+k0bE69/kuGh9JTw/Mer TVIgwbs9H1JSPB6gxTjAb0422xgg5qt2IFs9sl1OSEBe/MgpLhWSeor9hgCF69+Qxg5LD fJaZYuBZTaIiYVW+FE3eRrD/MF7pP3ph0dsfbvB8hEB0sVrOIExOTp50+6GxX1Gyr1YEj +rsxPYKorS483ssY36K6IbeNvLYjlWYimcS7iXtg6QRRhPi6kuV7fx37gHuoIl5nTXw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795062158; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=QRh+blYnFwlNFHAxwFJQH41SNNVftwm0jYF2wmv+F/0=; b=gNPHBz++Sv5StgjUuynRI4Gp9dTGvzu+QkZ5XRewlpAVYp/6Qy37cM4EANvrz4J8epfp EKUzPUlHIQJsdeq/6AsILVX73YevKC0qkOc3q/GPv3kW24+OP25bZ6TuJhPJqbt71df6W IxyiDv+xDLvuIQdSrxJf5EOABH+gehvSdjGI4yAxaZ5ww6Km/sjDkVodP3OxCPrW+q6Np gYtKWFxnxmzdq5iy+nXExan2YLSsYzs7q2nkpmZTRy4KXz64yN8Cjp5Ac4RlmdbbbBR9t QeyUoDPTSrkdtlFnccWadaMvn2qu7vWfaIG1Wjys3ZoaDSCcBPtUIcf+H4HFFHGka2Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Z4IRTq3W; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 214BF606A33A; Thu, 19 Nov 2026 04:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Z4IRTq3W Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E8B51F000C4; Thu, 19 Nov 2026 04:22:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795062157; bh=QRh+blYnFwlNFHAxwFJQH41SNNVftwm0jYF2wmv+F/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Z4IRTq3WkUPa6sYaz1muIwVpReC7h5BPNbJ9zz7LMFYRppizUJfWQ9IFpwmsPZP7Y IcKxQ0x7hDbW36RJYuHzuoJBPbPCPx/suuDva2QfeY8K8u0jCNJEgBmVZHg+3BcGCC ZIJHN7xKkOu9pouF/prONIrAm1leTue2iVfTNl6M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joas Antonio dos Santos , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 1809/1848] net: dcb: initialize PFC value before calling getpfccfg Date: Wed, 18 Nov 2026 16:04:07 +0100 Message-ID: <20261118150035.068262925@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joas Antonio dos Santos [ Upstream commit ca87a2dffbb550fc934647d5e8d1c4ae85590132 ] dcbnl_getpfccfg() and dcbnl_cee_fill() pass the address of an uninitialized stack u8 to the driver's getpfccfg() op and then put it into the netlink reply unconditionally. The op returns void, so the core cannot tell whether the driver wrote the value. i40e_dcbnl_get_pfc_cfg() and ice_dcbnl_get_pfc_cfg() return without writing *setting unless the DCBX agent is host managed and in CEE mode. Both drivers normally run with firmware managed DCBX (DCB_CAP_DCBX_LLD_MANAGED), and i40e with FW LLDP disabled runs host managed in IEEE mode, so on a DCB capable i40e/ice port the PFC values in DCB_CMD_PFC_GCFG and DCB_CMD_CEE_GET replies, and in the CEE part of RTNLGRP_DCB notifications, come from uninitialized stack. The same u8 is reused for all eight priorities, so this is one byte per reply. dcb_doit() only requires CAP_NET_ADMIN for RTM_SETDCB, so the GET commands are available to unprivileged users. Set the value to 0 before each call, like the PG config path already presets its outputs to DCB_ATTR_VALUE_UNDEFINED. 0 is also what the reply contains today on kernels built with CONFIG_INIT_STACK_ALL_ZERO, so nothing changes for those. Found by code inspection, compile-tested only (W=1). I don't have i40e/ice hardware to check the reply. Fixes: b94b013eb626 ("ice: Implement DCBNL support") Fixes: 5effa78e7c94 ("i40e: Add netlink callbacks support for software based DCB") Signed-off-by: Joas Antonio dos Santos Link: https://patch.msgid.link/179289284460.50470.572724041164324949@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/dcb/dcbnl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c index c0fb70936ca17..c8670b8cadc38 100644 --- a/net/dcb/dcbnl.c +++ b/net/dcb/dcbnl.c @@ -247,6 +247,7 @@ static int dcbnl_getpfccfg(struct net_device *netdev, struct nlmsghdr *nlh, if (!getall && !data[i]) continue; + value = 0; netdev->dcbnl_ops->getpfccfg(netdev, i - DCB_PFC_UP_ATTR_0, &value); ret = nla_put_u8(skb, i, value); @@ -1260,6 +1261,7 @@ static int dcbnl_cee_fill(struct sk_buff *skb, struct net_device *netdev) goto nla_put_failure; for (i = DCB_PFC_UP_ATTR_0; i <= DCB_PFC_UP_ATTR_7; i++) { + value = 0; ops->getpfccfg(netdev, i - DCB_PFC_UP_ATTR_0, &value); if (nla_put_u8(skb, i, value)) goto nla_put_failure; -- 2.53.0