Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795062177; b=mzIZ2yCYgJGdqz53uGE3jsUYXiUW9PAIP4IDJl+JerznPpYoBOaWSllljlcclMzrDJpn j8nPVt5gXXInCuFismtFGXjjcezmcEF2aN6gSSlnpXGhV22/IDOx93Oqz3FxSW/SPg35B p+idgwZ+ZmqLMF0c5/NSwDQODLJrX3CMdKdTKo+wMdTEQk6+1Yq/ApeJTQy0xIKgwEzC5 OJnvWph7l07XoePkQJAlC9cM3KbpIoQApjYBu7CWg8pJitzYWrO3a22T65QBHHvhDxDPj xeK0mHdKh6tUDqav7fJ8ev9Q6Vx03c1ZpLi48eejw6WoKoot+1u5fsV13l5JZ29PPPw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795062177; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=rQRKyvgchE0woJ2BxtkWa5+88RMQe9oTg33tZrT9chY=; b=O3vR+9dBCR3C4jGb8WvFnbWu5hJ1BnYVNx3FdZMCZ7cteTi9uCMNgZBP45SFQ2HNy4Zp +mbIHgOd+Xe+vlCaant4Cr7Bo33TCxHniyjFtOl+c5BaN6pO/U/TZd4Vbuy6yHTf2fV2K 15/LtwqfX1gqxBwzePwIULPNSk3xWln6qMXCDm30CHaLrkCtfxwBbc0Tqdn2JV10v0Y4p cMwAeifibWWET9Phokw1xB1FuFrfGxKAmHQW5lYYDi5aIjdaDv2NVlKb1xtop6ate73SI AONmljqVjwCnbawRsKxOW57eS36gr2b8tI1/IfAQrlQj8vYSuOuXwwYX9Q5oyV7p5pg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=xEHktvji; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9721C606A32F; Thu, 19 Nov 2026 04:22:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=xEHktvji Received: by smtp.kernel.org (Postfix) with ESMTPSA id A02F21F000C6; Thu, 19 Nov 2026 04:22:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795062177; bh=rQRKyvgchE0woJ2BxtkWa5+88RMQe9oTg33tZrT9chY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=xEHktvjit7iuSc0HPq0K1HYDhk6SUX8JoEI3penuwNN2FVIcKFASNbJLXZnoyanMm 4kLwMPo69Wz99gU2jdGCt0OFlOM0IeJqbb4y0hpUCVkZ98mhWtNlDZkQ+AVPoxpTW/ d9LgCryBY5V+XAoeJG3zjqId76zYnMICmrcO5I54= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jamie Nguyen , Willem de Bruijn , Hangbin Liu , Paolo Abeni , Sasha Levin Subject: [PATCH 5.10 1815/1848] selftests: net: txtimestamp: fix out-of-bounds read in raw UDP checksum Date: Wed, 18 Nov 2026 16:04:13 +0100 Message-ID: <20261118150035.471251881@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jamie Nguyen [ Upstream commit 8daacee78b3d2798fcf92398b6dff364eab64466 ] With -r (SOCK_RAW, IPPROTO_UDP) the test writes only the UDP header and payload, and the kernel adds the IP header. get_udp_csum() still expects the IP source and destination addresses to directly precede the UDP header, and reads 2 * alen bytes before the start of the buffer: 8 bytes for IPv4, 32 bytes for IPv6. ASan reports a heap-buffer-overflow for both -4 -r and -6 -r. Without ASan the read usually goes unnoticed, but it faults when the buffer is the first chunk in the heap. That happens on Ubuntu 26.04, where the kselftest runner wraps the test in uutils stdbuf, and txtimestamp.sh fails with SIGSEGV on every run. Even without a crash, -r packets were sent with a checksum computed over unrelated heap memory, so their UDP checksum was invalid. Build the pseudo-header from the destination address and checksum only the UDP header and payload. -R and -P already write daddr as both the source and destination address, so their checksums are unchanged. With -r the kernel selects the source address, which equals daddr for the loopback addresses used by txtimestamp.sh. Fixes: b52354aa068e ("selftests: expand txtimestamp with ipv6 dgram + raw and pf_packet") Signed-off-by: Jamie Nguyen Reviewed-by: Willem de Bruijn Reviewed-by: Hangbin Liu Link: https://patch.msgid.link/20261027162945.2122306-1-jamien@nvidia.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- tools/testing/selftests/net/txtimestamp.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/net/txtimestamp.c b/tools/testing/selftests/net/txtimestamp.c index fabb1d555ee5c..769905173b715 100644 --- a/tools/testing/selftests/net/txtimestamp.c +++ b/tools/testing/selftests/net/txtimestamp.c @@ -412,19 +412,25 @@ static uint16_t get_ip_csum(const uint16_t *start, int num_words, return ~sum; } -static uint16_t get_udp_csum(const struct udphdr *udph, int alen) +static uint16_t get_udp_csum(const struct udphdr *udph, bool is_ipv4) { - unsigned long pseudo_sum, csum_len; - const void *csum_start = udph; + const void *addr = is_ipv4 ? (void *)&daddr.sin_addr : &daddr6.sin6_addr; + int alen = is_ipv4 ? sizeof(struct in_addr) : sizeof(struct in6_addr); + uint16_t addr16[sizeof(struct in6_addr) / sizeof(uint16_t)]; + unsigned long pseudo_sum; + int i; pseudo_sum = htons(IPPROTO_UDP); pseudo_sum += udph->len; - /* checksum ip(v6) addresses + udp header + payload */ - csum_start -= alen * 2; - csum_len = ntohs(udph->len) + alen * 2; + /* pseudo-header source and destination: both are daddr */ + memcpy(addr16, addr, alen); + for (i = 0; i < alen / 2; i++) + pseudo_sum += 2 * addr16[i]; - return get_ip_csum(csum_start, csum_len >> 1, pseudo_sum); + /* checksum udp header + payload */ + return get_ip_csum((const uint16_t *)udph, ntohs(udph->len) >> 1, + pseudo_sum); } static int fill_header_ipv4(void *p) @@ -473,8 +479,7 @@ static void fill_header_udp(void *p, bool is_ipv4) udph->len = ntohs(sizeof(*udph) + cfg_payload_len); udph->check = 0; - udph->check = get_udp_csum(udph, is_ipv4 ? sizeof(struct in_addr) : - sizeof(struct in6_addr)); + udph->check = get_udp_csum(udph, is_ipv4); } static void do_test(int family, unsigned int report_opt) -- 2.53.0