Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795053396; b=b55jWjh/za4kR40h1peGTvfv4p6q+y3UQW2w/Zdj266lW+1yRSwozWwOvEk0UISULVzP vlD6mEmO1ZAQnziyKwlJLVq0lOX6tmuff3A8dpMuxVTbeeELRmCkOijmbDbaB4akaGrTq ZsaK12cOz8WzweRK3QMoRQ21UFkCBCCHVXiwmvQP4Ts6gycZwvo9hroYqDi3yHoEwzYI2 mlhAI6o9TX0NglpaAcYc8fOiBNFtb19aNGswkqh5YSJ6omBwECoS5J0q7/TOn0cQBZWr0 W2Ni3Etll9CkpFoZlUoeptH57rdrnV6g2xUmww4W2kZR/t/dBY/b1rFazhr5ZcnuaTg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795053396; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=/aJv8Llc00gB/voG4KxvpS3lJEOqf5FOwabjzjCA8NQ=; b=BAfLtVbbS1iyFaciLsHlq393PrwCTRo6CQH9SPX2tvwjDgfA2Z14r0fjgReQI5gwG0ic dVT21AXXHnQc9JxVlbAtSbr937Hee4rXulN/zQsNznmmOf9ZU0ktaQSnLwyt6nhB3jvf4 VJMi2r1c/MIFWeuWkCj6oVkpIq3hyVWTvPaRiIAXcXfFJVIm2qcVmMzX+ETlZ+JgElYTj ATF4UAgHu97GedexZlDVgna8XtXlG7WQG/7X+dRc+jSmGWnXhCFuNpbVA1PWEZCohG5lQ syup9ns7XzpLwyxlBsrHkjK7knhdwqOl1WZzbBOdPEqbSbapnA28Jr3eim8bNJ42PSA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=bWAVY3cH; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C2E4606A320; Thu, 19 Nov 2026 01:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=bWAVY3cH Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2CC41F000C4; Thu, 19 Nov 2026 01:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795053396; bh=/aJv8Llc00gB/voG4KxvpS3lJEOqf5FOwabjzjCA8NQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bWAVY3cHiEy4WDgt9U+ynZyD9tSjJSkh/NcGLo9diMRpcpuQNaHzFCRQ97ICssXyt 3z3n7Og9cGgZlF3UZ4hCT0eZ/Is2NdN015JjPmS9D0ife5TqXhAsR5PTLijr2TRJBe rR9RCrTYqmGDY0H0SIJrkF5BOYd0/+bLPb6sa0Xk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Josef Bacik , "Lorenzo Stoakes (ARM)" , Pasha Tatashin , Muhammad Usama Anjum , Xu Xin , "David Hildenbrand (Arm)" , Sasha Levin Subject: [PATCH 5.15 0906/2214] mm/ksm: reset the unstable trees of all nodes Date: Wed, 18 Nov 2026 15:43:02 +0100 Message-ID: <20261118150048.586164955@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Hildenbrand (Arm) [ Upstream commit 890e118e95bfc2aae4432ec2a95192d6f9193211 ] Each full scan resets ksm_nr_node_ids unstable tree roots. Enabling merge_across_nodes resets this count to 1, even if per-node roots were previously allocated. So when toggling "merge_across_nodes" 0 -> 1 -> 0, a scan that starts while the setting is 1 and continues after switching back to 0 can encounter stale unstable tree roots, resulting in UAF. Only root is allowed to change "merge_across_nodes", and the documented sequence is: "merge_across_nodes setting can be changed only when there are no ksm shared pages in the system: set run 2 to unmerge pages first, then to 1 after changing merge_across_nodes, to remerge according to the new setting." Let's fix it by tracking in ksm_nr_node_ids the actual number of allocated tree roots. remove_all_stable_nodes() and ksm_check_stable_tree() will now scan more tree roots (skipping the empty ones), which is harmless. Fixes: ef53d16cded7 ("ksm: allocate roots when needed") Cc: stable@vger.kernel.org Reported-by: Josef Bacik Acked-by: Lorenzo Stoakes (ARM) Reviewed-by: Pasha Tatashin Tested-by: Muhammad Usama Anjum Link: https://patch.msgid.link/20261031-fixes_core-v3-39-d6437171ecc3@kernel.org Reviewed-by: Xu Xin Signed-off-by: David Hildenbrand (Arm) Signed-off-by: Sasha Levin --- mm/ksm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/ksm.c b/mm/ksm.c index 48b76785db0d0..3ed1bd6085f91 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -280,6 +280,7 @@ static bool ksm_use_zero_pages __read_mostly; #ifdef CONFIG_NUMA /* Zeroed when merging across nodes is not allowed */ static unsigned int ksm_merge_across_nodes = 1; +/* Number of allocated stable and unstable tree roots. */ static int ksm_nr_node_ids = 1; #else #define ksm_merge_across_nodes 1U @@ -3054,14 +3055,13 @@ static ssize_t merge_across_nodes_store(struct kobject *kobj, else { root_stable_tree = buf; root_unstable_tree = buf + nr_node_ids; + ksm_nr_node_ids = nr_node_ids; /* Stable tree is empty but not the unstable */ root_unstable_tree[0] = one_unstable_tree[0]; } } - if (!err) { + if (!err) ksm_merge_across_nodes = knob; - ksm_nr_node_ids = knob ? 1 : nr_node_ids; - } } mutex_unlock(&ksm_thread_mutex); -- 2.53.0