Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795053698; b=wUvEK0RIA97YXvhskTbpwZXpqn98Rrk6W2IglV40kqjqsWEFIqyJdUOqYyJk9mOxra6T FEz1bNMdnecWc+e4fcxEWmrHCR2eFyqPhEClP8wBM2BBh0mJVpkL+BirHwk2eGf4Q0LTc YosxDAm+dyHZl5FtiOXYFmJtxPrDtwDr/3j0wm56M0OFF1T8C2aZzZo5yeghJsSgfZ8nE RmvlZKuKUhLOc+6Nzf7PzsFWT4yPoiDLCMptv7xUurkP43Ts7MD3XZNGSUqfAfd6N2MrD OcO+xBoC9KKMDHld61rx8fpT0vRRHYeG0VXEtYmYabfpHLzZQOOcpferlTnCR4xkamw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795053698; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=DAw/cGgIGvPfrvR3JeIugsKt5su3HWzmlEYZXkUjV20=; b=dy1rOGLcfgpi9DwUtd0l+tYUqJyrp328WHdbCgWPuGoS0RApFuqi1vzv1L7W7YlLEn0l OqA9YWJHs+xTmKg5ZgUKYDgKEqsqp5z5i6IOTZW/pPCbt6hjZ+btscrhE4PvavWW3Yl3O gEcx721a7mHeuhekQZigIGx+2KSVchbB3+j1pn051e5uDxYQ9pAoZkYhrHDziXjTHmOTb pChd5gsvgeDjTTPtP/1WO4aMcbGxhHPHT3RPJz1vBUG+xA9AWHRkx1A7mDeKp76PsEWfx B+K8rvB5mfZ/6ddxKrcQXbLOmsZYrwCllNt66rOE1kJZQ98hV+6noMFMrsSOt8CCcLw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=zAcsioCL; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D6C1606A320; Thu, 19 Nov 2026 02:01:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=zAcsioCL Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE1A31F000C4; Thu, 19 Nov 2026 02:01:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795053698; bh=DAw/cGgIGvPfrvR3JeIugsKt5su3HWzmlEYZXkUjV20=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=zAcsioCLxASfhIIg/en1aD1MMLO46wFtyiaA86yR8eVF48gMSAP+HSFTwTm2XTjTh HLQBwXJMYf6TVg9FCm8azDKcHsLF5Z+1+/XaK2sKWN//gIr3Q/BFX4jaC3sazkcCuJ XYt0axD2P9GYnjG+dj4rHg6KK4PFMNF2m8wWLNYU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kyle Zeng , David Lee , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 5.15 1010/2214] netfilter: nf_reject: initialize IPCB at inet ingress Date: Wed, 18 Nov 2026 15:44:46 +0100 Message-ID: <20261118150052.791840443@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kyle Zeng [ Upstream commit 73a73d442f9986353fe284bd1b504d0313d0f153 ] The inet ingress hook runs before ip_rcv_core() and ip6_rcv_core(), so neither IPCB nor IP6CB has been initialized when nft_reject_inet passes a packet to nf_send_unreach() or nf_send_unreach6(). skb->cb can therefore retain metadata from an earlier protocol layer. For IPv4, icmp_send() treats IPCB(skb)->opt as parsed IPv4 options. Stale option offsets can make __ip_options_echo() copy an attacker-controlled length into its 40-byte reply option buffer and overflow the stack. On an unpatched v7.2-rc5 kernel, the IPv4 reproducer produced: BUG: KASAN: stack-out-of-bounds in __ip_options_echo() Write of size 255 For IPv6, icmpv6_send() consumes IP6CB(skb) as parsed IPv6 metadata. It always uses iif for source selection and, when MIP6 is enabled, uses dsthao as an extension-header offset. These fields must not be stale. For NF_INET_INGRESS, clear the address-family-specific control block and restore its input interface before constructing the ICMP error. This matches similar initialization normally performed by ip_rcv_core() and ip6_rcv_core(). Fixes: 117ca1f8920c ("netfilter: nft_reject_inet: allow to use reject from inet ingress") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-5.6-sol Codex:gpt-5.5-cyber Signed-off-by: Kyle Zeng Co-developed-by: David Lee Signed-off-by: David Lee Signed-off-by: Pablo Neira Ayuso [ sashal: Adjusted IPv4 patch context to preserve the existing one-argument nf_reject_verify_csum(proto) call. ] Signed-off-by: Sasha Levin --- net/ipv4/netfilter/nf_reject_ipv4.c | 5 +++++ net/ipv6/netfilter/nf_reject_ipv6.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/net/ipv4/netfilter/nf_reject_ipv4.c b/net/ipv4/netfilter/nf_reject_ipv4.c index ddfb4e2b779d6..20bc81241faff 100644 --- a/net/ipv4/netfilter/nf_reject_ipv4.c +++ b/net/ipv4/netfilter/nf_reject_ipv4.c @@ -346,6 +346,11 @@ void nf_send_unreach(struct sk_buff *skb_in, int code, int hook) if (!skb_valid_dst(skb_in) && nf_reject_fill_skb_dst(skb_in) < 0) return; + if (hook == NF_INET_INGRESS) { + memset(IPCB(skb_in), 0, sizeof(*IPCB(skb_in))); + IPCB(skb_in)->iif = skb_in->skb_iif; + } + if (skb_csum_unnecessary(skb_in) || !nf_reject_verify_csum(proto)) { icmp_send(skb_in, ICMP_DEST_UNREACH, code, 0); return; diff --git a/net/ipv6/netfilter/nf_reject_ipv6.c b/net/ipv6/netfilter/nf_reject_ipv6.c index 099740342f70f..db2cf073b7e37 100644 --- a/net/ipv6/netfilter/nf_reject_ipv6.c +++ b/net/ipv6/netfilter/nf_reject_ipv6.c @@ -428,6 +428,11 @@ void nf_send_unreach6(struct net *net, struct sk_buff *skb_in, if (hooknum == NF_INET_LOCAL_OUT && skb_in->dev == NULL) skb_in->dev = net->loopback_dev; + if (hooknum == NF_INET_INGRESS) { + memset(IP6CB(skb_in), 0, sizeof(*IP6CB(skb_in))); + IP6CB(skb_in)->iif = skb_in->skb_iif; + } + if (!skb_valid_dst(skb_in) && nf_reject6_fill_skb_dst(skb_in) < 0) return; -- 2.53.0