Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795053927; b=C+ihmd+tjRtlF9Uc/X9/40IzSea3ToyFTJM8VyHL1EZg+cS/ToFSCzAASH1deTRWyzGo KJkiB6MjTyBLn55yzZbmEH4A/iSjft0Ciel5FfiJhvPeE0psWBXJ6NmryTOw4mAbJE60N HLRMxoqZuT3z5SBCc4qkm/kWzbeUCl2m0D6ryDdltAhbYyyTvRzA5DhtvLLo72kipdSZ1 2K3UrA7ZmVtTjJjEY4k49teux3oPCccffSbikFd7/MOfNlvSMC9tYeqtHDzJGILJWlMm+ BqQOXg2hO9v7v/W1zuqGWE0WYZo7WbTXx5rUCS9dy01LsKeAKKpfHuhkDfHeDCPGT+g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795053927; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=6rBdm4d3QNixjXAZoorFnCmF6YSWid+EhsKldRWsV4o=; b=L9wY/1NT6J9ZaqA3gasGLFX4Xir0Qx4rZaCM43pZ6h5w66UraUFfAsMsvgFdmGrqydS6 /iKjFCQ7vEelPI8CwtDAgRN6OYlO0cYjRj83m3hre2XNzL++FLbsKph+2/7JEEls+GDTf IKx7cDr9hMm4Bjq620fmqQyB3ubK/Nxl1ijC5HzOqLrGor2srZFm596tN33haO498vu3k 6lzmAWEgsCQnmW7L3pjUAYilqR1zHr7W2SKepoMzZYWPL0ucnIe+i9axkymf8rMSKxq7l tDYjvFJl2TU1UwH0/WgTJLDT9jmYlgr5jk/5ILQhrGUakYKqcMse8VKDGgzJZOzahpg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=bsCfMt6O; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B68C606A31C; Thu, 19 Nov 2026 02:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=bsCfMt6O Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7B0C1F000C4; Thu, 19 Nov 2026 02:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795053927; bh=6rBdm4d3QNixjXAZoorFnCmF6YSWid+EhsKldRWsV4o=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bsCfMt6OGrEHzchh/jsL40pftD0evEiQZ3dkjTqtCLkGmOIbasJo1thH5EVJuZxL3 He716TLUX09barmdvvrMWk7Yb4stMc+jM1jGmqkMVQOnl06qIBvPbkd1Iu32FS8q64 WCxVQWwhIQ8U/hwsBv4gucx+SuGHgSqC0qgco0k4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+e8200299b0556976e13c@syzkaller.appspotmail.com, Joanne Koong , Horst Birthelmer , Miklos Szeredi , Sasha Levin Subject: [PATCH 5.15 1093/2214] fuse: dont launder folios of a bad inode Date: Wed, 18 Nov 2026 15:46:09 +0100 Message-ID: <20261118150055.940674442@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joanne Koong [ Upstream commit 01d0f3d294af126f517d92c11e100525537f8be4 ] fuse_flush() and fuse_writepages() reject writing back dirty data for any inode that has been marked bad, but fuse_launder_folio() doesn't. This can cause the following warning in fuse_write_file_get() to trigger, as reported by syzbot: WARNING: fs/fuse/file.c:2043 at fuse_write_file_get fs/fuse/file.c:2043 [inline] WARNING: fs/fuse/file.c:2043 at fuse_iomap_writeback_range+0x7c8/0x18f0 fs/fuse/file.c:2227 Call Trace: iomap_writeback_folio+0x1526/0x2490 fs/iomap/buffered-io.c:2022 fuse_launder_folio+0x17b/0x240 fs/fuse/file.c:2331 folio_unmap_invalidate+0x4cd/0x830 mm/truncate.c:634 invalidate_inode_pages2_range+0x629/0xb30 mm/truncate.c:726 fuse_open+0x5a6/0x770 fs/fuse/file.c:297 This can be hit on a writeback cache mount: 1) a writeable file is open and a buffered write dirties some pages 2) another thread opens the same file read-only. fuse_open() passes the bad inode check and sends OPEN to the server. 3) a SETATTR reply with the wrong file type marks the inode bad 4) the writeable file is closed. Flush and release skip writeback because the inode is bad. The pages stay dirty but the file gets removed from write_files. 5) server replies to the OPEN. The reply has no FOPEN_KEEP_CACHE, so fuse_open() calls invalidate_inode_pages2(). 6) the invalidation finds the dirty pages and calls fuse_launder_folio(), which finds no wriable file and hits the WARN_ON in fuse_write_file_get(). Instead of trying to write back dirty data for the bad inode, fuse_launder_folio() should return -EIO. Fixes: 5d069dbe8aaf ("fuse: fix bad inode") Reported-by: syzbot+e8200299b0556976e13c@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=e8200299b0556976e13c Cc: stable@vger.kernel.org Signed-off-by: Joanne Koong Reviewed-by: Horst Birthelmer Tested-by: syzbot+e8200299b0556976e13c@syzkaller.appspotmail.com Signed-off-by: Miklos Szeredi [ sashal: Adapted the guard from fuse_launder_folio() to fuse_launder_page() using page->mapping->host instead of wpc.inode. ] Signed-off-by: Sasha Levin --- fs/fuse/file.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/fuse/file.c b/fs/fuse/file.c index b6b06f760162c..b777ec4ec8414 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -2383,6 +2383,10 @@ static int fuse_write_end(struct file *file, struct address_space *mapping, static int fuse_launder_page(struct page *page) { int err = 0; + + if (fuse_is_bad(page->mapping->host)) + return -EIO; + if (clear_page_dirty_for_io(page)) { struct inode *inode = page->mapping->host; -- 2.53.0