Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795054116; b=3hQJuenPENm8MY3yuGkLSmZ4r2Pif5ZgNF80JMy29lPx0QG3B9OqZN0MpXmSixUBP4S6 /VcBGqFzjpbDBmNIu1v9zpcPHXhPDzrdib0LTr6T43iIs5d6wfSPH+bX+OUbFC+AeJyr2 uHsjzA/9fsUGjcGYD1YaAnnfBURvIdyIH4x9UuELhG2Wgd8QM8TgH9JR976TgzGLwG3sL Qra5ym/id7h2FiK4/y/9mgSfnnSPdEyWJ83NNWr0VipLIKYr3oUaI7rC+X46cIZ25XEE5 SVVSUNjHTB6yX0wzDjZt6ExCstNiHTgcqFX+oLJNgH2xfUzd0mDzmMRVIgQtYBbEdgg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795054116; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=Fg52aNreZbI0/nDb8DFgNkNv/R4nzqJUTiwWJdI4oiY=; b=joCbBVeXn2x+JVh/hLMyviorVBnCY7KWb974LTsJlhK+vfd4TqTuY6RLrx+h94I97ewl uZavIk+150RheAczWoKll7v/WEFlZnX8a9iWu/j2500sGhvKxthGA2gR2n6qcgpDIcGMu o7CwPhP9MheYGohj6WzFal5vZGVu4UkKUviGOcODSfIltBCpmajgsxC4+wpiohK2GP4hE s9qctBTcUQf1Vr2dGrqPIbqo0DgO7M+lnN1QhvcZbMp2PfDdZxGB/oRmT5SP+yNHQu5o0 uJ08wHjF7QuxuBKVNkvgqsza7QGKIWKBa4OhVEsrapRQEri9uv2895zJPkNDae2wArQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=GRjuwVYN; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B74CF606A320; Thu, 19 Nov 2026 02:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=GRjuwVYN Received: by smtp.kernel.org (Postfix) with ESMTPSA id 126CA1F000C4; Thu, 19 Nov 2026 02:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795054116; bh=Fg52aNreZbI0/nDb8DFgNkNv/R4nzqJUTiwWJdI4oiY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=GRjuwVYNyAw8wG6ZTzXs0VnROLJt7sfYvyaRA72RG3Wwm1fooYUWNQtDg0Ljby9Oa wmDNrETiaHCPSooz8OnUdiwcreK1ZKKLYoH0k2OQmXfa5+zCqy0H1Pzv6E1ato1CFh AudUcTwjtpSGrWonX+pGs4+akjJxrKJfgrf2la0w= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sahaj Chaudhari , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 5.15 1117/2214] gpio: pca953x: Handle direction register read errors in IRQ paths Date: Wed, 18 Nov 2026 15:46:33 +0100 Message-ID: <20261118150056.802732264@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sahaj Chaudhari [ Upstream commit a0fe269293509acdd93b9cfb3f46636f7b91b33a ] Three IRQ paths ignore the result of reading the direction registers and then use the destination bitmap. pca953x_read_regs() does not populate that bitmap when regmap_bulk_read() fails, leaving the callers to use uninitialized stack data. This can select incorrect GPIOs for direction changes during IRQ bus synchronization, corrupt the saved input state during IRQ setup, or produce incorrect pending interrupt decisions. Check the read result at all three sites. Release irq_lock without changing GPIO directions on failure, leave the IRQ history untouched when pending detection fails, and propagate the error from IRQ setup. The read helper already logs the error. Fixes: 0f25fda840a9 ("gpio: pca953x: Zap ad-hoc reg_direction cache") Cc: stable@vger.kernel.org Signed-off-by: Sahaj Chaudhari Link: https://patch.msgid.link/20261018165003.3372368-1-sahaj123.sc@gmail.com Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-pca953x.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index d6ee35492721d..f9fa898fc6e6a 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -673,6 +673,7 @@ static void pca953x_irq_bus_sync_unlock(struct irq_data *d) DECLARE_BITMAP(irq_mask, MAX_LINE); DECLARE_BITMAP(reg_direction, MAX_LINE); int level; + int ret; if (chip->driver_data & PCA_PCAL) { /* Enable latch on interrupt-enabled inputs */ @@ -685,7 +686,9 @@ static void pca953x_irq_bus_sync_unlock(struct irq_data *d) } /* Switch direction to input if needed */ - pca953x_read_regs(chip, chip->regs->direction, reg_direction); + ret = pca953x_read_regs(chip, chip->regs->direction, reg_direction); + if (ret) + goto out; bitmap_or(irq_mask, chip->irq_trig_fall, chip->irq_trig_raise, gc->ngpio); bitmap_complement(reg_direction, reg_direction, gc->ngpio); @@ -695,6 +698,7 @@ static void pca953x_irq_bus_sync_unlock(struct irq_data *d) for_each_set_bit(level, irq_mask, gc->ngpio) pca953x_gpio_direction_input(&chip->gpio_chip, level); +out: mutex_unlock(&chip->irq_lock); } @@ -741,7 +745,9 @@ static bool pca953x_irq_pending(struct pca953x_chip *chip, unsigned long *pendin return false; /* Remove output pins from the equation */ - pca953x_read_regs(chip, chip->regs->direction, reg_direction); + ret = pca953x_read_regs(chip, chip->regs->direction, reg_direction); + if (ret) + return false; bitmap_copy(old_stat, chip->irq_stat, gc->ngpio); @@ -829,7 +835,9 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base) * interrupt. We have to rely on the previous read for * this purpose. */ - pca953x_read_regs(chip, chip->regs->direction, reg_direction); + ret = pca953x_read_regs(chip, chip->regs->direction, reg_direction); + if (ret) + return ret; bitmap_and(chip->irq_stat, irq_stat, reg_direction, gc->ngpio); mutex_init(&chip->irq_lock); -- 2.53.0