Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795054314; b=c/wonQ7q/gzIGsafa2RLP5F5It2ZVspmL1STTAqqr0w76arOmocx24kWXU/HhsPrtWHM iEHx511qPliCJfUO3O6hIiPErML6D9SN3p1DcZfv3Nu4evhpIi+S78x2OvpJSUZ1XqEeP DN5K3e3YD5RU+VYSdZ4KRVZVQFCYLbUfn9kwGwm8aHIJkKwsQ5PwvPZ0ckoFebbsZAfot QH+7dV+hlnGvmnDuzNfovETMEUE/LSRrZgpmlN4JeLLGHXmSaWoJ/aYO+nUcuSRYO6us0 nJo9x8X3BWBCBRSfnCOO4GvhRhdpV8WSceFjgzFC8VeXb3j4D4ZZevWKBRMaJwr6wtA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795054314; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=tl9Nq9+Y8jRKkPT3wcstvSWby3p9RvYC4cxTq8z/yFc=; b=GolB3O9GPD2uJaXrxqUj5NnezaEOc4o0RMZCIZGAplHqm8GMekp81M4OLbmCTlSzmWmB bgxRSpxMSwy6OMRyXUeWqmTv5rGed9ZFU3TVzjp8O3OkjAZ/JS4mEO3zqn8jVSQ3uZJf+ Qg6D16gDm6pLhmXDxWM3nRAOKoydebijp4ymzgWoJX6B9uuSpehGly0WeyL+f9OVLCiOs TKwEd5OOaBrdgx8Rj607K7l9QjBV/dJ8n8ZsygAwrsRQxKByj34tBByLHnrufseekBRk0 xS6U59mp84pyqRoDu/RIq/5AEXzt6JIbzSFo56n7WHOXCxzvEsL+4LwUS58lGLL+uzQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=xK5PGagw; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D587F606A31C; Thu, 19 Nov 2026 02:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=xK5PGagw Received: by smtp.kernel.org (Postfix) with ESMTPSA id 397151F000C5; Thu, 19 Nov 2026 02:11:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795054314; bh=tl9Nq9+Y8jRKkPT3wcstvSWby3p9RvYC4cxTq8z/yFc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=xK5PGagwphN9m0lRs8Ed7kO1tDdac24Ub8ZqsI3C7x2gCUhEtN7sW4VDmHP+KcFqe 1CvnPA8GURSCriAGZFypie0LAmCTuEzA+4TKfqlzhje600VmCwr/ha630wcN+EUnKG LC7d1R929hqd4tErAzmUIEMlWX1xG7RJVmuWCz6Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wei Yang , Andrew Morton , "Gregory Price (Meta)" , "David Hildenbrand (Arm)" , "Lorenzo Stoakes (ARM)" , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Sasha Levin Subject: [PATCH 5.15 1230/2214] mm/madvise: add cond_resched() in THP branch of madvise_cold_or_pageout_pte_range() Date: Wed, 18 Nov 2026 15:48:26 +0100 Message-ID: <20261118150100.957367390@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wei Yang [ Upstream commit f5cfc8e3b20ad71949a1e5623ff45882c063a71b ] During stress testing with stress-ng on a 256-CPU system, a softlockup was observed when madvise(MADV_COLD) was called on a 31GB memory region backed by transparent hugepages. The region contains 15935 THP PMD entries, and the softlockup was triggered after 14485 of them had been processed. The THP branch of madvise_cold_or_pageout_pte_range() has no scheduling point. walk_pmd_range() invokes it once per 2MB PMD entry with no cond_resched() anywhere in the loop. Each iteration calls pmdp_invalidate() which issues a synchronous TLB shootdown (dsb ish) waiting for all CPUs to acknowledge. This operation can be time-consuming under heavy system load, causing the accumulated time across all PMD entries to exceed the softlockup threshold (20s) and panic when softlockup_panic=1. On a CONFIG_PREEMPT_NONE=y kernel, there is no other opportunity to reschedule during this entire traversal. The regular PTE path already has an unconditional cond_resched() at the function tail (introduced by commit 9c276cc65a58 ("mm: introduce MADV_COLD") and commit 1a4e58cce84e ("mm: introduce MADV_PAGEOUT") when MADV_COLD and MADV_PAGEOUT were first introduced) and a conditional one inside the loop (commit b2f557a21bc8 ("mm/madvise: add cond_resched() in madvise_cold_or_pageout_pte_range()")). The THP branch never received equivalent treatment. Fix by adding cond_resched() at the huge_unlock exit path after spin_unlock(ptl) and reclaim_pages(), which is the single exit point for all goto paths in the THP branch. Crash log: watchdog: BUG: soft lockup - CPU#63 stuck for 23s! [stress-ng-vm:1665914] ... Call trace: pmdp_invalidate+0x48/0x68 madvise_cold_or_pageout_pte_range+0x84c/0xb00 walk_pmd_range.isra.0+0x1ac/0x3b0 walk_pud_range+0x120/0x190 walk_pgd_range+0x170/0x1b8 __walk_page_range+0x184/0x198 walk_page_range_vma+0x94/0x128 madvise_cold+0xd8/0x198 madvise_vma_behavior+0x234/0x638 madvise_walk_vmas.constprop.0+0xdc/0x210 madvise_do_behavior+0xa8/0x328 do_madvise+0xd8/0x140 __arm64_sys_madvise+0x2c/0xe0 Link: https://lore.kernel.org/20261010024042.4070048-1-albin_yang@163.com Signed-off-by: Wei Yang Signed-off-by: Andrew Morton Reviewed-by: Gregory Price (Meta) Acked-by: David Hildenbrand (Arm) Acked-by: Lorenzo Stoakes (ARM) Cc: Liam R. Howlett Cc: Vlastimil Babka Cc: Jann Horn Cc: [ sashal: adjusted context because reclaim_pages() uses page_list instead of folio_list ] Signed-off-by: Sasha Levin --- mm/madvise.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/madvise.c b/mm/madvise.c index fba17d32cc1d0..81fb8fce409d4 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -383,6 +383,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, spin_unlock(ptl); if (pageout) reclaim_pages(&page_list); + cond_resched(); return 0; } -- 2.53.0