Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795054452; b=qhkLV2X6Q7KFgLjgYtZggM+QeJdVTjw/bUDMqQ7oLwPMW7cVX7nNcW258oY0Xsy0zMWZ AGRqM60CyqtyykG/0HCiO/eLIwHmHCnE56Fm9ElnQgXFKMfCbkxWiBdCDALrjXVyvrYyg 9X2gTSPMsDkgPin8Qz7UBhm/uX9xgsVuqY2LoKqsUWLz/w4fi7ZJ4dMwnnrbt27fKt8ON Scpo296EIjb7F/dMJKzIgd08fe8PRAFrOYSvIS6CTsEQhqFLTBtcOmM3dRFiVUOuq6AdX 5pPVxXsqRRBLS6bZF66cLkHzPRhpFArKIbSOhcLqTrjq73QjJiuFICTl8P4+7zlM6MA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795054452; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=fXqGUbk0No6P1t0a/2yfnbieHLoyvk+vq4Fq3FN20xw=; b=OaViB9Ji0PnjifhFOhT8XS4wplClxrQZaDlMU7CkmagMVHyYbhZwd/H1dwjTiX/9JenO 8/YeZ7H/ny3XFwI+8vzSM1jXhmDayJfHA6502a05KdmzvibH2StijCvd8X2Vd0T/W+CJl z5rxczFFftRpzQE3+No8xG5xN/x4dTOJCqEvAfa4o/rBKO/X1bv2HOv2fODotThqEYq3F vAKlTayBAZ2rWdgZ1VE3R4oEkr1aYuAP5bMW+uo5ksW2YmgF6J/9Xw2uofcZbUtuAmk4q 3hcAem2NSqHuYDwJUrkKXoBXxD51HHsicBkkrcnRC23Q7pC75r8myc7/HVktjq9CTbw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=CPVZKRHb; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 503C3606A320; Thu, 19 Nov 2026 02:14:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=CPVZKRHb Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6E3F1F000C4; Thu, 19 Nov 2026 02:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795054452; bh=fXqGUbk0No6P1t0a/2yfnbieHLoyvk+vq4Fq3FN20xw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CPVZKRHbCbmr5ut/kytuUebGS0mtlaW+ZiMfynrTI0bEIfZ6+XpxzGPTNt/W27DSP IHAftq+dy+4Y+/LI2JvQ2LCSDoTGWI8tWDastiHv4yIV5N5v88rulbIew/ZRXssOOf Sv1RQOdfKVqYp4oNYpyIusFxP8hw8FPA1aymcVK8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chris Mason , "Lorenzo Stoakes (ARM)" , Pedro Falcato , Muhammad Usama Anjum , "David Hildenbrand (Arm)" , Sasha Levin Subject: [PATCH 5.15 1278/2214] mm/memory: reject remote COW faults on PFN mappings Date: Wed, 18 Nov 2026 15:49:14 +0100 Message-ID: <20261118150102.699632003@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chris Mason [ Upstream commit 8db6921cc07b74197a3866d62ed262b68aeadcf3 ] When handling a COW fault without a normal source page (PFN mappings), __wp_page_copy_user() copies from the faulting user address. For remote faults, this accesses the wrong address space, resulting in wrong data getting copied. For example, user_events updates an enable bit in the registering process's memory. If that memory needs to be faulted in, user_event_enabler_fault_fixup() calls fixup_user_fault() from a work item. Placing the enable bit in a private PFN mapping can trigger this remote COW path. Reject these faults with VM_FAULT_SIGBUS when the target mm differs from current->mm: remote faults. Ordinary (non-PFN) mappings are not affected. The user-address copy dates back to commit 6aab341e0a28 ("mm: re-architect the VM_UNPAGED logic"); likely, actual ways to get remote faults in there on COW PFN mappings appeared afterwards. But the fix is simple and straight forward. Fix generated by an LLM and sent by Chris Mason in private. Fixes: 6aab341e0a28 ("mm: re-architect the VM_UNPAGED logic") Cc: stable@vger.kernel.org Signed-off-by: Chris Mason Reviewed-by: Lorenzo Stoakes (ARM) [ david: simplify comment and description ] Reviewed-by: Pedro Falcato Tested-by: Muhammad Usama Anjum Link: https://patch.msgid.link/20261031-fixes_core-v3-35-d6437171ecc3@kernel.org Signed-off-by: David Hildenbrand (Arm) [ sashal: adapted wp_page_copy() error handling to use ret instead of err ] Signed-off-by: Sasha Levin --- mm/memory.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/mm/memory.c b/mm/memory.c index 4ca2f4c076a9a..b8882b1f9d75c 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2808,6 +2808,13 @@ static inline int cow_user_page(struct page *dst, struct page *src, return 0; } + /* + * __copy_from_user_inatomic() only works as expected for local faults. + * Reject remote faults. + */ + if (unlikely(mm != current->mm)) + return -EFAULT; + /* * If the source page was a PFN mapping, we don't have * a "struct page" for it. We do a best-effort copy by @@ -3071,6 +3078,8 @@ static vm_fault_t wp_page_copy(struct vm_fault *vmf) if (old_page) put_page(old_page); + if (ret == -EFAULT) + return VM_FAULT_SIGBUS; return ret == -EHWPOISON ? VM_FAULT_HWPOISON : 0; } } -- 2.53.0