Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795054676; b=Pr6SUDIi+Ey4+5WV2MTXnI4nwsB9a4f72GgsQqJKrHNEqhsd1CSR+Pk9wE7grcvR/Sa9 yyu83ltMRxQ+yQJsDZwbFWl3R37jXwCDqpEbdkFf6Oy/7dVZ0StBhdgyhgS/8zg+TdDmz kzHgLC9UxlF+jfeXZ0dFqsOW7riVkXXTXkaTnZF6Gw5Mmzvwxo+BVUNmw3UbG9WhGk4LM K60zbqeli9stmKC6Kkge9lvGYNUByt9Hj7gmaoIZM6KOR06WaOdAHPK1jy4Wc5uSwc8Iv k4JlK4NiV9fg8/DoFpHHxy8uIVLm5Gh0/MQMzKc7rx/UhwjWj3qVtmGujLQA75qBK5g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795054676; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=TDElwfRskZGNPOtUAlntFf0+3YP8ysmH43BdPC7usCk=; b=iwDZGTInaWw4x9kdn2EbIQ5BaBr6954YsrEPCld6ZjCh87FZ/iC/IrUmInxmuXFuym/v kUl5cJJ67XUx/oXo7ZZrgYIyCzaq1ml+k3hFQ6zrI29Ny+7BdKT44k3nRt40Iyit0BUfv NNIIsS1VRVnm/vuTA+Iez8GknzFK/l1sYM05Guy72sxU5j2A7QAfrzEiAmyhWbFSuu+p3 7pZA2QLaO26NOws2MUSRMqkggko288CXe5lVx3aoOTdQEW41ygh+VMYrqN8sjoFg+RpNs atOXdz9VdimXJaHtHtj5dBmuxR9QqhXVE98dYeQCsZ3ZzgVNpdpPCGoB0ceFTxM2gkw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=j7lFuaIY; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39C23606A31C; Thu, 19 Nov 2026 02:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=j7lFuaIY Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FDDF1F000C4; Thu, 19 Nov 2026 02:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795054676; bh=TDElwfRskZGNPOtUAlntFf0+3YP8ysmH43BdPC7usCk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=j7lFuaIYeq0zTM2NBY/5NIqQ2vJQhTYp7abr5IK95Udo+Sq2i8oDzMPVOxucS0PNt LWahmaXp37q3u1hLO4I0yBodWueyvKGiLB5cwO2KhZUzAY8/lOFs0ZmeNP3GQUDqL4 c/Q+IdYpB1/hW2/saw1srOQ1bngqahcWPdzLXyew= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Geert Uytterhoeven , Thierry Reding , Sasha Levin Subject: [PATCH 5.15 1359/2214] pwm: renesas-tpu: Improve maths to compute register settings Date: Wed, 18 Nov 2026 15:50:35 +0100 Message-ID: <20261118150105.779342825@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Uwe Kleine-König [ Upstream commit 3c173376efc461dc670b02ba2846c2a533491104 ] The newly computed register values are intended to exactly match the previously computed values. The main improvement is that the prescaler is computed without a loop that involves two divisions in each step. This uses the fact, that prescalers[i] = 1 << (2 * i). Assuming a moderately smart compiler, the needed number of divisions for the case where the requested period is too big, is reduced from 5 to 2. Signed-off-by: Uwe Kleine-König Reviewed-by: Geert Uytterhoeven Signed-off-by: Thierry Reding Stable-dep-of: 62cff15fbf2b ("pwm: renesas-tpu: Fix runtime PM reference leak") Signed-off-by: Sasha Levin --- drivers/pwm/pwm-renesas-tpu.c | 50 ++++++++++++++++++++++++----------- 1 file changed, 35 insertions(+), 15 deletions(-) diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c index ee56d28e55b8e..63e56d0cb6f77 100644 --- a/drivers/pwm/pwm-renesas-tpu.c +++ b/drivers/pwm/pwm-renesas-tpu.c @@ -244,7 +244,6 @@ static void tpu_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm) static int tpu_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, int duty_ns, int period_ns, bool enabled) { - static const unsigned int prescalers[] = { 1, 4, 16, 64 }; struct tpu_pwm_device *tpd = pwm_get_chip_data(pwm); struct tpu_device *tpu = to_tpu_device(chip); unsigned int prescaler; @@ -254,26 +253,47 @@ static int tpu_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, u32 duty; int ret; + clk_rate = clk_get_rate(tpu->clk); + + period = clk_rate / (NSEC_PER_SEC / period_ns); + /* - * Pick a prescaler to avoid overflowing the counter. - * TODO: Pick the highest acceptable prescaler. + * Find the minimal prescaler in [0..3] such that + * + * period >> (2 * prescaler) < 0x10000 + * + * This could be calculated using something like: + * + * prescaler = max(ilog2(period) / 2, 7) - 7; + * + * but given there are only four allowed results and that ilog2 isn't + * cheap on all platforms using a switch statement is more effective. */ - clk_rate = clk_get_rate(tpu->clk); + switch (period) { + case 1 ... 0xffff: + prescaler = 0; + break; - for (prescaler = 0; prescaler < ARRAY_SIZE(prescalers); ++prescaler) { - period = clk_rate / prescalers[prescaler] - / (NSEC_PER_SEC / period_ns); - if (period <= 0xffff) - break; - } + case 0x10000 ... 0x3ffff: + prescaler = 1; + break; - if (prescaler == ARRAY_SIZE(prescalers) || period == 0) { - dev_err(&tpu->pdev->dev, "clock rate mismatch\n"); - return -ENOTSUPP; + case 0x40000 ... 0xfffff: + prescaler = 2; + break; + + case 0x100000 ... 0x3fffff: + prescaler = 3; + break; + + default: + return -EINVAL; } + period >>= 2 * prescaler; + if (duty_ns) { - duty = clk_rate / prescalers[prescaler] + duty = (clk_rate >> 2 * prescaler) / (NSEC_PER_SEC / duty_ns); if (duty > period) return -EINVAL; @@ -283,7 +303,7 @@ static int tpu_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, dev_dbg(&tpu->pdev->dev, "rate %u, prescaler %u, period %u, duty %u\n", - clk_rate, prescalers[prescaler], period, duty); + clk_rate, 1 << (2 * prescaler), period, duty); if (tpd->prescaler == prescaler && tpd->period == period) duty_only = true; -- 2.53.0