Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795054978; b=UkP0AWQ6Qswm6s7OKUMnHa1pYZSYQ0grmz5fvjj64+/ySZPmh9R8FOaWxLojKJHBSL9p MUHuwZ3QLjqpa81sH4+b0KU9qgjKYPOD0066xB6Kf4imwhE9vw2umD1ITut1X1iLJCndS AUWihq/6RQvDdeVhdMQW5N4DjHvsej2NMxK8aRstOMHMIZhEBhg1ecK/NC562r7SuGiQo 75x0Q8Q0ASQQrxLbjb+jUm8ijwELFvPTeHV6WOBQfusPRS83wPjmjcSnA0cSJEwVbsYmk 1uGxEsPTjz0CWgZjmeCWlXzrQ4IPZcPLTk+PhycKrlJZyuGZS0TtMBLjAFemSorHZkw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795054978; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=ZozuKGHe7N9FRctrRLU3qZ3QQ/XQaAyQ34a4rq4gQoc=; b=ho0n3x/D5F6azOM2mMfms8IiALVKmDRaIAYXl4MvpY9buT85x592uX2Dl4oMh7gZSXGO CjD0T8kdk/f93WJHJLXEN3OFPhMgEdn+y1zPmxy4CBcBlPWS0mC+eCKbGD083ThYgtmLB bRk0+5WGIKTmRKvoMkX9jBmlLqltJSCzv62Eu8z8C9m8jG5RkPCvEBeWMX/ObggOH/zxo IE1VjJNTi5salyOegGEt/1J4AkJqZrV0q+m2cocNhpDuEFd6guX+IYvXpAAoeTg0za3es bVpc7vro7sBnFxbWx43HEtfiOloYhrqoLlB6g6U7eIk6woYjBqbl+60yA+oQbwbfNng== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=jyRgjOhq; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E506606A31C; Thu, 19 Nov 2026 02:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=jyRgjOhq Received: by smtp.kernel.org (Postfix) with ESMTPSA id 003A11F000C4; Thu, 19 Nov 2026 02:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795054978; bh=ZozuKGHe7N9FRctrRLU3qZ3QQ/XQaAyQ34a4rq4gQoc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jyRgjOhqQvhQrGiaDXQR4pv9jbkF5yT/PoRvXfeQ6bXwA0C5o8U6H8ztYkpaPyVEu LzcMY3Ek2F54QiybeAeKHu66FoRaX0SsNSy/hNYktYSMmwekwuv8Fis0uNo2AfzTS3 nacmnHv1qexW42V+7Z020Fr7hZ/bEtXV+NBOsG5I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ryan Brue , Sebastian Reichel , Sasha Levin Subject: [PATCH 5.15 1427/2214] power: supply: bq24190_charger: use the wake irq API Date: Wed, 18 Nov 2026 15:51:43 +0100 Message-ID: <20261118150108.274265411@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ryan Brue [ Upstream commit ece9baab2a6e79224d3f591893be23b540b1625f ] bq24190_probe() calls enable_irq_wake() on the charger interrupt and never calls disable_irq_wake(). That is wrong in three ways. It is unbalanced. free_irq() does not touch desc->wake_depth -- only irq_set_irq_wake() does -- so after the driver is unbound the descriptor is still one wake reference deep and the irqchip is still configured for wake, forever, for an interrupt nobody owns any more. It ignores the device's wakeup policy. The chip is made a system wake source whether or not anyone asked for it, and because device_init_wakeup() is never called there is no power/wakeup attribute for userspace to say otherwise. A board that would rather not be woken by its charger has no way to express that. And it arms the interrupt for wake permanently, from probe onwards, rather than for the sleep it is meant to cover. Use the wake irq API instead: devm_device_init_wakeup() to make the device wakeup-capable and enabled -- preserving today's behaviour -- and devm_pm_set_wake_irq() to hand the interrupt to the PM core, which arms it in dpm_suspend_noirq() (only if device_may_wakeup(), immediately before suspend_device_irqs()) and disarms it on resume. Both are unwound by devm, so the reference is balanced on unbind, and userspace gets the power/wakeup control it should have had. No intended change in behaviour: charger events still wake the system by default. The same conversion was made to another charger driver for the same reason, in commit 6c5393771c50 ("power: supply: qcom_pmi8998_charger: fix wakeirq"). Fixes: f385e6e2a153 ("power: bq24190_charger: Use PM runtime autosuspend") Assisted-by: LLM Signed-off-by: Ryan Brue Link: https://patch.msgid.link/20260908-rbrue-suez-upstreaming-bq24190_charger-use-wake-irq-api-v1-1-c3f10ae2a34a@gmail.com Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/bq24190_charger.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c index 8a4729ee1ab19..56a7e0ef53f09 100644 --- a/drivers/power/supply/bq24190_charger.c +++ b/drivers/power/supply/bq24190_charger.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -1819,7 +1820,13 @@ static int bq24190_probe(struct i2c_client *client, if (ret < 0) goto out_charger; - enable_irq_wake(client->irq); + ret = devm_device_init_wakeup(dev); + if (ret < 0) + goto out_charger; + + ret = devm_pm_set_wake_irq(dev, client->irq); + if (ret < 0) + goto out_charger; pm_runtime_mark_last_busy(dev); pm_runtime_put_autosuspend(dev); -- 2.53.0