Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795055608; b=AVPY/ps7PYXiCgmpPqP19h0VZkus41So+tQBv4x1p35OX44q+SRVJ2YkAxs6hYK8J763 TxoLRRGArc5m2tEpgaiHBzkfFo81+dZkZbJb1DeAIR2ZL1RfDQMH+MNZe2oGae5UpWqnT etmuWucR/OJj3MBlfxARqS465bHuEX3y2qu2b/m1FK4zyD8uoXV9efVX+FmtaUn8d17YP PUn4df0CLcbX2rgDu4WVg0d7qnNs4HXRaBUle3ooSvupD5QW/iqbg6oDtPdwqfvQfaEsa yp6Tac57IDpY6ol4wHvm83tFU5CdFh/UCuMZKTVL+hgffaiQLNGgpW5YtafNyEPSgSA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795055608; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=JGwLaznsAgN6xgLhi6gkfh6rfk8pSVltLMvja/zLEow=; b=CH5FNk2vXwqADR1hCaCuTg8YOmVRpB4DK/Y/fZpKxyESG/3hI6gp6WDfHoaTovyHcVYr Ng9gNDKEKTlqGVHHozrDbrRZWwn4K9/EEaG1ESZRQmn15SdIdtsetqA0RO4z4GI0JMrxe Hy2yTvjBAWKFQXZJdSoUeDCWTKXIkli9A37cv3pgM1XiN+nFXhbIO5iGxpABjE2Hk8hhW 4tnCR503rS7GsX2TmhUbHuLO8j4qpj3uDYETWztCHvWht9Y0Qutj7p3vEhSHLmj7fmHaj pQIKFHo8/WIkidVi6ieaQM+/2Dqr/GpU7u7If7X8KG5NLV0MeFCjfvQHiwhf6IogSqg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=neQPDkMD; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8F91606A32A; Thu, 19 Nov 2026 02:33:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=neQPDkMD Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD2F31F000C4; Thu, 19 Nov 2026 02:33:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795055608; bh=JGwLaznsAgN6xgLhi6gkfh6rfk8pSVltLMvja/zLEow=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=neQPDkMD6/9ABMoqiaYtaZ8NvJlr66iyyhCuTifW+cczWTwFnqXdXsk7qWTByuK4w pB2b8ds/3MuD2CmAA0gVYXrovfVzx18DoLYWsYr65KVVvEzs5Osmol4/CWZ7eFjkHx 9oVpwhQ1+yGDZD7bF4JKi/n40c/fv5AEIGt7cUBA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Linus Walleij , =?UTF-8?q?Andr=C3=A9=20Draszik?= , Alexandre Belloni , Sasha Levin Subject: [PATCH 5.15 1693/2214] rtc: ftrtc010: drop needless struct ftrtc010_rtc::rtc_dev member Date: Wed, 18 Nov 2026 15:56:09 +0100 Message-ID: <20261118150119.543026773@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: André Draszik [ Upstream commit a55d44807b63f171f8079d770c9d82fa87046cdd ] The memory pointed to by the ::rtc_dev member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Reviewed-by: Linus Walleij Signed-off-by: André Draszik Link: https://lore.kernel.org/r/20250304-rtc-cleanups-v2-6-d4689a71668c@linaro.org Signed-off-by: Alexandre Belloni Stable-dep-of: c60478875a44 ("rtc: ftrtc010: fix clock resource leak on probe failure") Signed-off-by: Sasha Levin --- drivers/rtc/rtc-ftrtc010.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-ftrtc010.c b/drivers/rtc/rtc-ftrtc010.c index 25c6e7d9570f0..14858d2faa2a7 100644 --- a/drivers/rtc/rtc-ftrtc010.c +++ b/drivers/rtc/rtc-ftrtc010.c @@ -28,7 +28,6 @@ MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:" DRV_NAME); struct ftrtc010_rtc { - struct rtc_device *rtc_dev; void __iomem *rtc_base; int rtc_irq; struct clk *pclk; @@ -113,6 +112,7 @@ static int ftrtc010_rtc_probe(struct platform_device *pdev) struct ftrtc010_rtc *rtc; struct device *dev = &pdev->dev; struct resource *res; + struct rtc_device *rtc_dev; int ret; rtc = devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); @@ -160,29 +160,28 @@ static int ftrtc010_rtc_probe(struct platform_device *pdev) goto err_disable_extclk; } - rtc->rtc_dev = devm_rtc_allocate_device(dev); - if (IS_ERR(rtc->rtc_dev)) { - ret = PTR_ERR(rtc->rtc_dev); + rtc_dev = devm_rtc_allocate_device(dev); + if (IS_ERR(rtc_dev)) { + ret = PTR_ERR(rtc_dev); goto err_disable_extclk; } - rtc->rtc_dev->ops = &ftrtc010_rtc_ops; + rtc_dev->ops = &ftrtc010_rtc_ops; sec = readl(rtc->rtc_base + FTRTC010_RTC_SECOND); min = readl(rtc->rtc_base + FTRTC010_RTC_MINUTE); hour = readl(rtc->rtc_base + FTRTC010_RTC_HOUR); days = readl(rtc->rtc_base + FTRTC010_RTC_DAYS); - rtc->rtc_dev->range_min = (u64)days * 86400 + hour * 3600 + - min * 60 + sec; - rtc->rtc_dev->range_max = U32_MAX + rtc->rtc_dev->range_min; + rtc_dev->range_min = (u64)days * 86400 + hour * 3600 + min * 60 + sec; + rtc_dev->range_max = U32_MAX + rtc_dev->range_min; ret = devm_request_irq(dev, rtc->rtc_irq, ftrtc010_rtc_interrupt, IRQF_SHARED, pdev->name, dev); if (unlikely(ret)) goto err_disable_extclk; - return devm_rtc_register_device(rtc->rtc_dev); + return devm_rtc_register_device(rtc_dev); err_disable_extclk: clk_disable_unprepare(rtc->extclk); -- 2.53.0