Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795055692; b=SvtP2wBMTGK48CKdjykP0V1EQjiyRFy3kbOwmK/ZMXnR9GLgK7p5KtWEo36/KlVROtXI mIWO0ealiAheeU/jpRU9DMlV2VhIuTrlfMPmEr0cbWXkFM+Ld0LbjRoZvJ/AEV81A2lA5 E5TfX8dbtVaGJOJDn5UVf0cujrhPKBB9VSXq1JjU3l0Ko2zRhV4uv91cqEmREKdKEN1cD oNXjpg2OfA9OOkYa2e843jjpqiM+4Yl8/ojJFlKs1ruzpK78nJDBv9uH/WnDMj5ggiHbM qQTVrp6ajfETWUXBNiB24bwKEsRFRWNHTLSXpkNTiomr0o0prSFVQgalnOOHmtIVsXw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795055692; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=MkTXcGlRzpwxM6m5oJcDk0f/J1HoLUR6xJASKWR6NqY=; b=0Z9wzkAmF0YgfuW/U7zBSf8HMgwGRw0Mghsnv23LlQd/uyqd94d8CuK0lqu0G8H6fP54 owzMS1wywjxJ+95ctrX6HzkLSSanvxLxVeTSfeCDSwvJ3ygTAeVy6RAzQ46m0gLXfCEvw 7MW29yxzg8BmNSO/V7XMpFBIUMklJNsEeRPe8jwHGj6Xct6vvtC/QXYtVFqB3GHnm1lHQ NZK0V5OZ6bptD74A85O2+ZZGbBzeDShOeDWe2CuYAwRoX6ZRt4TCEWkPl84nFus8ZTX8I 2/OClOQzF9TrltnV5VP3JeQJ5ojupVk046piuFkfN9pPkD9NfegQdctNwTWUH6WbjbQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=2ghzNuGe; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4952C606A325; Thu, 19 Nov 2026 02:34:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=2ghzNuGe Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A5341F000C4; Thu, 19 Nov 2026 02:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795055692; bh=MkTXcGlRzpwxM6m5oJcDk0f/J1HoLUR6xJASKWR6NqY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=2ghzNuGeKgzWtwGRD4t5yZWcw5NfRAK7PaZ4tdX7Lc2DjQPEnIMw5MloWZiKiRF36 v73nwdwotauVq+CSw6pcBuKbw8uX1RNsRWhcSoJDI/KJ0ff7WozSSgBVp4pyqoc2jX jZsmeGSjpjLULN3YM1qGGjJNxd8Am6l7KSoXydoo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Kai=20M=C3=A4kisara?= , Laurence Oberman , =?UTF-8?q?Kai=20M=C3=A4kisara?= , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 5.15 1720/2214] scsi: st: Record the tape position after a successful MTLOAD Date: Wed, 18 Nov 2026 15:56:36 +0100 Message-ID: <20261118150120.535424843@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Laurence Oberman [ Upstream commit 54ee0ee9bdeb7e9d3b70cc5c2bdf7e58c4423e8d ] Commit 0b120edb37dc ("scsi: st: Add MTIOCGET and MTLOAD to ioctls allowed after device reset") allows MTLOAD to clear the reset condition because the tape location is known after MTLOAD. But the driver does not record it: reset_state() sets the file and block numbers to -1, and do_load_unload() leaves them there. check_tape() sets them to 0 only for a new session, which requires a new-medium unit attention. Drives that do not report one when the medium was already loaded (seen with IBM LTO drives) keep reporting file/block -1 in MTIOCGET and no BOT, although the tape is at the beginning. After a successful load, reset the partition and the state of all partitions, as the new-session path in check_tape() does: partition 0, position at BOT, EOF state cleared and no pending write. Otherwise the driver may still record the previous partition, so that a later MTSETPART to that partition is not performed; a read after loading at EOD fails with EIO; and a partition left in the ST_WRITING state by a partition switch in read() or write() makes st_flush() write a filemark at the beginning of partition 0 when the device is closed. Fixes: 0b120edb37dc ("scsi: st: Add MTIOCGET and MTLOAD to ioctls allowed after device reset") Suggested-by: Kai Mäkisara Assisted-by: Claude sashiko Signed-off-by: Laurence Oberman Reviewed-by: Kai Mäkisara Link: https://patch.msgid.link/20260929192821.997675-3-loberman@redhat.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Sasha Levin --- drivers/scsi/st.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index 04832d5944fe8..ee300f120b8c4 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -2653,6 +2653,30 @@ static int do_load_unload(struct scsi_tape *STp, struct file *filp, int load_cod else { STp->rew_at_close = STp->autorew_dev; retval = check_tape(STp, filp); + /* + * LOAD leaves the medium at the beginning of partition + * 0. check_tape() records that only for a new session; + * without a new-medium unit attention (the medium was + * already loaded) the partition and the partition state + * would be left as before the load. Reset them as a + * new session does, for all partitions: a stale + * ST_WRITING state would make st_flush() write a + * filemark at the beginning of partition 0. + */ + if (retval == CHKRES_READY) { + int i; + + STp->partition = STp->new_partition = 0; + for (i = 0; i < ST_NBR_PARTITIONS; i++) { + STps = &(STp->ps[i]); + STps->rw = ST_IDLE; + STps->eof = ST_NOEOF; + STps->at_sm = 0; + STps->last_block_valid = 0; + STps->drv_block = 0; + STps->drv_file = 0; + } + } if (retval > 0) retval = 0; } -- 2.53.0